diff options
| author | Daniel Boles <dboles@src.gnome.org> | 2018-03-12 22:44:37 +0000 |
|---|---|---|
| committer | Daniel Boles <dboles@src.gnome.org> | 2018-03-12 23:06:21 +0000 |
| commit | 9d8fadee976d589645663eade2b83258ed0a005e (patch) | |
| tree | 52380c89c9d2b99e67a4ad840e7972746c125519 | |
| parent | 0e016686838982253b1dc161f4d9df48ce091abd (diff) | |
| download | gtk+-9d8fadee976d589645663eade2b83258ed0a005e.tar.gz | |
FileChooserWidget: Avoid crash freeing static str
Having a FileChooserDialog in location-entry mode then pressing
<primary>f to move to search mode would crash with an invalid free().
In that case, FileChooserWidget.get_subtitle() returned a static string
straight from gettext. This crashed when the GBinding from :subtitle to
FileChooserDialog’s HeaderBar:subtitle shortly tried to free the string.
Fix by duplicating the string before returning it, like all other paths.
https://bugzilla.gnome.org/show_bug.cgi?id=791004
| -rw-r--r-- | gtk/gtkfilechooserwidget.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gtk/gtkfilechooserwidget.c b/gtk/gtkfilechooserwidget.c index 5e9557ae75..e7e2d96234 100644 --- a/gtk/gtkfilechooserwidget.c +++ b/gtk/gtkfilechooserwidget.c @@ -3271,7 +3271,7 @@ gtk_file_chooser_widget_get_subtitle (GtkFileChooserWidget *impl) { gchar *location; - subtitle = _("Searching"); + subtitle = g_strdup (_("Searching")); location = gtk_places_sidebar_get_location_title (GTK_PLACES_SIDEBAR (priv->places_sidebar)); if (location) |