summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthias Clasen <mclasen@redhat.com>2014-12-04 22:26:14 -0500
committerMatthias Clasen <mclasen@redhat.com>2014-12-17 23:01:33 -0500
commitd3abcd823f65789da181dbcecbeb0322847c1fa8 (patch)
treec80b07b4e5dd15ceaa607678a57ab0bcdf045c70
parent2f9e88b664e57b833d8af403d03406318a737b0b (diff)
downloadgtk+-d3abcd823f65789da181dbcecbeb0322847c1fa8.tar.gz
places sidebar: Fix the sort function
When returning 1 for a pair (a,b), a sort function must return -1 for the pair (b,a), otherwise things can go badly. https://bugzilla.gnome.org/show_bug.cgi?id=739729
-rw-r--r--gtk/gtkplacessidebar.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c
index 94ed70edd1..05b6ee7827 100644
--- a/gtk/gtkplacessidebar.c
+++ b/gtk/gtkplacessidebar.c
@@ -3813,6 +3813,10 @@ places_sidebar_sort_func (GtkTreeModel *model,
{
retval = 1;
}
+ else if (place_type_b == PLACES_CONNECT_TO_SERVER)
+ {
+ retval = -1;
+ }
return retval;
}