| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Fixes compiler warning.
|
|
|
|
|
|
|
|
|
| |
In order to be deterministic, multiple waiting GstClockIDs needs to be
released at the same time, or else one can get into the situation that
the one being released first can add itself back again before the next
one waiting is released.
Test added for new API and old tests rewritten to comply.
|
|
|
|
|
|
|
| |
Queued frames were not released after being pushed, this
caused a leak of the GstBaseParseFrame structure.
https://bugzilla.gnome.org/show_bug.cgi?id=727883
|
|
|
|
|
|
|
|
| |
This reverts commit b9313afc75b68d986e473b76b55543456857912b.
This should be fixed in upstream libcheck instead. We want
to keep diff of our local copy to upstream libcheck
to a minimum.
|
|
|
|
| |
Coverity 206186
|
|
|
|
|
|
|
| |
a gsize is guaranteed to be positive on all systems since it's an
unsigned value.
CID #1037147
|
|
|
|
|
|
|
|
| |
a gsize is guaranteed to be positive on all systems since it's an
unsigned value.
CID #1037145
CID #1037146
|
|
|
|
| |
in reverse playback mode
|
|
|
|
|
|
|
| |
The inner if replicates the same code of the outer and is useless
as flag_segment will always be true.
Found by coverity.
|
|
|
|
|
|
|
| |
We iterate the current discont group backwards and push each GOP forwards,
starting from the last one. However if the first buffer in the current
discont group is a keyframe, we will keep it around until next time,
which is far from ideal. Just push it.
|
|
|
|
|
| |
Make sure we don't hold a ref to a buffer from before the DRAIN query by
making a copy of the last_buffer.
|
|
|
|
| |
Otherwise we report not the correct position while the state is lost.
|
|
|
|
|
|
|
| |
buffer end timestamp
Otherwise we jump forward when pausing, and go backwards a bit again
when resuming playback.
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents situations where a first branch would get seeked and
receive a buffer before all branches got seeked, and thus collected
would get called based on EOS from the previous segment.
As a consequence, during the process of seeking, don't decrease
the eospads number when a FLUSH_STOP is received.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=724571
|
| |
|
|
|
|
|
|
| |
Taken from the adder seek handling code.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726461
|
|
|
|
|
|
|
| |
This is done by introducing a new gst_adapter_copy_bytes() call that
returns a GBytes structure.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725476
|
|
|
|
| |
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725517
|
|
|
|
|
|
|
|
|
| |
If pushing the last buffer triggers a seek from downstream, do not
go into EOS if a new segment was requested.
Contains unit test
https://bugzilla.gnome.org/show_bug.cgi?id=724757
|
|
|
|
|
| |
GST_CHECKS can be simply "test*" to run run all tests (including those that are
marked broken). Update the sparse comments a bit to tell how this works.
|
|
|
|
|
|
|
|
| |
Don't set the size to -1 in automatic_eos mode (which also updates the
duration to -1). We only want automatic_eos mode influence the maxsize
calculations without any side effects.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=724564
|
|
|
|
|
|
| |
This defaults to TRUE and if it is set to FALSE it is the subclasses
responsibility to return GST_FLOW_EOS from the create() vmethod once
the stream is done.
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=710342
|
| |
|
|
|
|
|
| |
otherwise it will always use the seqnum of the event
sent by the application
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Store the eos event seqnum and use it when creating the
new eos event to be pushed downstream. To know if the eos
was caused by the eos events received on send_event, a
'forced_eos' flag is used to use the correct seqnum on
the event pushed downstream.
Useful if the application wants to check if the EOS message
was generated from its own pushed EOS or from another source
(stream really finished).
Also adds a test for this
https://bugzilla.gnome.org/show_bug.cgi?id=722791
|
|
|
|
|
|
|
|
| |
If on passthrough during reverse playback, do not accumulate buffers as
baseparse will never check for DISCONT flag to push those buffers.
So just push buffers downstream as if it was forward playback.
https://bugzilla.gnome.org/show_bug.cgi?id=721941
|
|
|
|
| |
Use a switch-case to explicitly handle all pad-modes. This way we don't log an error when the pad is not yet activated.
|
|
|
|
|
|
|
|
|
| |
TIME segments are being ignored and a standard initialized
segment is used instead. This causes issues as not properly detecting
reverse playback or not cliping output based on the segment.
This seems to be a regression from one of the GstSegment/GstEvent
redesigns on the 0.10 -> 1.0 transition
|
|
|
|
|
| |
The firt valid segment position is start + offset.
Also add some more debug and a FIXME
|
|
|
|
|
| |
This is not an error. A subclass returning FALSE for is_seekable() is one way of
saying that we can't operate in pull mode.
|
|
|
|
|
|
|
|
|
|
| |
It wasn't required, instead baseparse was using it to check the media
caps to identify if it was handling audio or video.
The pending_segment was removed and a checked_media boolean
replaced it for a more accurate naming.
https://bugzilla.gnome.org/show_bug.cgi?id=721350
|
|
|
|
|
|
|
|
|
|
|
| |
A GAP event is handled as an empty buffer by sinks and they expect
to receive start up events before GAP events (like a segment).
This is important specially if there is a GAP at the beginning of
a stream (before any buffers) so that the segment event can be
pushed downstream before the GAP
https://bugzilla.gnome.org/show_bug.cgi?id=721350
|
|
|
|
|
|
| |
Refactor code repeated 3 times to a common function
https://bugzilla.gnome.org/show_bug.cgi?id=721350
|
|
|
|
|
|
| |
Error is never NULL when we break out of the loop.
COVERITY CID 1037151
|
|
|
|
|
|
|
| |
This reverts commit 9649cd4ca19a75d0319117a77a7609e4b8c96533.
This is not right, and it's also not what coverity
is complaining about.
|
|
|
|
|
|
| |
err is always NULL by the point we reach this line
COVERITY CID 1037151
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=720199
|
| |
|
| |
|
|
|
|
|
|
|
| |
We want to abort if we higher than the maximum *OR* lower than the minimum
accepted value.
Detected by Coverity.
|
|
|
|
| |
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720029
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=720029
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=702842
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* fix typo GstBufferFlag -> GstBufferFlags
* fix typo GstFeatures -> GstCapsFeatures
* fix typo GstAllocatorParams -> GstAllocationParams
* fix typo GstContrlSources -> GstControlSource
* do not refer to gstcheck as an object
* make references gtk_init() and tcase_set_timeout() not be references
* gst_element_get_pad() renamed gst_element_get_static_pad()
* gst_clock_id_wait_async_full() renamed gst_clock_id_wait_async()
* _drop_element() is really gst_queue_array_drop_element()
* gst_pad_accept_caps() was removed, do not refer to it
* separate GST_META_TAG_MEMORY_STR declaration from description
* do not describe removed gst_collect_pads_collect()
* correctly link to GstElementClass' virtual set_context()
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=719614
|
|
|
|
|
|
|
|
| |
Fix a typo in a doc string - the property is round-trip-limit, not
roundtrip-limit.
Remove a bogus GST_WARNING that can print an uninitialised variable
and is redundant anyway.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes, packets might take a very long time to return. Such packets
usually are way too late and destabilize the regression with their
obsolete data. On Wi-Fi, round-trips of over 7 seconds have been observed.
If the limit is set to a nonzero value, packets with a round-trip period
larger than the limit are ignored.
Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
https://bugzilla.gnome.org/show_bug.cgi?id=712385
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Keep a rolling average of the round trip time for network clock
observations, favouring shorter round trips as being more accurate.
Don't pass any clock observation to the clock slaving if it has a
round-trip time greater than 2 times the average.
Actual shifts in the network topology will be noticed after some
time, as the rolling average incorporates the new round trip times.
|