1. Add more warnings for the gst core only. Various trival fixes to quiet the warnings.

Original commit message from CVS:
1. Add more warnings for the gst core only.  Various trival fixes
to quiet the warnings.

2. Fix GstBufferCopyFunc prototype.

3. Re-apply the reverted type!=0 assertion in gst_elementfactory_new.

25 files changed, 77 insertions, 31 deletions

diff --git a/gst/Makefile.am b/gst/Makefile.am
index 4eedfa2b66..be1307e14f 100644
--- a/gst/Makefile.am
+++ b/gst/Makefile.am
@@ -201,7 +201,13 @@ CFLAGS = \
 	$(LIBGST_CFLAGS) \
 	-D_GNU_SOURCE \
 	-DG_LOG_DOMAIN=g_log_domain_gstreamer \
-	-DGST_CONFIG_DIR=\""$(GST_CONFIG_DIR)"\"
+	-DGST_CONFIG_DIR=\""$(GST_CONFIG_DIR)"\" \
+	\
+	-W -Wpointer-arith -Wbad-function-cast \
+	-Wcast-align -Wsign-compare \
+	-Wmissing-prototypes -Wmissing-declarations \
+	-Wnested-externs \
+	-Winline -Wno-unused
 
 LIBS = $(LIBGST_LIBS)
 LDFLAGS = ""
diff --git a/gst/cothreads.h b/gst/cothreads.h
index d33a45f7e2..013ecd6767 100644
--- a/gst/cothreads.h
+++ b/gst/cothreads.h
@@ -66,7 +66,7 @@ struct _cothread_state {
 };
 
 
-cothread_context*		cothread_init();
+cothread_context*		cothread_init           (void);
 cothread_state*			cothread_create		(cothread_context *ctx);
 void				cothread_setfunc	(cothread_state *thread, cothread_func func,
 						         int argc, char **argv);
diff --git a/gst/gstautoplug.c b/gst/gstautoplug.c
index 3904845f58..af6a29f94e 100644
--- a/gst/gstautoplug.c
+++ b/gst/gstautoplug.c
@@ -58,6 +58,7 @@ GType gst_autoplug_get_type(void)
       sizeof(GstAutoplug),
       4,
       (GInstanceInitFunc)gst_autoplug_init,
+      NULL
     };
     autoplug_type = g_type_register_static (GST_TYPE_OBJECT, "GstAutoplug", &autoplug_info, G_TYPE_FLAG_ABSTRACT);
   }
@@ -189,6 +190,7 @@ gst_autoplugfactory_get_type (void)
       sizeof(GstAutoplugFactory),
       0,
       (GInstanceInitFunc) gst_autoplugfactory_init,
+      NULL
     };
     autoplugfactory_type = g_type_register_static (GST_TYPE_PLUGIN_FEATURE, 
 		    				  "GstAutoplugFactory", &autoplugfactory_info, 0);
diff --git a/gst/gstbin.c b/gst/gstbin.c
index de2cf7176f..ae13d092ce 100644
--- a/gst/gstbin.c
+++ b/gst/gstbin.c
@@ -87,6 +87,7 @@ gst_bin_get_type (void)
       sizeof(GstBin),
       8,
       (GInstanceInitFunc)gst_bin_init,
+      NULL
     };
     bin_type = g_type_register_static (GST_TYPE_ELEMENT, "GstBin", &bin_info, 0);
   }
@@ -170,7 +171,7 @@ gst_bin_reset_element_sched (GstElement *element, GstSchedule *sched)
 //    GST_SCHEDULE_ADD_ELEMENT (sched, element);
 }
 
-void
+static void
 gst_bin_set_element_sched (GstElement *element,GstSchedule *sched)
 {
   GList *children;
@@ -211,7 +212,7 @@ gst_bin_set_element_sched (GstElement *element,GstSchedule *sched)
 }
 
 
-void
+static void
 gst_bin_unset_element_sched (GstElement *element)
 {
   GList *children;
diff --git a/gst/gstbuffer.c b/gst/gstbuffer.c
index 3970c60176..8645ead920 100644
--- a/gst/gstbuffer.c
+++ b/gst/gstbuffer.c
@@ -357,7 +357,7 @@ gst_buffer_copy (GstBuffer *buffer)
 
   // if a copy function exists, use it, else copy the bytes
   if (buffer->copy != NULL) {
-    (buffer->copy)(buffer,newbuf);
+    newbuf = (buffer->copy)(buffer);
   } else {
     // copy the absolute size
     newbuf->size = buffer->size;
diff --git a/gst/gstbuffer.h b/gst/gstbuffer.h
index 7e27e3aeb9..269bf3ee0e 100644
--- a/gst/gstbuffer.h
+++ b/gst/gstbuffer.h
@@ -86,8 +86,8 @@ typedef enum {
 typedef struct _GstBuffer GstBuffer;
 
 
-typedef void	(*GstBufferFreeFunc)	(GstBuffer *buf);
-typedef void	(*GstBufferCopyFunc)	(GstBuffer *srcbuf,GstBuffer *dstbuf);
+typedef void       (*GstBufferFreeFunc)	(GstBuffer *buf);
+typedef GstBuffer *(*GstBufferCopyFunc)	(GstBuffer *srcbuf);
 
 
 #include <gst/gstbufferpool.h>
diff --git a/gst/gstbufferpool.c b/gst/gstbufferpool.c
index b3910f1484..c742be0335 100644
--- a/gst/gstbufferpool.c
+++ b/gst/gstbufferpool.c
@@ -194,7 +194,8 @@ gst_buffer_pool_set_buffer_free_function (GstBufferPool *pool,
  * @destroy: the copy function
  *
  * Sets the function that will be called when a buffer is copied.
- * You can use the default GstBuffer implementation (gst_buffer_copy) if you like.
+ *
+ * You may use the default GstBuffer implementation (gst_buffer_copy).
  */
 void 
 gst_buffer_pool_set_buffer_copy_function (GstBufferPool *pool, 
diff --git a/gst/gstelement.c b/gst/gstelement.c
index 7ea5d1119f..673def6e87 100644
--- a/gst/gstelement.c
+++ b/gst/gstelement.c
@@ -83,6 +83,7 @@ GType gst_element_get_type(void) {
       sizeof(GstElement),
       0,
       (GInstanceInitFunc)gst_element_init,
+      NULL
     };
     element_type = g_type_register_static(GST_TYPE_OBJECT, "GstElement", &element_info, G_TYPE_FLAG_ABSTRACT);
   }
diff --git a/gst/gstelementfactory.c b/gst/gstelementfactory.c
index 7e92d14101..4ff1aee465 100644
--- a/gst/gstelementfactory.c
+++ b/gst/gstelementfactory.c
@@ -57,6 +57,7 @@ gst_elementfactory_get_type (void)
       sizeof(GstElementFactory),
       0,
       (GInstanceInitFunc) gst_elementfactory_init,
+      NULL
     };
     elementfactory_type = g_type_register_static (GST_TYPE_PLUGIN_FEATURE, 
 		    				  "GstElementFactory", &elementfactory_info, 0);
@@ -176,6 +177,7 @@ gst_elementfactory_new (const gchar *name, GType type,
   GstElementFactory *factory;
 
   g_return_val_if_fail(name != NULL, NULL);
+  g_return_val_if_fail (type, NULL);
   g_return_val_if_fail (details, NULL);
 
   factory = gst_elementfactory_find (name);
diff --git a/gst/gstextratypes.c b/gst/gstextratypes.c
index 162bdb50a1..032f9efb9e 100644
--- a/gst/gstextratypes.c
+++ b/gst/gstextratypes.c
@@ -41,6 +41,7 @@ gst_extra_get_filename_type (void)
       0, //sizeof(GstElement),
       0,
       NULL,
+      NULL
     };
     filename_type = g_type_register_static (G_TYPE_STRING, "GstFilename", &filename_info, 0);
   }
diff --git a/gst/gstobject.c b/gst/gstobject.c
index b7df0fc0cc..0d2fb5dca7 100644
--- a/gst/gstobject.c
+++ b/gst/gstobject.c
@@ -78,6 +78,7 @@ gst_object_get_type (void)
       sizeof (GstObject),
       32,
       (GInstanceInitFunc) gst_object_init,
+      NULL
     };
     object_type = g_type_register_static (G_TYPE_OBJECT, "GstObject", &object_info, G_TYPE_FLAG_ABSTRACT);
   }
@@ -608,6 +609,7 @@ gst_signal_object_get_type (void)
       sizeof(GstSignalObject),
       16,
       (GInstanceInitFunc)gst_signal_object_init,
+      NULL
     };
     signal_object_type = g_type_register_static(G_TYPE_OBJECT, "GstSignalObject", &signal_object_info, 0);
   }
diff --git a/gst/gstpad.c b/gst/gstpad.c
index fc5edb9b4d..8221253d91 100644
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -55,6 +55,7 @@ gst_pad_get_type(void) {
       sizeof(GstPad),
       32,
       (GInstanceInitFunc)gst_pad_init,
+      NULL
     };
     pad_type = g_type_register_static(GST_TYPE_OBJECT, "GstPad", &pad_info, 0);
   }
@@ -124,6 +125,7 @@ gst_real_pad_get_type(void) {
       sizeof(GstRealPad),
       32,
       (GInstanceInitFunc)gst_real_pad_init,
+      NULL
     };
     pad_type = g_type_register_static(GST_TYPE_PAD, "GstRealPad", &pad_info, 0);
   }
@@ -1442,7 +1444,9 @@ gst_pad_push (GstPad *pad, GstBuffer *buf)
           GST_DEBUG_FUNCPTR_NAME (peer->chainhandler), GST_DEBUG_PAD_NAME (((GstPad*)peer)));
     (peer->chainhandler) (((GstPad*)peer), buf);
   } else
-    GST_DEBUG (GST_CAT_DATAFLOW, "no chainhandler\n");
+    {
+      GST_DEBUG (GST_CAT_DATAFLOW, "no chainhandler\n");
+    }
 }
 #endif
 
@@ -1633,6 +1637,7 @@ gst_padtemplate_get_type (void)
       sizeof(GstPadTemplate),
       32,
       (GInstanceInitFunc)gst_padtemplate_init,
+      NULL
     };
     padtemplate_type = g_type_register_static(GST_TYPE_OBJECT, "GstPadTemplate", &padtemplate_info, 0);
   }
@@ -1882,6 +1887,7 @@ gst_ghost_pad_get_type(void) {
       sizeof(GstGhostPad),
       8,
       (GInstanceInitFunc)gst_ghost_pad_init,
+      NULL
     };
     pad_type = g_type_register_static(GST_TYPE_PAD, "GstGhostPad", &pad_info, 0);
   }
diff --git a/gst/gstpad.h b/gst/gstpad.h
index a108191dbb..cda8b229b0 100644
--- a/gst/gstpad.h
+++ b/gst/gstpad.h
@@ -400,6 +400,9 @@ GstCaps*		gst_padtemplate_get_caps_by_name	(GstPadTemplate *templ, const gchar *
 xmlNodePtr		gst_padtemplate_save_thyself	(GstPadTemplate *templ, xmlNodePtr parent);
 GstPadTemplate*		gst_padtemplate_load_thyself	(xmlNodePtr parent);
 
+xmlNodePtr              gst_pad_ghost_save_thyself   (GstPad *pad,
+						      GstElement *bin,
+						      xmlNodePtr parent);
 
 #ifdef __cplusplus
 }
diff --git a/gst/gstparse.c b/gst/gstparse.c
index 8e2fbf80d4..9db99ba565 100644
--- a/gst/gstparse.c
+++ b/gst/gstparse.c
@@ -88,9 +88,11 @@ dynamic_connect (GstElement *element, GstPad *newpad, gpointer data)
 static gchar *
 gst_parse_unique_name(gchar *type,gst_parse_priv *priv)
 {
+  gpointer tmp;
   gint count;
 
-  count = GPOINTER_TO_INT(g_hash_table_lookup(priv->elementcounts,type));
+  tmp = g_hash_table_lookup (priv->elementcounts,type);
+  count = GPOINTER_TO_INT (tmp);
   count++;
   g_hash_table_insert(priv->elementcounts,type,GINT_TO_POINTER(count));
 
@@ -467,9 +469,10 @@ GST_DEBUG_PAD_NAME(temppad),GST_ELEMENT_NAME (parent),GST_PAD_NAME(temppad));
 
   if (retval) return retval;
 
-  if (closingchar != '\0')
-    DEBUG("returning IN THE WRONG PLACE\n");
-  else DEBUG("ending pipeline\n");
+  DEBUG (closingchar != '\0'?
+	 "returning IN THE WRONG PLACE\n" : 
+	 "ending pipeline\n");
+
   return i+1;
 }
 
diff --git a/gst/gstpipeline.c b/gst/gstpipeline.c
index 85a67dadea..18c73fcffa 100644
--- a/gst/gstpipeline.c
+++ b/gst/gstpipeline.c
@@ -75,6 +75,7 @@ gst_pipeline_get_type (void) {
       sizeof(GstPipeline),
       0,
       (GInstanceInitFunc)gst_pipeline_init,
+      NULL
     };
     pipeline_type = g_type_register_static (GST_TYPE_BIN, "GstPipeline", &pipeline_info, 0);
   }
diff --git a/gst/gstplugin.c b/gst/gstplugin.c
index 128ae2aa04..a540a77b4b 100644
--- a/gst/gstplugin.c
+++ b/gst/gstplugin.c
@@ -674,7 +674,7 @@ gst_plugin_find_feature_func (GstPlugin *plugin, const gchar *name, GType type)
   return NULL;
 }
 
-GstPluginFeature*
+static GstPluginFeature*
 gst_plugin_find_feature (const gchar *name, GType type)
 {
   GList *plugins;
diff --git a/gst/gstpluginfeature.c b/gst/gstpluginfeature.c
index 7e81444079..11021ef2c7 100644
--- a/gst/gstpluginfeature.c
+++ b/gst/gstpluginfeature.c
@@ -51,6 +51,7 @@ gst_plugin_feature_get_type (void)
       sizeof (GstObject),
       32,
       (GInstanceInitFunc) gst_plugin_feature_init,
+      NULL
     };
     plugin_feature_type = g_type_register_static (GST_TYPE_OBJECT, "GstPluginFeature", 
 		    				  &plugin_feature_info, G_TYPE_FLAG_ABSTRACT);
diff --git a/gst/gstqueue.c b/gst/gstqueue.c
index fdf8bfec54..08cc5f8a60 100644
--- a/gst/gstqueue.c
+++ b/gst/gstqueue.c
@@ -121,6 +121,7 @@ gst_queue_get_type(void)
       sizeof(GstQueue),
       4,
       (GInstanceInitFunc)gst_queue_init,
+      NULL
     };
     queue_type = g_type_register_static (GST_TYPE_ELEMENT, "GstQueue", &queue_info, 0);
   }
diff --git a/gst/gstscheduler.c b/gst/gstscheduler.c
index 77f01d048b..b24012d9f0 100644
--- a/gst/gstscheduler.c
+++ b/gst/gstscheduler.c
@@ -842,6 +842,7 @@ GType gst_schedule_get_type(void) {
       sizeof(GstSchedule),
       0,
       (GInstanceInitFunc)gst_schedule_init,
+      NULL
     };
     schedule_type = g_type_register_static(GST_TYPE_OBJECT, "GstSchedule", &schedule_info, 0);
   }
@@ -910,7 +911,7 @@ GstElement *gst_schedule_check_pad (GstSchedule *sched, GstPad *pad) {
 }
 */
 
-GstScheduleChain *
+static GstScheduleChain *
 gst_schedule_chain_new (GstSchedule *sched)
 {
   GstScheduleChain *chain = g_new (GstScheduleChain, 1);
@@ -934,7 +935,7 @@ gst_schedule_chain_new (GstSchedule *sched)
   return chain;
 }
 
-void
+static void
 gst_schedule_chain_destroy (GstScheduleChain *chain)
 {
   GstSchedule *sched = chain->sched;
@@ -951,7 +952,7 @@ gst_schedule_chain_destroy (GstScheduleChain *chain)
   GST_INFO (GST_CAT_SCHEDULING, "destroyed chain %p, now are %d chains in sched %p",chain,sched->num_chains,sched);
 }
 
-void
+static void
 gst_schedule_chain_add_element (GstScheduleChain *chain, GstElement *element)
 {
   GST_INFO (GST_CAT_SCHEDULING, "adding element \"%s\" to chain %p", GST_ELEMENT_NAME (element),chain);
@@ -964,7 +965,7 @@ gst_schedule_chain_add_element (GstScheduleChain *chain, GstElement *element)
   chain->num_elements++;
 }
 
-void
+static void
 gst_schedule_chain_enable_element (GstScheduleChain *chain, GstElement *element)
 {
   GST_INFO (GST_CAT_SCHEDULING, "enabling element \"%s\" in chain %p", GST_ELEMENT_NAME (element),chain);
@@ -979,7 +980,7 @@ gst_schedule_chain_enable_element (GstScheduleChain *chain, GstElement *element)
   gst_schedule_cothreaded_chain(GST_BIN(chain->sched->parent),chain);
 }
 
-void
+static void
 gst_schedule_chain_disable_element (GstScheduleChain *chain, GstElement *element)
 {
   GST_INFO (GST_CAT_SCHEDULING, "disabling element \"%s\" in chain %p", GST_ELEMENT_NAME (element),chain);
@@ -995,7 +996,7 @@ gst_schedule_chain_disable_element (GstScheduleChain *chain, GstElement *element
 //  gst_schedule_cothreaded_chain(GST_BIN(chain->sched->parent),chain);
 }
 
-void
+static void
 gst_schedule_chain_remove_element (GstScheduleChain *chain, GstElement *element)
 {
   GST_INFO (GST_CAT_SCHEDULING, "removing element \"%s\" from chain %p", GST_ELEMENT_NAME (element),chain);
@@ -1017,7 +1018,7 @@ gst_schedule_chain_remove_element (GstScheduleChain *chain, GstElement *element)
   element->sched = NULL;
 }
 
-void
+static void
 gst_schedule_chain_elements (GstSchedule *sched, GstElement *element1, GstElement *element2)
 {
   GList *chains;
@@ -1103,7 +1104,7 @@ GST_ELEMENT_SCHED(srcelement),GST_ELEMENT_SCHED(sinkelement));
 }
 
 // find the chain within the schedule that holds the element, if any
-GstScheduleChain *
+static GstScheduleChain *
 gst_schedule_find_chain (GstSchedule *sched, GstElement *element)
 {
   GList *chains;
@@ -1125,7 +1126,7 @@ gst_schedule_find_chain (GstSchedule *sched, GstElement *element)
   return NULL;
 }
 
-void
+static void
 gst_schedule_chain_recursive_add (GstScheduleChain *chain, GstElement *element)
 {
   GList *pads;
diff --git a/gst/gstthread.c b/gst/gstthread.c
index 23a91c1467..06a1c7c7c1 100644
--- a/gst/gstthread.c
+++ b/gst/gstthread.c
@@ -95,6 +95,7 @@ gst_thread_get_type(void) {
       sizeof(GstThread),
       4,
       (GInstanceInitFunc)gst_thread_init,
+      NULL
     };
     thread_type = g_type_register_static(GST_TYPE_BIN, "GstThread", &thread_info, 0);
   }
diff --git a/gst/gsttype.c b/gst/gsttype.c
index 99bee4c2d8..feeac26506 100644
--- a/gst/gsttype.c
+++ b/gst/gsttype.c
@@ -69,6 +69,7 @@ gst_typefactory_get_type (void)
       sizeof(GstTypeFactory),
       0,
       (GInstanceInitFunc) gst_typefactory_init,
+      NULL
     };
     typefactory_type = g_type_register_static (GST_TYPE_PLUGIN_FEATURE,
                                                "GstTypeFactory", &typefactory_info, 0);
diff --git a/gst/gsttypefind.c b/gst/gsttypefind.c
index 09894e0de1..44a557ee3d 100644
--- a/gst/gsttypefind.c
+++ b/gst/gsttypefind.c
@@ -81,6 +81,7 @@ gst_typefind_get_type (void)
       sizeof(GstTypeFind),
       0,
       (GInstanceInitFunc)gst_typefind_init,
+      NULL
     };
     typefind_type = g_type_register_static (GST_TYPE_ELEMENT, "GstTypeFind", &typefind_info, 0);
   }
diff --git a/gst/gstutils.c b/gst/gstutils.c
index 7681ad3e11..ccd9446610 100644
--- a/gst/gstutils.c
+++ b/gst/gstutils.c
@@ -28,6 +28,8 @@
 
 #include "gstextratypes.h"
 
+#define ZERO(mem) memset(&mem, 0, sizeof(mem))
+
 /**
  * gst_util_get_int_arg:
  * @object: the object to query
@@ -40,8 +42,9 @@
 gint
 gst_util_get_int_arg (GObject *object, const gchar *argname) 
 {
-  GValue value = {0, };
+  GValue value;
 
+  ZERO (value);
   g_value_init (&value, G_TYPE_INT);
   g_object_get_property(G_OBJECT(object),argname,&value);
 
@@ -60,8 +63,9 @@ gst_util_get_int_arg (GObject *object, const gchar *argname)
 gint
 gst_util_get_bool_arg (GObject *object, const gchar *argname) 
 {
-  GValue value = {0, };
+  GValue value;
 
+  ZERO (value);
   g_value_init (&value, G_TYPE_BOOLEAN);
   g_object_get_property(G_OBJECT(object),argname,&value);
 
@@ -80,8 +84,9 @@ gst_util_get_bool_arg (GObject *object, const gchar *argname)
 glong
 gst_util_get_long_arg (GObject *object, const gchar *argname) 
 {
-  GValue value = {0, };
+  GValue value;
 
+  ZERO (value);
   g_value_init (&value, G_TYPE_LONG);
   g_object_get_property(G_OBJECT(object),argname,&value);
 
@@ -100,8 +105,9 @@ gst_util_get_long_arg (GObject *object, const gchar *argname)
 gfloat
 gst_util_get_float_arg (GObject *object, const gchar *argname) 
 {
-  GValue value = {0, };
+  GValue value;
 
+  ZERO (value);
   g_value_init (&value, G_TYPE_FLOAT);
   g_object_get_property(G_OBJECT(object),argname,&value);
 
@@ -120,8 +126,9 @@ gst_util_get_float_arg (GObject *object, const gchar *argname)
 gdouble 
 gst_util_get_double_arg (GObject *object, const gchar *argname) 
 {
-  GValue value = {0, };
+  GValue value;
 
+  ZERO (value);
   g_value_init (&value, G_TYPE_DOUBLE);
   g_object_get_property(G_OBJECT(object),argname,&value);
 
@@ -140,12 +147,13 @@ gst_util_get_double_arg (GObject *object, const gchar *argname)
  const gchar*
 gst_util_get_string_arg (GObject *object, const gchar *argname) 
 {
-  GValue value = {0, };
+  GValue value;
 
+  ZERO (value);
   g_value_init (&value, G_TYPE_STRING);
   g_object_get_property(G_OBJECT(object),argname,&value);
 
-  return g_value_get_string(&value);
+  return g_value_get_string(&value);  // memleak?
 }
 
 /**
@@ -160,8 +168,9 @@ gst_util_get_string_arg (GObject *object, const gchar *argname)
 gpointer
 gst_util_get_pointer_arg (GObject *object, const gchar *argname) 
 {
-  GValue value = {0, };
+  GValue value;
 
+  ZERO (value);
   g_value_init (&value, G_TYPE_POINTER);
   g_object_get_property(G_OBJECT(object),argname,&value);
 
diff --git a/gst/gstxml.c b/gst/gstxml.c
index 54d311c2a7..5d29e212b7 100644
--- a/gst/gstxml.c
+++ b/gst/gstxml.c
@@ -54,6 +54,7 @@ gst_xml_get_type(void)
       sizeof(GstXML),
       0,
       (GInstanceInitFunc)gst_xml_init,
+      NULL
     };
     xml_type = g_type_register_static (GST_TYPE_OBJECT, "GstXml", &xml_info, 0);
   }
diff --git a/plugins/elements/gstqueue.c b/plugins/elements/gstqueue.c
index fdf8bfec54..08cc5f8a60 100644
--- a/plugins/elements/gstqueue.c
+++ b/plugins/elements/gstqueue.c
@@ -121,6 +121,7 @@ gst_queue_get_type(void)
       sizeof(GstQueue),
       4,
       (GInstanceInitFunc)gst_queue_init,
+      NULL
     };
     queue_type = g_type_register_static (GST_TYPE_ELEMENT, "GstQueue", &queue_info, 0);
   }