diff options
| author | Matthew Waters <matthew@centricular.com> | 2020-12-09 20:20:18 +1100 |
|---|---|---|
| committer | GStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org> | 2021-01-04 12:10:12 +0000 |
| commit | db15ec92864a2987bb278d48f15338dccf7f9cc4 (patch) | |
| tree | fb7538c21d5058dfbbf3789db3b96e42ef226e70 /docs | |
| parent | 35018d67ef1c0e3641b457e5a4b74c2d6c26c998 (diff) | |
| download | gstreamer-plugins-good-db15ec92864a2987bb278d48f15338dccf7f9cc4.tar.gz | |
videoflip: fix possible crash when setting the video-direction while running
A classic case of not enough locking.
One interesting thing with this is the interaction between the
rotation value and caps negotiation. i.e. the width/height of the caps
can be swapped depending on the video-direction property. We can't lock
the entirety of the caps negotiation for obvious reasons so we need to
do something else. This takes the approach of trying to use a single
rotation value throughout the entirety of the negotiation and then
subsequent output frame in a kind of latching sequence.
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/792
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/836>
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/gst_plugins_cache.json | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/gst_plugins_cache.json b/docs/gst_plugins_cache.json index 11d55b950..f3387e6b1 100644 --- a/docs/gst_plugins_cache.json +++ b/docs/gst_plugins_cache.json @@ -24926,7 +24926,7 @@ "construct-only": false, "controllable": true, "default": "none (0)", - "mutable": "null", + "mutable": "playing", "readable": true, "type": "GstVideoFlipMethod", "writable": true |