summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSebastian Dröge <sebastian@centricular.com>2016-03-13 10:33:13 +0200
committerSebastian Dröge <sebastian@centricular.com>2016-03-15 09:39:55 +0200
commitc51c2c8cbba24c942a3ed4b7fe6eecad97f70e34 (patch)
treefd50245f41247e3c84fd53a4d53815ad38978ed0
parent2da8df0895dba8f84e5caac52c15e65fde4ac4cf (diff)
downloadgstreamer-plugins-good-c51c2c8cbba24c942a3ed4b7fe6eecad97f70e34.tar.gz
Revert "flacparse: push tags in pre_push_frame"
This reverts commit 4065fcb80a49924b70f0c8fc159dec0ff47943a1. flacparse should not push tags by itself, the base class is going to do that while properly merging in upstream tags. It just didn't because of a bug in the base class, which was hidden by this commit. https://bugzilla.gnome.org/show_bug.cgi?id=763553
-rw-r--r--gst/audioparsers/gstflacparse.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/gst/audioparsers/gstflacparse.c b/gst/audioparsers/gstflacparse.c
index 41f50368a..bf598c7a2 100644
--- a/gst/audioparsers/gstflacparse.c
+++ b/gst/audioparsers/gstflacparse.c
@@ -1719,12 +1719,6 @@ gst_flac_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
flacparse->sent_codec_tag = TRUE;
}
- /* Push tags */
- if (flacparse->tags) {
- gst_pad_push_event (GST_BASE_PARSE_SRC_PAD (flacparse),
- gst_event_new_tag (flacparse->tags));
- flacparse->tags = NULL;
- }
/* Push toc */
if (flacparse->toc) {
gst_pad_push_event (GST_BASE_PARSE_SRC_PAD (flacparse),