diff options
| author | Jordan Petridis <jpetridis@gnome.org> | 2020-06-11 20:39:33 +0300 |
|---|---|---|
| committer | GStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org> | 2020-09-25 09:59:25 +0000 |
| commit | 50233ce6f11b5d8e7e289ce49b64e66698920142 (patch) | |
| tree | 5252d3e45a6f8d211928fcd100e3e9401f50783b | |
| parent | 275bbc64f81ebc7036a0e89d1a3f3c6687c2d821 (diff) | |
| download | gstreamer-plugins-good-50233ce6f11b5d8e7e289ce49b64e66698920142.tar.gz | |
Use gst_element_class_set_metadata when passing dynamic strings
gst_element_class_set_metadata is meant to only be used with
static or inlined strings, which isn't the case for the 2 elements
here resulting in use-after-free later on.
https://gstreamer.freedesktop.org/documentation/gstreamer/gstelement.html?gi-language=c#gst_element_class_set_static_metadata
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/746>
| -rw-r--r-- | gst/isomp4/gstqtmux.c | 2 | ||||
| -rw-r--r-- | sys/v4l2/gstv4l2videodec.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/gst/isomp4/gstqtmux.c b/gst/isomp4/gstqtmux.c index dcc28662c..8a4539c9e 100644 --- a/gst/isomp4/gstqtmux.c +++ b/gst/isomp4/gstqtmux.c @@ -476,7 +476,7 @@ gst_qt_mux_base_init (gpointer g_class) longname = g_strdup_printf ("%s Muxer", params->prop->long_name); description = g_strdup_printf ("Multiplex audio and video into a %s file", params->prop->long_name); - gst_element_class_set_static_metadata (element_class, longname, + gst_element_class_set_metadata (element_class, longname, "Codec/Muxer", description, "Thiago Sousa Santos <thiagoss@embedded.ufcg.edu.br>"); g_free (longname); diff --git a/sys/v4l2/gstv4l2videodec.c b/sys/v4l2/gstv4l2videodec.c index 39f845cd3..a25bf1bb8 100644 --- a/sys/v4l2/gstv4l2videodec.c +++ b/sys/v4l2/gstv4l2videodec.c @@ -1036,7 +1036,7 @@ gst_v4l2_video_dec_subclass_init (gpointer g_class, gpointer data) gst_pad_template_new ("src", GST_PAD_SRC, GST_PAD_ALWAYS, cdata->src_caps)); - gst_element_class_set_static_metadata (element_class, cdata->longname, + gst_element_class_set_metadata (element_class, cdata->longname, "Codec/Decoder/Video/Hardware", cdata->description, "Nicolas Dufresne <nicolas.dufresne@collabora.com>"); |