diff options
| author | Olivier Crête <olivier.crete@collabora.com> | 2018-12-13 19:16:11 -0500 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2019-05-06 23:43:07 +0200 |
| commit | aa77700b75a2828339941fe29c8e8f9855226519 (patch) | |
| tree | 12fae975fc5e312c26aecc588963aca038d96344 | |
| parent | 22ab861dd1a15f0035d30d2ee4a895713b4c186a (diff) | |
| download | gstreamer-plugins-good-aa77700b75a2828339941fe29c8e8f9855226519.tar.gz | |
rtpjitterbuffer test: Stop jitterbuffer before pads to avoid race
The teardown of the pads checks the refcount, but there are timers
inside the jitterbuffer that can push things, so if we're not lucky,
things could be pushed while the pads are being shut down. Putting the
jitterbuffer to NULL first avoids this.
| -rw-r--r-- | tests/check/elements/rtpjitterbuffer.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/check/elements/rtpjitterbuffer.c b/tests/check/elements/rtpjitterbuffer.c index 5c13a0c6a..80da5b5d9 100644 --- a/tests/check/elements/rtpjitterbuffer.c +++ b/tests/check/elements/rtpjitterbuffer.c @@ -168,6 +168,7 @@ cleanup_jitterbuffer (GstElement * jitterbuffer) gst_pad_set_active (mysrcpad, FALSE); gst_pad_set_active (mysinkpad, FALSE); + gst_element_set_state (jitterbuffer, GST_STATE_NULL); gst_check_teardown_src_pad (jitterbuffer); gst_check_teardown_sink_pad (jitterbuffer); gst_check_teardown_element (jitterbuffer); |