xoverlay: change new set_render_rectangle() vfunc to take four arguments so we don't depend on libgstvideo

Don't make libgstinterfaces (and thus libgstaudio etc.) indirectly depend
on libgstvideo by using the GstVideoRectangle helper structure in the API,
which causes undesirable dependencies, esp. with the gobject-introspection
(people will point and laugh at us if they find out that libgstaudio
depends on libgstvideo). Instead, pass the x, y, width and height parameters
directly to the function.

Re-fixes #610249.

1 files changed, 10 insertions, 5 deletions

diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c
index 85841074d..6b0383ce7 100644
--- a/sys/xvimage/xvimagesink.c
+++ b/sys/xvimage/xvimagesink.c
@@ -2858,16 +2858,21 @@ gst_xvimagesink_set_event_handling (GstXOverlay * overlay,
 }
 
 static void
-gst_xvimagesink_set_render_rectangle (GstXOverlay * overlay,
-    GstVideoRectangle * rect)
+gst_xvimagesink_set_render_rectangle (GstXOverlay * overlay, gint x, gint y,
+    gint width, gint height)
 {
   GstXvImageSink *xvimagesink = GST_XVIMAGESINK (overlay);
 
-  if (rect) {
-    memcpy (&xvimagesink->render_rect, rect, sizeof (GstVideoRectangle));
+  /* FIXME: how about some locking? */
+  if (x >= 0 && y >= 0 && width >= 0 && height >= 0) {
+    xvimagesink->render_rect.x = x;
+    xvimagesink->render_rect.y = y;
+    xvimagesink->render_rect.w = width;
+    xvimagesink->render_rect.h = height;
     xvimagesink->have_render_rect = TRUE;
   } else {
-    xvimagesink->render_rect.x = xvimagesink->render_rect.y = 0;
+    xvimagesink->render_rect.x = 0;
+    xvimagesink->render_rect.y = 0;
     xvimagesink->render_rect.w = xvimagesink->xwindow->width;
     xvimagesink->render_rect.h = xvimagesink->xwindow->height;
     xvimagesink->have_render_rect = FALSE;