diff options
| author | Nicola Murino <nicola.murino@gmail.com> | 2014-09-04 12:13:45 +0200 |
|---|---|---|
| committer | Sebastian Dröge <sebastian@centricular.com> | 2014-09-04 14:13:55 +0300 |
| commit | 501a295fa12436ffd2f1abc7105b007ecc9f950a (patch) | |
| tree | d42dbcf4ec9c1bb5e23d2544c254232384f23a8f | |
| parent | ad16f15ee420ed32cf436efc309b2ae08d78fa2f (diff) | |
| download | gstreamer-plugins-base-501a295fa12436ffd2f1abc7105b007ecc9f950a.tar.gz | |
basetextoverlay: remove unneeded cairo transparence setting
he code here:
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/pango/gstbasetextoverlay.c#n1554
should make transparent the box that contains the text, I think this code is
not correct, it should be:
if (overlay->want_shading) {
double alpha = overlay->shading_value / 255.0;
cairo_paint_with_alpha (cr, alpha);
}
however I think this code could be removed, we already do a shaded background,
why shade the box behind the text with cairo too? only one shading is needed so
we must shade with cairo or with methods like these:
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/pango/gstbasetextoverlay.c#n1642
not both
https://bugzilla.gnome.org/show_bug.cgi?id=736028
| -rw-r--r-- | ext/pango/gstbasetextoverlay.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/ext/pango/gstbasetextoverlay.c b/ext/pango/gstbasetextoverlay.c index 0f8ddb17e..5e4b270c7 100644 --- a/ext/pango/gstbasetextoverlay.c +++ b/ext/pango/gstbasetextoverlay.c @@ -1559,9 +1559,6 @@ gst_base_text_overlay_render_pangocairo (GstBaseTextOverlay * overlay, cairo_set_operator (cr, CAIRO_OPERATOR_OVER); - if (overlay->want_shading) - cairo_paint_with_alpha (cr, -overlay->shading_value); - /* apply transformations */ cairo_set_matrix (cr, &cairo_matrix); |