convertframe: Error out directly if changing the pipeline state to PLAYING failed

1 files changed, 17 insertions, 1 deletions

diff --git a/gst-libs/gst/video/convertframe.c b/gst-libs/gst/video/convertframe.c
index ce6845117..b3aab9a42 100644
--- a/gst-libs/gst/video/convertframe.c
+++ b/gst-libs/gst/video/convertframe.c
@@ -763,7 +763,9 @@ gst_video_convert_sample_async (GstSample * sample,
   g_source_unref (source);
   gst_object_unref (bus);
 
-  gst_element_set_state (pipeline, GST_STATE_PLAYING);
+  if (gst_element_set_state (pipeline,
+          GST_STATE_PLAYING) == GST_STATE_CHANGE_FAILURE)
+    goto state_change_failed;
 
   gst_caps_unref (to_caps_copy);
 
@@ -782,4 +784,18 @@ no_pipeline:
 
     return;
   }
+state_change_failed:
+  {
+    gst_caps_unref (to_caps_copy);
+
+    error = g_error_new (GST_CORE_ERROR, GST_CORE_ERROR_STATE_CHANGE,
+        "failed to change state to PLAYING");
+
+    g_mutex_lock (&ctx->mutex);
+    convert_frame_finish (ctx, NULL, error);
+    g_mutex_unlock (&ctx->mutex);
+    gst_video_convert_frame_context_unref (ctx);
+
+    return;
+  }
 }