| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
The parser handles the downstream force-key-unit event incorrectly,
it tries to parse it as an upstream force-key-unit event, does not
check the return value, and then uses uninitialized memory in
"all_headers" boolean variable.
https://bugzilla.gnome.org/show_bug.cgi?id=763793
|
|
|
|
|
|
|
|
|
| |
bytestream
Create temporary ParseFrame and copy the nal size buffer region
for each nal unit like we did for h264.
https://bugzilla.gnome.org/show_bug.cgi?id=763494
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a regression from since mpegvideoparser was switched to
use the codecparsing library.
The problem is that the high bit of the profile_and_level is used
to specify non-hierarchical profiles and levels. Unfortunately we
were discarding that information.
Expose that escape bit, and use it in the element
https://bugzilla.gnome.org/show_bug.cgi?id=763220
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enabling passthorugh mode is causing multiple issue:
For nal aligned multiresoluton streams, passthrough mode
make h264parse unable to advertise the new resoultions.
Also causing issues while parsing MVC streams which have two
separate layers (base-view and non-base-view).
This fix is only a temporary workaround.
For MVC, proper fixes needed in many places:
(handle prefix nal unit, handle non-base-view slice nal extension,
fix the picture_start detection for multi-layer-mvc streams etc)
https://bugzilla.gnome.org/show_bug.cgi?id=758656
|
|
|
|
|
|
|
| |
Since commit b77f8e172a3f0be6be5cb4a72e654253404e694f the new value
assigned to mview_mode hasn't been used. That commit changed the following
"if" check to an "else if", which means the original value of mview_mode
is used.
|
|
|
|
|
|
|
|
|
|
| |
h265 versions of the following commits:
f352691a04896d0de3381fe8ee85ada948bd6337
try the current caps before querying downstream
72bc7d7f736a10117fedb8e1d4013a4946cfefbc
increase caps equality check for no codec_data
https://bugzilla.gnome.org/show_bug.cgi?id=761014
|
|
|
|
|
|
|
|
| |
When converting from avc to byte-stream, there will not be any codec_data
in the src caps. Remove it before the equality check to avoid sending caps
events downstream on every SPS/PPS change.
https://bugzilla.gnome.org/show_bug.cgi?id=761014
|
|
|
|
|
|
|
|
| |
If we have a stream that contains an unchanging SPS/PPS for every video frame,
we don't need to to constantly query downstream for it's supported caps if the
current caps are compatible with the negotiated caps.
https://bugzilla.gnome.org/show_bug.cgi?id=761014
|
|
|
|
|
|
|
| |
When sps data is NULL, the buffer allocated and mapped is not being freed.
In this scenario there is no need to allocate the buffer as we are supposed to return NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=761070
|
|
|
|
|
|
|
| |
While setting caps, codec_data buffer is mapped, but not being unmapped
leading to memory leaks.
https://bugzilla.gnome.org/show_bug.cgi?id=761070
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=759503
|
|
|
|
|
|
|
|
| |
rename gst-launch --> gst-launch-1.0
replace old elements with new elements(ffmpegcolorspace -> videoconvert, ffenc_** -> avenc_**)
fix caps in examples
https://bugzilla.gnome.org/show_bug.cgi?id=759432
|
|
|
|
|
|
|
|
| |
This is to support byte-stream decoder that does not remember the
PPS/SPS after a flush. This is not needed by all decoders, but is
harmless for those that do remember.
https://bugzilla.gnome.org/show_bug.cgi?id=758405
|
|
|
|
|
|
|
| |
Even though all cases inside VC1_STREAM_FORMAT_ASF are goto or
g_assert_not_reached(), add a break at the end to appease Coverity.
CID #1320706
|
|
|
|
|
|
|
|
|
|
| |
As it's recursive, gst_pad_get_allowed_caps() may also return
empty for anything incompatible downstream. EMPTY is not valid caps
value for gst_caps_fixate(). This lead to assertion and then crash.
Ideally, the negotiate function should be re-factored to have a return
value, and we could make the negotiation fails earlier.
https://bugzilla.gnome.org/show_bug.cgi?id=754122
|
|
|
|
|
|
| |
Instead of squashing all upstream tags
https://bugzilla.gnome.org/show_bug.cgi?id=679768
|
|
|
|
|
|
|
|
|
|
|
| |
The SPS struct might be filled out by a call to
gst_h264_parser_parse_subset_sps, which fills out
dynamically allocated data and requires a call
to gst_h264_sps_clear() to free it. Also make sure
to clear out any allocated SPS data when returning
an error.
https://bugzilla.gnome.org/show_bug.cgi?id=753306
|
|
|
|
|
|
|
| |
Do a quick check with the pad template caps as it is enough. Users
should have figured the appropriate full caps on a previous caps query
https://bugzilla.gnome.org/show_bug.cgi?id=753623
|
|
|
|
|
|
|
| |
Do a quick check with the pad template caps as it is enough. Users
should have figured the appropriate full caps on a previous caps query
https://bugzilla.gnome.org/show_bug.cgi?id=753623
|
|
|
|
|
|
|
| |
Check slice headers in between GST_H265_NAL_SLICE_TRAIL_N
and GST_H265_NAL_SLICE_RASL_R for frame start detection.
https://bugzilla.gnome.org/show_bug.cgi?id=753497
|
|
|
|
|
|
|
| |
EndOfSequence and EndOfBitstream nal units have size of 2 bytes.
Don't consider them as broken nals.
https://bugzilla.gnome.org/show_bug.cgi?id=753497
|
|
|
|
|
|
|
|
|
| |
Some video bitstreams report a too restrictive set of profiles. If a video
decoder was to strictly follow the indicated profile, it wouldn't support that
stream, whereas it could in theory and in practice. So we should relax the
profile restriction for allowing the decoder to get connected with parser.
https://bugzilla.gnome.org/show_bug.cgi?id=747613
|
|
|
|
|
|
|
|
| |
VPS is not mandatory, and need not check for its presence before setting
the caps. Because of the check, in streams which don't have VPS,
sticky event mishandling happens.
https://bugzilla.gnome.org/show_bug.cgi?id=752807
|
|
|
|
|
|
| |
Register more NAL unit types so that they are dumped
by name in the debug output instead of being labelled
'Invalid'
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=752991
|
|
|
|
|
|
|
|
|
|
| |
Don't throw away AU delimiter(s) that precede the SPS/PPS. Should
fix MPEG-TS playback on iOS/Quicktime when muxing streams that
already have AU delimiters.
See https://bugzilla.gnome.org/show_bug.cgi?id=736213 for getting
h264parse to insert AU delimiters when they don't already
exist.
|
|
|
|
| |
https://bugzilla.gnome.org//show_bug.cgi?id=752127
|
| |
|
|
|
|
|
|
|
| |
Move the pixel-aspect-ratio calculations higher up in caps
determination, so the results are available for a call to
gst_video_multiview_guess_half_aspect() when stereoscopic video
is detected.
|
|
|
|
| |
Pass any multiview info from the container or SEI info downstream
|
|
|
|
|
|
|
| |
Wait until at least one keyframe has been parsed before
deciding to switch to passthrough mode, in case the
stream contains SEI messages that supplement the output
caps - for example by providing stereoscopic information
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were off by one byte in the matching
It should be (using 24 bit matching):
* startcode : 0000 0000 0000 0000 1000 00xx
* mask (bin) : 1111 1111 1111 1111 1111 1100
* mask (hex) : f f f f f c
* match : 0 0 0 0 8 0
https://bugzilla.gnome.org/show_bug.cgi?id=750685
|
|
|
|
| |
In all these cases ret is set but overwritten before the return of the function
|
|
|
|
|
|
|
|
| |
Like SPS/PPS they do contain information which will be needed to
decode the following data (as per definition of the flag)
Also ensures that the series of SPS/PPS/SEI NALU before a keyframe
can be considered as one contiguous header
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the H263 spec, CPFMT is present only if the use of a custom
picture format is signalled in PLUSEPTYPE and UFEP is "001",
so we need to check params->format and only if the value is
6 (custom source format) the CPFMT should be read, otherwise
it's not present and wrong data will be parsed.
When reading the CPFMT, the width and height were not
calculated correctly (wrong bitmask).
https://bugzilla.gnome.org//show_bug.cgi?id=749253
|
|
|
|
| |
Update old references for decodebin2 to decodebin.
|
|
|
|
|
|
|
|
| |
Don't use the apis in codec-utils to extract the profile and level
syntax elements since it is wrong if there are emulation prevention
bytes existing in the byte-stream data.
https://bugzilla.gnome.org/show_bug.cgi?id=747613
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=747613
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=747613
|
|
|
|
|
|
|
|
| |
Don't use the apis in codec-utils to extract the profile,tier and level
syntax elements since it is wrong if there are emulation prevention
bytes existing in the byte-stream data.
https://bugzilla.gnome.org/show_bug.cgi?id=747613
|
|
|
|
| |
This is not needed any longer.
|
|
|
|
|
| |
This were probably added to the enums due to cargo cult programming and are
unused.
|
|
|
|
|
|
|
|
| |
The detection for missing format/alignment is done way before this
codepath is reached (at which point we have already decided of a
format and alignment).
CID #1232800
|
| |
|
|
|
|
|
|
| |
Value set in off will be immediately overwritten after going to next.
CID #1226476
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=745755
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents it from going into passthrough after receiving 2
byte-stream caps (different ones) as it would keep the have_pps and
have_sps set to true and would just go into passthrough without
updating its caps.
This patch makes it reset its stream information to restart properly
when new caps are received.
https://bugzilla.gnome.org/show_bug.cgi?id=745409
|
|
|
|
|
|
|
| |
Exposing stereo-high profile as a compatible profile of multiview-high
if the maximum number of encoded views in the stream is two.
https://bugzilla.gnome.org/show_bug.cgi?id=743174
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch calls gst_h264_parser_parse_subset_sps() when a
SPS subset NAL type is found.
All the bits required for parsing the SPS subset in NALs were
already there, just we need to call them when the this NAL type
is found.
With this parsing, the number of views (minus 1) attribute is
filled, which was a requirement for negotiating the stereo-high
profile.
https://bugzilla.gnome.org/show_bug.cgi?id=743174
|
|
|
|
|
|
|
|
|
|
| |
Initial support for MVC NAL units. It is only needed to propagate the
complete set of NAL units downstream at this time.
https://bugzilla.gnome.org/show_bug.cgi?id=696135
Signed-off-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
|