diff options
| author | Alain Magloire <alainm@rcsm.ee.mcgill.ca> | 2001-07-29 19:32:15 +0000 |
|---|---|---|
| committer | Alain Magloire <alainm@rcsm.ee.mcgill.ca> | 2001-07-29 19:32:15 +0000 |
| commit | 418c7f7900a794eb647c9cb69d496757f9723fca (patch) | |
| tree | af99702b9c07bdb8e39b47d25dc81d0c5f40edad /bootstrap | |
| parent | f81b20eb931851b5cac82cbf4fe7abea0a2c7ec1 (diff) | |
| download | grep-418c7f7900a794eb647c9cb69d496757f9723fca.tar.gz | |
* grep/src/grep.c (usage): Typos corrected.
Patches from Santiago Vila.
2001-07-29 Alain Magloire
David Clissold, wrote:
a small bug in the GNU grep 2.4.2, which may have gone unnoticed
because it only causes a failure if building on a system with large
files enabled (e.g. an "off_t" is a "long long" rather than a "long").
savedir() takes on off_t argument, but in grepdir() the parameter
is cast to an (unsigned). Well, if an off_t is larger than an int,
the value gets truncated. This would not normally have an effect on a
little-endian platform (unless the file is >2GB), but on a big-endian
system it will always fail. The external effect is that
"grep -r foo dir_name" fails with ENOMEM (from malloc() within
savedir()).
* grep/src/grep.c (grepdir): Remove the (unsigned) cast when calling
savedir().
* grep/src/grep.c (usage): Typos corrected.
Patches from Santiago Vila.
David Clissold, wrote:
a small bug in the GNU grep 2.4.2, which may have gone unnoticed
because it only causes a failure if building on a system with large
files enabled (e.g. an "off_t" is a "long long" rather than a "long").
savedir() takes on off_t argument, but in grepdir() the parameter
is cast to an (unsigned). Well, if an off_t is larger than an int,
the value gets truncated. This would not normally have an effect on a
little-endian platform (unless the file is >2GB), but on a big-endian
system it will always fail. The external effect is that
"grep -r foo dir_name" fails with ENOMEM (from malloc() within
savedir()).
* grep/src/grep.c (grepdir): Remove the (unsigned) cast when calling
savedir().
* grep/doc/grep.texi: In Bugs report use {n,m} for consistency.
* grep/doc/grep.1: Likewised.
Noted by Steven Lucy.
Diffstat (limited to 'bootstrap')
| -rw-r--r-- | bootstrap/Makefile.try | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bootstrap/Makefile.try b/bootstrap/Makefile.try index 50fa51be..f1d1acab 100644 --- a/bootstrap/Makefile.try +++ b/bootstrap/Makefile.try @@ -32,9 +32,9 @@ LIB_OBJS_core = \ #LIB_OBJ_atexit = $(libdir)/atexit.$(OBJEXT) #LIB_OBJ_alloca = $(libdir)/alloca.$(OBJEXT) #LIB_OBJ_fnmatch = $(libdir)/fnmatch.$(OBJEXT) -#LIB_OBJ_getopt = $(libdir)/getopt.$(OBJEXT) $(libdir)/getopt1.$(OBJEXT) +LIB_OBJ_getopt = $(libdir)/getopt.$(OBJEXT) $(libdir)/getopt1.$(OBJEXT) #LIB_OBJ_memchr = $(libdir)/memchr.$(OBJEXT) -#LIB_OBJ_obstack = $(libdir)/obstack.$(OBJEXT) +LIB_OBJ_obstack = $(libdir)/obstack.$(OBJEXT) #LIB_OBJ_strtoul = $(libdir)/strtoul.$(OBJEXT) LIB_OBJ_stpcpy = $(libdir)/stpcpy.$(OBJEXT) LIB_OBJ_strtoull = $(libdir)/strtoull.$(OBJEXT) |