summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* PowerPC: stacktrace function refactor and fixesat7_1-releaseAdhemerval Zanella2014-04-073-27/+244
| | | | | | | | | | This patch fixes the stacktrace creating when the function is interrupted by a signal. For Linux, the vDSO signal trampoline symbol is compared against LR from stack backchain and handled different in that case (since the signal trampoline layout a different stack frame). Because of this extensive change the PowerPC stacktrace code has now been refactored to split in Linux and Darwin specific codes.
* VDSOsupport cleanupAdhemerval Zanella2014-04-072-69/+0
| | | | | | This patch cleans up unused VDSO getcpu racking from VDSOsupport class, since the code is not used anywhere in gperftools and symbol name is not architecture independent.
* Fixed heap checker test.Raphael Moreira Zinsly2014-04-071-2/+1
| | | | | | | This patch changes the way that heap checker test identifies the architecture's endianness. The test was using _Call_Elf to know if the machine is Big Endian, but the _Call_Elf not always is defined in ppc64 BE and always is defined in LE machines.
* Fixed issues with heap checker on PPC64 LE.Raphael Moreira Zinsly2014-04-072-5/+22
| | | | | | Fixed the wrapper for the syscall sys_clone and the test for heap checker on PPC64 LE. Both use the ODP structure, which is only used on BE architectures.
* Fixed the way that pprof packed profile data in BE.Raphael Moreira Zinsly2014-04-071-5/+21
| | | | | | pprof was writing profile data in a way that only works for little-endian files, this patch verifies if the system is big-endian and writes packed data correctly.
* Fixed the use of addr2line to discover the separator symbol.Raphael Moreira Zinsly2014-04-071-1/+33
| | | | | | | | In systems where addr2line has a version greater than 2.22 pprof fails in discover the separator symbol (_fini). This patch identifies if addr2line can find the symbol, otherwise pprof uses objdump to recover a address that addr2line's newer versions can recognize as the separator function.
* Fix page_heap testcase for 64K pagesAdhemerval Zanella2014-04-071-3/+3
| | | | | This patch fixes the page_heap testcase 32-bit build when TCMALLOC_LARGE_PAGES64K is defined.
* RSS usage tuning for 64K pagesAdhemerval Zanella2014-04-071-0/+10
| | | | | This patch lowers TCMalloc RSS usage when TCMALLOC_LARGE_PAGES64K is defined by tuning page scavenge values.
* Update README with PowerPC specifics notesAdhemerval Zanella2014-04-071-0/+20
|
* speed up MallocExtension::instance()Aliaksey Kandratsenka2014-03-291-4/+9
| | | | | | | | | | | | | | | | | | | It was reported that pthread_once is expensive, especially on ppc. In new implementation in hot path instead of doing potentially expensive atomic read with barrier, we do just plain read. It's slightly less robust than older implementation, but it should be faster. New code is making assumption that programs do not spawn threads before main() is called. And therefore all variables & modules are initialized before threads are created. Which looks like pretty safe assumption. With that assumption, doing plain read is safe, because current_instance is initialized as part of module init and therefore before threads are spawned. This patch is based on feedback of Adhemerval Zanella.
* Fix getpc_test for PPC64v2 LEAdhemerval Zanella2014-03-291-2/+4
| | | | | | This patch fix the PPC64 guard to get the function address for PPC64v2. It removes the use of an indirection (to get the ODP text address), since the PPCv2 does not have function descriptors.
* issue-613: remove friend declaration from HeapLeakCheckerAliaksey Kandratsenka2014-03-291-3/+0
| | | | | | | | | | | | | | | | | | | This applies patch by davide.italiano@10gen.com: heap-checker.h contains the following friend declaration of main: friend int main(int, char**). C99 allows another declaration of main, i.e. int main(int, char**, char**), and if code uses it and includes the heap-checker header, this might result in a conflict, e.g. error: declaration of C function 'int main(int, char**, char**)' conflicts with int main(int argc, char* argv[], char** envp) Actually the comment above the friend declaration of main() mentions that this is required to get the unittest working and for other internal usage, but I'm not completely sure if this is true as long as I'm able to build and run the unittest removing the declaration.
* issue-612: added missing include for std::minAliaksey Kandratsenka2014-03-291-0/+1
| | | | Otherwise Visual Studio 2013 rightfully complains
* unbreak building with libunwindAliaksey Kandratsenka2014-03-011-2/+2
| | | | | | | | | | Caused by premature merging of previous patch. When we're searching for backtrace in libexecinfo and don't find it, we should not reset UNWIND_LIBS to empty value. Correct fix is to first search for backtrace in libunwind and then to search for it in libexecinfo.
* Look for backtrace() in libexecinfo as well.Thomas Klausner2014-03-011-1/+2
| | | | Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
* Fix unportable test(1) construct.Thomas Klausner2014-03-011-1/+1
| | | | Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
* Test for memalign in configure.ac. Disable a test that uses memalign if it ↵Thomas Klausner2014-03-012-0/+3
| | | | | | is not found. Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
* issue-489: added tcmalloc test pass with chromium-style decommitAliaksey Kandratsenka2014-02-221-5/+13
|
* issue-489: added unit test for chromium-style decommittingAliaksey Kandratsenka2014-02-221-5/+51
|
* issue-489: made tests pass on enabled chromium-style decommittingAliaksey Kandratsenka2014-02-221-0/+19
|
* issue-489: enable chromium-style decommitting on env variableAliaksey Kandratsenka2014-02-221-11/+19
| | | | | TCMALLOC_AGGRESSIVE_DECOMMIT=t now enables aggressive decommitting by default.
* issue-489: implemented API to set chromium-style de-committingAliaksey Kandratsenka2014-02-223-5/+72
| | | | | | | | | Chrome has code to decommit (release back to OS) every span that's released. I don't want to make it default, but indeed some applications may want to enable this mode. The code itself is taken from 2-way-merging of code from Chromium fork.
* issue-489: fixed warningAliaksey Kandratsenka2014-02-221-0/+2
| | | | | Computing certain values just for ASSERT raises just warning from compiler because if NDEBUG is set those are dead code.
* issue-489: ported chromium windows decommitting codeAliaksey Kandratsenka2014-02-225-20/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I tried to do it cleanly with merges but chromium code has so many relevant commits (with frequent reverts) that makes it near impossible. Simpler 2-way emerge-files worked in the end. I've removed chromium's aggressive 'always decommit' behavior which I want to make optional later. Majority of this work is the following commits (but there are more, particularly against port.cc): commit 9c92338c5f8770c440799d24387c3733fd6d826b Author: jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Tue Oct 6 18:33:31 2009 +0000 Tracks the amount of committed vs uncommitted memory in tcmalloc's page heap's freelists Keeps track of the number of reserved but not committed pages in the freelist and uses that to calculate a waste metric, which is the ratio of committed pages vs pages used by the application. This is exposed in the GetStats() call (which is used for about:tcmalloc) and through GetNumericalProperty() in Malloc BUG=none TEST=open about:tcmalloc and monitor 'WASTE' columns while using the browser Review URL: http://codereview.chromium.org/251065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28133 0039d316-1c4b-4281-b951-d872f2087c98 commit aef4f1be3eec2059a7c6e2c106050a5f3d6ccf12 Author: jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Mon Oct 5 17:58:51 2009 +0000 Revert further back to MBelshe's baseline forking TCMalloc This changes to decommitting in all paths through the page_heap delete method (which adds spans to the free lists). r=mbelshe,jamesr Review URL: http://codereview.chromium.org/255067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28006 0039d316-1c4b-4281-b951-d872f2087c98 commit e94afbb913b95f512cb8745a2729c73f82b15ae7 Author: jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Thu Oct 1 00:25:41 2009 +0000 Rollback Scavenge implemetation and rely on existing functionality to free This is a landing of a patch provided by antonm. See: http://codereview.chromium.org/235022 Also included change to browser_about_handler.cc to fix build, and I set TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this was an inadvertent rollback element). r=antonm Review URL: http://codereview.chromium.org/257009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98 commit c585892d2c42a47c95d06a684a6685156c545403 Author: mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> Date: Wed Sep 2 17:33:23 2009 +0000 Landing for Anton Muhin's tcmalloc patch: http://codereview.chromium.org/180021/show Restore decommitting in IncrementalScavenge and draft Scavenge method to be invoked periodically to reduce amount of committed pages. BUG=none TEST=none Review URL: http://codereview.chromium.org/187008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25188 0039d316-1c4b-4281-b951-d872f2087c98 commit 14239acc00731e94736ac62e80fc6b17c31ea131 Author: mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> Date: Wed Aug 12 02:17:14 2009 +0000 Major changes to the Chrome allocator. Changes include: * Fix tcmalloc to release memory. Implements the TCMalloc_SystemCommit() mechanism so that tcmalloc can implement SystemRelease() and later reuse that memory. * Enable dynamic switching of allocators based on an environment variable. Users can now switch between tcmalloc, jemalloc, the default windows heap, and the windows low-fragmentation heap. * Implements set_new_mode() across all allocators so that we can be sure that out-of-memory conditions are handled safely. BUG=18345 TEST=none; plan to get all unit tests running through these allocators. Review URL: http://codereview.chromium.org/165275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23140 0039d316-1c4b-4281-b951-d872f2087c98
* issue-525: only warn if --enable-frame-pointers are not givenAliaksey Kandratsenka2014-02-221-1/+1
| | | | | This fixes issue when frame pointers warning is given even if frame pointers are enabled
* added debugallocation check for offset_ corruptionAliaksey Kandratsenka2014-02-221-8/+32
| | | | | | | | It was previously possible (although unlikely) for damaged offset_ field to lead FromRawPointer implementation into different MallocBlock. As is usual with any damage, it's best to catch errors at earliest possible time.
* avoid crash in DebugMallocImplementation::GetOwnershipAliaksey Kandratsenka2014-02-221-4/+29
| | | | | | | | | | | | It was possible that if GetOwnership is passed pointer to memory not owned by tcmalloc, it would crash. Or incorrectly return owned. I.e. due to indirection in FromRawPointer. New implementation prevents that, but introduces different bug instead. New implementation incorrectly returns "not owned" for memalign chunks with big alignment. But in can be argued that passing pointer returned from different memalign implementation did not work previously too.
* removed unused "using" in malloc_extension_test.ccAliaksey Kandratsenka2014-02-221-2/+0
|
* eliminated useless BASE_XXX defines in debugallocation.ccAliaksey Kandratsenka2014-02-221-26/+16
| | | | And closed TODO entry for that.
* issue-464: correctly handle realloc after memalign in debugallocAliaksey Kandratsenka2014-02-222-2/+31
| | | | | | | debug memalign is creating special header block to allow us to find real allocated block. And previous implementation of data copying wasn't taking that into account and was copying that "alignment header" into newly allocated block.
* Add aarch64 definesRiku Voipio2014-02-164-5/+8
| | | | | | | | | | | | | | | | | | | | | | | With atomic operations and system call support in place, enable with __aarch64__ defines Aarch64 support in other files around the google-perftools header files. After these, google-perftools testsuite (make check) results: 8 of 46 tests failed. FAIL: sampling_test.sh FAIL: heap-profiler_unittest.sh FAIL: heap-checker_unittest.sh FAIL: heap-checker-death_unittest.sh FAIL: sampling_debug_test.sh FAIL: heap-profiler_debug_unittest.sh FAIL: heap-checker_debug_unittest.sh FAIL: profiler_unittest.sh While it indicates that there is still work to do, This is still better than the result I get on ARMv7: 12 of 46 tests failed.
* linux_syscall_support.h: add aarch64 supportRiku Voipio2014-02-162-33/+204
| | | | | | | | | | | | | | | | | | | | Aarch64 support for linux_syscall_support.h. Since Aarch64 is a brand new architecture, none of the legacy system calls are neccesarily available. Thus some changes were neccesary affect other architectures as well: 1) use getdents64 where available and else getdents (for ppc64) 2) other legacy system calls, pipe, waitpid and open replaced by pipe2, wait4 and openat where available. 3) use fstatat if stat is not available. The aarch64 system call interface follows the Aarch64 calling convention (regs x0-x5 for arguments and x8 system call number - return in x0). Clone implementation is adapted from glibc. v2: step back in getdents removal due to ppc64
* issue-525: warn user on lack of libunwind but don't failAliaksey Kandratsenka2014-02-161-1/+9
| | | | | Because we now have access to other backtrace capturing method(s) at runtime.
* issue-604: implement runtime-selectable stacktrace capturingAliaksey Kandratsenka2014-02-1612-169/+346
| | | | | We're now building all supported stacktrace capturing methods. And there's now a way to select at runtime which method is used.
* issue-605: avoid compilation errors if pthread_key_t is pointerAliaksey Kandratsenka2014-02-161-3/+16
| | | | Which seems to be the case on later cygwin
* unbreak make distAliaksey Kandratsenka2014-02-161-0/+4
|
* debugallocation: fix bus error on mipsel-linux platform when enable ↵Wang YanQing2014-02-161-7/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use_malloc_page_fence Fix below "BUS ERROR" issue: a0 hold start address of memory block allocated by DebugAllocate in debugallocation.cc gdb) info registers zero at v0 v1 a0 a1 a2 a3 R0 00000000 10008700 772f62a0 00084d40 766dcfef 7fb5f420 00000000 004b4dd8 t0 t1 t2 t3 t4 t5 t6 t7 R8 7713c1a0 7712dbc0 ffffffff 777bc000 f0000000 00000001 00000000 00403d10 s0 s1 s2 s3 s4 s5 s6 s7 R16 7fb5ff1c 00401b9c 77050020 7fb5fb18 00000000 004cb008 004ca748 ffffffff t8 t9 k0 k1 gp sp s8 ra R24 0000002f 771adcd4 00000000 00000000 771f4140 7fb5f408 7fb5f430 771add6c sr lo hi bad cause pc 00008713 0000e9fe 00000334 766dcff7 00800010 771adcfc fsr fir 00000004 00000000 (gdb) disassemble Dump of assembler code for function _ZNSs4_Rep10_M_disposeERKSaIcE: 0x771adcd4 <+0>: lui gp,0x4 0x771adcd8 <+4>: addiu gp,gp,25708 0x771adcdc <+8>: addu gp,gp,t9 0x771adce0 <+12>: lw v0,-28696(gp) 0x771adce4 <+16>: beq a0,v0,0x771add38 <_ZNSs4_Rep10_M_disposeERKSaIcE+100> 0x771adce8 <+20>: nop 0x771adcec <+24>: lw v0,-30356(gp) 0x771adcf0 <+28>: beqzl v0,0x771add1c <_ZNSs4_Rep10_M_disposeERKSaIcE+72> 0x771adcf4 <+32>: lw v0,8(a0) 0x771adcf8 <+36>: sync => 0x771adcfc <+40>: ll v0,8(a0) 0x771add00 <+44>: addiu at,v0,-1 0x771add04 <+48>: sc at,8(a0) 0x771add08 <+52>: beqz at,0x771adcfc <_ZNSs4_Rep10_M_disposeERKSaIcE+40> 0x771add0c <+56>: nop 0x771add10 <+60>: sync 0x771add14 <+64>: b 0x771add24 <_ZNSs4_Rep10_M_disposeERKSaIcE+80> 0x771add18 <+68>: nop 0x771add1c <+72>: addiu v1,v0,-1 0x771add20 <+76>: sw v1,8(a0) 0x771add24 <+80>: bgtz v0,0x771add38 <_ZNSs4_Rep10_M_disposeERKSaIcE+100> 0x771add28 <+84>: nop 0x771add2c <+88>: lw t9,-27072(gp) 0x771add30 <+92>: jr t9 0x771add34 <+96>: nop 0x771add38 <+100>: jr ra 0x771add3c <+104>: nop End of assembler dump. ll instruction manual: Load Linked: Loads the destination register with the contents of the word that is at the memory location. This instruction implicity performs a SYNC operation; all loads and stores to shared memory fetched prior to the ll must access memory before the ll, and loads and stores to shared memory fetched subsequent to the ll must access memory after ll. Load Linked and Store Conditional can be use to automatically update memory locations. *This instruction is not valid in the mips1 architectures. The machine signals an address exception when the effective address is not divisible by four. Signed-off-by: Wang YanQing <udknight@gmail.com> Signed-off-by: Aliaksey Kandratsenka <alk@tut.by> [alk@tut.by: removed addition of unused #include]
* removed irrelevant commentAliaksey Kandratsenka2014-02-081-3/+0
|
* allow asking for gcc atomics on all platformsAliaksey Kandratsenka2014-02-081-2/+3
| | | | I.e. by doing ./configure CPPFLAGS=-DTCMALLOC_PREFER_GCC_ATOMICS
* chmod -x configure.acAliaksey Kandratsenka2014-02-081-0/+0
| | | | | Because configure.ac is not really executable. And because it interferes with tab completion of configure.
* implement atomics with gcc intrinsicsRiku Voipio2014-02-052-2/+209
| | | | | | | | | | | | | | Gcc after 4.7 provides atomic builtins[1]. Use these instead of adding yet-another-assembly port for Aarch64 (64-bit ARM). This patch enables succesfully building and running atomicops unittest on Aarch64. This patch enables using gcc builtins only when no assembly implementation is provided. But as a quick check, atomicops_unittest and rest of testsuite passes with atomicops-internals-gcc also ARMv7 and X86_64 if the ifdef in atomicops is adjusted to prefer the generic implementation. [1] http://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html
* issue-599: fixing FreeBSD issue with sbrkAliaksey Kandratsenka2014-01-191-36/+5
| | | | | | | Applied patch by yurivict. It was wrong assembly specifically for FreeBSD in sbrk overriding code.
* check debug_malloc_implementation_space via COMPILE_ASSERTAliaksey Kandratsenka2014-01-191-2/+2
| | | | Because we can and because compile-time is always better.
* issue-565: don't pollute global namespace with thread lister APIAliaksey Kandratsenka2014-01-186-40/+41
| | | | | | Instead those functions that are original taken from google's "base" code now have prefix TCMalloc_. So that they don't conflict with other google's libraries having same functions.
* issue-{66,547}: use signal's ucontext when unwinding backtraceAliaksey Kandratsenka2014-01-181-1/+22
| | | | | | | | | | | | In issue-66 (and readme) it is pointed out that sometimes there are some issues grabbing backtrace across signal handler boundary. This code attempts to fix it by grabbing backtrace from signal's ucontext which clearly does not include signal handler boundary. We're using "feature" of libunwind that for some important platforms libunwind's context is same as libc's ucontext_t which is given to us as part of calling signal handler.
* issue-581: avoid destructing DebugMallocImplementationAliaksey Kandratsenka2014-01-181-2/+10
| | | | | | | | | | | Because otherwise destructor might be invoked well before other places that might touch malloc extension instance. We're using placement new to initialize it and pass pointer to MallocExtension::Register. Which ensures that destructor for it is never run. Based on idea suggested by Andrew C. Morrow.
* issue-548: pass -fno-builtin to compiler for unittestsAliaksey Kandratsenka2014-01-181-17/+21
| | | | | | Because clang doesn't understand -fno-builtin-malloc and friends. And otherwise new/delete pairs get optimized away causing our tests that expect hooks to be called to fail.
* eliminated gcc warning on __thread configure snippetAliaksey Kandratsenka2014-01-111-1/+1
| | | | | gcc complained about lack of matching ' in code that force-fails __thread detection on mingw
* fix GCC version detect for platforms other than X86/X64xiaoyur3472014-01-111-1/+4
| | | | | | [alk@tut.by: commented why we're disabling __thread not just for x86] Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
* don't re-define strtoq for VS2013Aliaksey Kandratsenka2014-01-051-1/+1
| | | | Which is part of previous change that wasn't correctly applied.
View Lorry Controller Status