diff options
| author | chappedm@gmail.com <chappedm@gmail.com@6b5cf1ce-ec42-a296-1ba9-69fdba395a50> | 2012-11-03 14:13:21 +0000 |
|---|---|---|
| committer | chappedm@gmail.com <chappedm@gmail.com@6b5cf1ce-ec42-a296-1ba9-69fdba395a50> | 2012-11-03 14:13:21 +0000 |
| commit | c566266b10d2fc4e0c67fec25e2a45ebad803196 (patch) | |
| tree | ce362addbc8742c7adc27d3c8232b2f6ca7fa661 | |
| parent | 4f325fbcc9f0db17fbf108188a32b2c67bcd38e0 (diff) | |
| download | gperftools-c566266b10d2fc4e0c67fec25e2a45ebad803196.tar.gz | |
issue-480: duplicate of issue-385 fixed in r150 however some of the comments in the code
regarding frame pointers needed to be clarified.
git-svn-id: http://gperftools.googlecode.com/svn/trunk@165 6b5cf1ce-ec42-a296-1ba9-69fdba395a50
| -rw-r--r-- | Makefile.am | 5 | ||||
| -rw-r--r-- | configure.ac | 6 |
2 files changed, 4 insertions, 7 deletions
diff --git a/Makefile.am b/Makefile.am index 835dbb3..3a3d002 100644 --- a/Makefile.am +++ b/Makefile.am @@ -69,15 +69,14 @@ endif !ENABLE_FRAME_POINTERS endif X86_64_AND_NO_FP_BY_DEFAULT # As of gcc 4.6, -fomit-frame-pointer is the default even for i386. Since -# we must always have frame pointers for i386 in order to generate backtraces -# we now specify -fno-omit-frame-pointer by default (i386 only). +# we must always have frame pointers for gcc i386 in order to generate +# backtraces we now specify -fno-omit-frame-pointer by default (i386 only). if GCC if I386 AM_CXXFLAGS += -fno-omit-frame-pointer endif I386 endif GCC - # For windows systems (at least, mingw), we need to tell all our # tests to link in libtcmalloc using -u. This is because libtcmalloc # accomplishes its tasks via patching, leaving no work for the linker diff --git a/configure.ac b/configure.ac index 31ab69e..9e093b4 100644 --- a/configure.ac +++ b/configure.ac @@ -214,16 +214,14 @@ AM_CONDITIONAL(ENABLE_STATIC, test "$enable_static" = yes) AC_CHECK_LIB(unwind, backtrace, UNWIND_LIBS=-lunwind, UNWIND_LIBS=) AC_SUBST(UNWIND_LIBS) -# On x86_64, instead of libunwind, we can choose to compile with frame-pointers -# (This isn't needed on i386, where -fno-omit-frame-pointer is the default). +# On x86_64, instead of libunwind, we can choose to compile with frame-pointers. AC_ARG_ENABLE(frame_pointers, AS_HELP_STRING([--enable-frame-pointers], [On x86_64 systems, compile with -fno-omit-frame-pointer (see INSTALL)]), , enable_frame_pointers=no) AM_CONDITIONAL(ENABLE_FRAME_POINTERS, test "$enable_frame_pointers" = yes) -# Some x86_64 systems do not insert frame pointers by default (all -# i386 systems that I know of, do. I don't know about non-x86 chips). +# Some x86_64 systems do not insert frame pointers by default. # We want to see if the current system is one of those. AC_COMPILE_IFELSE([AC_LANG_PROGRAM(, [return __x86_64__ == 1 ? 0 : 1])], [is_x86_64=yes], [is_x86_64=no]) |