summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* [release-branch.go1.2] runtime: fix crash in runtime.GoroutineProfileRuss Cox2014-02-284-4/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL is not exactly a copy of the original quoted below. This CL omits the changes made to mgc0.c in the original. Those changes do not apply cleanly to the Go 1.2 tree, and they were cosmetic, simplifying code that was already doing the right thing. To double-check that omitting the mgc0.c change has not invalidated the fix, I have verified by hand that the test program in issue 6946 fails without this CL and passes with this CL. ??? CL 41640043 / e4c381446b48 runtime: fix crash in runtime.GoroutineProfile This is a possible Go 1.2.1 candidate. Fixes issue 6946. R=iant, r CC=golang-dev https://codereview.appspot.com/41640043 ??? LGTM=adg R=adg CC=golang-codereviews, golang-dev, iant, r https://codereview.appspot.com/68820045
* [release-branch.go1.2] runtime: if traceback sees a breakpoint, don't change ↵Russ Cox2014-02-271-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | the PC ??? CL 49580044 / 38cd458b1dfe runtime: if traceback sees a breakpoint, don't change the PC Changing the PC confuses gdb, because execution does not continue where gdb expects it. Not changing the PC has the potential to confuse a stack dump, but when running under gdb it seems better to confuse a stack dump than to confuse gdb. Fixes issue 6776. LGTM=rsc R=golang-codereviews, dvyukov, rsc CC=golang-codereviews https://codereview.appspot.com/49580044 ??? LGTM=r R=golang-codereviews, r CC=golang-dev https://codereview.appspot.com/69800043
* [release-branch.go1.2] runtime: fix data race in GCRuss Cox2014-02-271-1/+4
| | | | | | | | | | | | | | | | | ??? CL 52090045 / 302bdb5b08b1 runtime: fix data race in GC Fixes issue 5139. Update issue 7065. R=golang-codereviews, bradfitz, minux.ma CC=golang-codereviews https://codereview.appspot.com/52090045 ??? LGTM=r R=golang-codereviews, r CC=golang-dev https://codereview.appspot.com/69790043
* [release-branch.go1.2] net: ignore some errors in windows AcceptRuss Cox2014-02-273-8/+188
| | | | | | | | | | | | | | | | | ??? CL 49490043 / 7ecbc2b8ec97 net: ignore some errors in windows Accept Fixes issue 6987 R=golang-codereviews, dvyukov CC=golang-codereviews https://codereview.appspot.com/49490043 ??? LGTM=r R=golang-codereviews, r CC=golang-dev https://codereview.appspot.com/69780044
* [release-branch.go1.2] database/sql: Use all connections in poolRuss Cox2014-02-272-2/+25
| | | | | | | | | | | | | | | | | | | ??? CL 40410043 / 8a7ac002f840 database/sql: Use all connections in pool The last connection in the pool was not being handed out correctly. R=golang-codereviews, gobot, bradfitz CC=golang-codereviews https://codereview.appspot.com/40410043 Committer: Brad Fitzpatrick <bradfitz@golang.org> ??? LGTM=r R=golang-codereviews, r CC=golang-dev https://codereview.appspot.com/68820044
* [release-branch.go1.2] doc/asm: more about SP, ARM R11Andrew Gerrand2013-11-183-4/+4
| | | | | | | | | | | | | | | | ??? CL 26170043 / b1edf8faa5d6 doc/asm: more about SP, ARM R11 Also rename URL to /doc/asm. R=golang-dev, minux.ma, r CC=golang-dev https://codereview.appspot.com/26170043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/28120043
* [release-branch.go1.2] encoding/gob: do not use MarshalText, UnmarshalTextAndrew Gerrand2013-11-183-10/+32
| | | | | | | | | | | | | | | | | | ??? CL 22770044 / 23fc3139589c encoding/gob: do not use MarshalText, UnmarshalText This seems to be the best of a long list of bad ways to fix this issue. Fixes issue 6760. R=r CC=golang-dev https://codereview.appspot.com/22770044 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/28110043
* [release-branch.go1.2] encoding/gob: expose encode/decode exampleAndrew Gerrand2013-11-181-1/+1
| | | | | | | | | | | | | | ??? CL 26220045 / d76ade89413f encoding/gob: expose encode/decode example R=golang-dev, r CC=golang-dev https://codereview.appspot.com/26220045 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/25380044
* [release-branch.go1.2] src/cmd/?a: link to new assembler documentAndrew Gerrand2013-11-133-1/+14
| | | | | | | | | | | | | | | ??? CL 18430044 / 1a86e8314ff5 src/cmd/?a: link to new assembler document Blocked on 20930043, the CL the new text references. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/18430044 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/25480046
* [release-branch.go1.2] cmd/godoc: document package-level examplesAndrew Gerrand2013-11-131-2/+4
| | | | | | | | | | | | | | | | | | ??? CL 23940043 / 6ad0ec54cf2d cmd/godoc: document package-level examples Fixes issue 5807 . R=golang-dev, adg CC=golang-dev https://codereview.appspot.com/23940043 Committer: Andrew Gerrand <adg@golang.org> ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/25500045
* [release-branch.go1.2] cmd/cgo: fix handling of array of pointers when using ↵Andrew Gerrand2013-11-131-11/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clang ??? CL 22840043 / e6794866ebeb cmd/cgo: fix handling of array of pointers when using clang Clang does not record the "size" field for pointer types, so we must insert the size ourselves. We were already doing this, but only for the case of pointer types. For an array of pointer types, the setting of the size for the nested pointer type was happening after the computation of the size of the array type, meaning that the array type was always computed as 0 bytes. Delay the size computation. This bug happens on all Clang systems, not just FreeBSD. Our test checked that cgo wrote something, not that it was correct. FreeBSD's default clang rejects array[0] as a C struct field, so it noticed the incorrect sizes. But the sizes were incorrect everywhere. Update testcdefs to check the output has the right semantics. Fixes issue 6292. R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/22840043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/25460046
* [release-branch.go1.2] go/doc: add full stop of Japanese, Chinese and Korean.Andrew Gerrand2013-11-132-0/+5
| | | | | | | | | | | | | | | | | | ??? CL 21130043 / 0685a9549d5a go/doc: add full stop of Japanese, Chinese and Korean. This fix will show a good synopsis on package listings in that languages. R=adg, r CC=golang-dev https://codereview.appspot.com/21130043 Committer: Andrew Gerrand <adg@golang.org> ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/25720043
* [release-branch.go1.2] net/textproto: fix CanonicalMIMEHeaderKey panicAndrew Gerrand2013-11-132-6/+7
| | | | | | | | | | | | | | | | ??? CL 21450043 / e081962da65c net/textproto: fix CanonicalMIMEHeaderKey panic Fixes issue 6712 R=golang-dev, adg, rsc CC=golang-dev https://codereview.appspot.com/21450043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/25640044
* [release-branch.go1.2] cmd/5l, runtime: fix divide for profiling tracebacks ↵Andrew Gerrand2013-11-013-6/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | on ARM ??? CL 19910044 / 9eb64f5ef3a6 cmd/5l, runtime: fix divide for profiling tracebacks on ARM Two bugs: 1. The first iteration of the traceback always uses LR when provided, which it is (only) during a profiling signal, but in fact LR is correct only if the stack frame has not been allocated yet. Otherwise an intervening call may have changed LR, and the saved copy in the stack frame should be used. Fix in traceback_arm.c. 2. The division runtime call adds 8 bytes to the stack. In order to keep the traceback routines happy, it must copy the saved LR into the new 0(SP). Change SUB $8, SP into MOVW 0(SP), R11 // r11 is temporary, for use by linker MOVW.W R11, -8(SP) to update SP and 0(SP) atomically, so that the traceback always sees a saved LR at 0(SP). Fixes issue 6681. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/19910044 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20170048
* [release-branch.go1.2] cmd/cgo: accept extra leading _ on __cgodebug_data ↵Andrew Gerrand2013-11-011-4/+8
| | | | | | | | | | | | | | | | | | | | | for all object formats ??? CL 19780043 / 8b49cdda6ff4 cmd/cgo: accept extra leading _ on __cgodebug_data for all object formats The current Windows build breakage appears to be because the Windows code should be looking for __cgodebug_data not ___cgodebug_data. Dodge the question everywhere by accepting both. R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/19780043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20660043
* [release-branch.go1.2] database/sql: document Result methodsAndrew Gerrand2013-11-011-0/+9
| | | | | | | | | | | | | | | | ??? CL 19280046 / 2ad8ac71220d database/sql: document Result methods Fixes issue 5110 R=golang-dev, r CC=golang-dev https://codereview.appspot.com/19280046 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20650043
* [release-branch.go1.2] database/sql: Fix typos in docAndrew Gerrand2013-11-012-3/+3
| | | | | | | | | | | | | | | | ??? CL 17590043 / fb5224487f1b database/sql: Fix typos in doc R=golang-dev CC=bradfitz, golang-dev https://codereview.appspot.com/17590043 Committer: Brad Fitzpatrick <bradfitz@golang.org> ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20150046
* [release-branch.go1.2] time: correct path to time zone zip file on UnixAndrew Gerrand2013-11-015-2/+35
| | | | | | | | | | | | | | | | | | | | | | ??? CL 19280043 / 9d199c7582d6 time: correct path to time zone zip file on Unix Most Unix systems have their own time zone data, so we almost never get far enough in the list to discover that we cannot fall back to the zip file. Adjust testing to exercise the final fallback. Plan 9 and Windows were already correct (and are the main users of the zip file). R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/19280043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20640043
* [release-branch.go1.2] encoding/xml: fix doc commentAndrew Gerrand2013-11-011-1/+1
| | | | | | | | | | | | | | | | | | ??? CL 19300046 / 5ac568b9d67b encoding/xml: fix doc comment The tag is ",chardata" not "chardata". Fixes issue 6631. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/19300046 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20060045
* [release-branch.go1.2] net/http/httputil: fix DumpRequestOut with ↵Andrew Gerrand2013-11-012-3/+55
| | | | | | | | | | | | | | | | | | ContentLength & false body param ??? CL 14920050 / 5ed8c82778ae net/http/httputil: fix DumpRequestOut with ContentLength & false body param Fixes issue 6471 R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/14920050 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20590044
* [release-branch.go1.2] os: do not return Lstat errors from ReaddirAndrew Gerrand2013-11-012-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ??? CL 18870043 / eca0ca43a863 os: do not return Lstat errors from Readdir This CL restores the Go 1.1.2 semantics for os.File's Readdir method. The code in Go 1.1.2 was rewritten mainly because it looked buggy. This new version attempts to be clearer but still provide the 1.1.2 results. The important diff is not this CL's version against tip but this CL's version against Go 1.1.2. Go 1.1.2: names, err := f.Readdirnames(n) fi = make([]FileInfo, len(names)) for i, filename := range names { fip, err := Lstat(dirname + filename) if err == nil { fi[i] = fip } else { fi[i] = &fileStat{name: filename} } } return fi, err This CL: names, err := f.Readdirnames(n) fi = make([]FileInfo, len(names)) for i, filename := range names { fip, lerr := lstat(dirname + filename) if lerr != nil { fi[i] = &fileStat{name: filename} continue } fi[i] = fip } return fi, err The changes from Go 1.1.2 are stylistic, not semantic: 1. Use lstat instead of Lstat, for testing (done before this CL). 2. Make error handling in loop body look more like an error case. 3. Use separate error variable name in loop body, to be clear we are not trying to influence the final return result. Fixes issue 6656. Fixes issue 6680. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/18870043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20110045
* [release-branch.go1.2] cmd/gc: silence clang warningAndrew Gerrand2013-11-011-1/+1
| | | | | | | | | | | | | | | | | ??? CL 19160043 / 104d56b5d664 cmd/gc: silence clang warning This code is only built when you run 'make' in cmd/gc, not in all.bash. R=golang-dev, jsing, iant CC=golang-dev https://codereview.appspot.com/19160043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20290046
* [release-branch.go1.2] debug/dwarf: add DWARF 4 form constantsAndrew Gerrand2013-11-012-0/+28
| | | | | | | | | | | | | | | | | | | | | ??? CL 18460043 / 08e6655618f5 debug/dwarf: add DWARF 4 form constants Some versions of clang generate DWARF 4-format attributes even when using -gdwarf-2. We don't care much about the values, but we do need to be able to parse past them. This fixes a bug in Go 1.2 rc2 reported via private mail using a near-tip version of clang. R=golang-dev, iant, dvyukov CC=golang-dev https://codereview.appspot.com/18460043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20470045
* [release-branch.go1.2] cmd/cgo: stop using -fno-eliminate-unused-debug-typesAndrew Gerrand2013-11-011-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ??? CL 18850043 / 5ef4bf9eb256 cmd/cgo: stop using -fno-eliminate-unused-debug-types This flag was added in January 2010, in CL 181102, to fix issue 497. (Numbers were just shorter back then.) The fix was for OS X machines and the llvm-gcc frontend. In July 2011 we had to change the way we get enum values, because there were no flags available to force Xcode's llvm-gcc to include the enum names and values in DWARF debug output. We now use clang, not llvm-gcc, on OS X machines. Earlier versions of clang printed a warning about not knowing the flag. Newer versions of clang now make that an error. That is: - The flag was added for OS X machines. - The flag is no longer necessary on OS X machines. - The flag now breaks some OS X machines. Remove it. I have run the original program from issue 497 successfully without the flag on both OS X and Linux machines. Fixes issue 6678. R=golang-dev, minux.ma CC=golang-dev https://codereview.appspot.com/18850043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/19850048
* [release-branch.go1.2] runtime: relax preemption assertion during stack splitAndrew Gerrand2013-11-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | ??? CL 18740044 / 1a8903f0a577 runtime: relax preemption assertion during stack split The case can happen when starttheworld is calling acquirep to get things moving again and acquirep gets preempted. The stack trace is in golang.org/issue/6644. It is difficult to build a short test case for this, but the person who reported issue 6644 confirms that this solves the problem. Fixes issue 6644. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/18740044 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20460044
* [release-branch.go1.2] net: handle single-line non-\n-terminated files ↵Andrew Gerrand2013-11-013-1/+15
| | | | | | | | | | | | | | | | | | | | correctly in readLine ??? CL 15960047 / a0d4544cdb2a net: handle single-line non-\n-terminated files correctly in readLine Fixes issue 6646. R=rsc, bradfitz CC=golang-dev https://codereview.appspot.com/15960047 Committer: Russ Cox <rsc@golang.org> ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20560044
* [release-branch.go1.2] net/url: fix Encode doc commentAndrew Gerrand2013-11-011-2/+2
| | | | | | | | | | | | | | | | ??? CL 16430043 / f9af8b83c78c net/url: fix Encode doc comment Encoded query strings are always sorted by key; the example wasn't. R=golang-dev, dsymonds, minux.ma, bradfitz CC=golang-dev https://codereview.appspot.com/16430043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20480044
* [release-branch.go1.2] strings: fix Replacer bug with prefix matchesAndrew Gerrand2013-11-012-2/+14
| | | | | | | | | | | | | | | | | | | | | | ??? CL 16880043 / 0eb6508d3e88 strings: fix Replacer bug with prefix matches singleStringReplacer had a bug where if a string was replaced at the beginning and no output had yet been produced into the temp buffer before matching ended, an invalid nil check (used as a proxy for having matched anything) meant it always returned its input. Fixes issue 6659 R=golang-dev, r CC=golang-dev https://codereview.appspot.com/16880043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20570044
* [release-branch.go1.2] database/sql: link to wiki in package docsAndrew Gerrand2013-11-011-0/+3
| | | | | | | | | | | | | | | | | | ??? CL 14087043 / 7ebbddd21330 database/sql: link to wiki in package docs Update issue 5886 R=golang-dev, kamil.kisiel, adg, r, rsc, dave, arnehormann, bradfitz CC=golang-dev https://codereview.appspot.com/14087043 Committer: Brad Fitzpatrick <bradfitz@golang.org> ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20610043
* [release-branch.go1.2] cmd/cgo: use __typeof__, -w instead of typeof, -Wno-allAndrew Gerrand2013-11-012-15/+15
| | | | | | | | | | | | | | | | ??? CL 14920052 / 98840b3349f4 cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all Suggested by iant in earlier CL. R=golang-dev, bradfitz, iant CC=golang-dev https://codereview.appspot.com/14920052 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20600043
* [release-branch.go1.2] time: fix ParseDuration overflow when given more than ↵Andrew Gerrand2013-11-012-2/+4
| | | | | | | | | | | | | | | | | | | 9 digits on 32-bit arch ??? CL 15080043 / fbf3b853e00b time: fix ParseDuration overflow when given more than 9 digits on 32-bit arch Fixes issue 6617. R=golang-dev, rsc, r CC=golang-dev https://codereview.appspot.com/15080043 Committer: Russ Cox <rsc@golang.org> ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20050045
* [release-branch.go1.2] math: remove unnecessary source fileAndrew Gerrand2013-11-011-69/+0
| | | | | | | | | | | | | | | | | ??? CL 15750046 / 2d1e1adf8ece math: remove unnecessary source file The routines in this file are dregs from a very early copy of the math API. There are no Go prototypes and no non-amd64 implementations. R=golang-dev, minux.ma CC=golang-dev https://codereview.appspot.com/15750046 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/19560045
* [release-branch.go1.2] go/build: document the go1.2 build tagAndrew Gerrand2013-11-011-0/+1
| | | | | | | | | | | | | | | | ??? CL 14930046 / d4f6533fad0b go/build: document the go1.2 build tag R=golang-dev, adg CC=golang-dev https://codereview.appspot.com/14930046 Committer: Andrew Gerrand <adg@golang.org> ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/19960044
* [release-branch.go1.2] crypto/x509: name constraints should be a disjunction.Andrew Gerrand2013-11-012-1/+188
| | | | | | | | | | | | | | | | | ??? CL 15570044 / b4c37131e846 crypto/x509: name constraints should be a disjunction. The code was requiring that all constraints be met, but it should be satisfied by meeting *any* of them. R=golang-dev, bradfitz, r CC=golang-dev https://codereview.appspot.com/15570044 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20580043
* [release-branch.go1.2] crypto/tls: advertise support for RSA+SHA1 in TLS 1.2 ↵Andrew Gerrand2013-11-016-157/+218
| | | | | | | | | | | | | | | | | | | | | | | | | | handshake. ??? CL 15650043 / 29d3ab5ced5a crypto/tls: advertise support for RSA+SHA1 in TLS 1.2 handshake. Despite SHA256 support being required for TLS 1.2 handshakes, some servers are aborting handshakes that don't offer SHA1 support. This change adds support for signing TLS 1.2 ServerKeyExchange messages with SHA1. It does not add support for signing TLS 1.2 client certificates with SHA1 as that would require the handshake to be buffered. Fixes issue 6618. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/15650043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20570043
* [release-branch.go1.2] net/mail: fix minor doc typo.Andrew Gerrand2013-11-011-1/+1
| | | | | | | | | | | | | | ??? CL 15510043 / 6752a7aad603 net/mail: fix minor doc typo. R=golang-dev, minux.ma CC=golang-dev https://codereview.appspot.com/15510043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20560043
* [release-branch.go1.2] cmd/yacc: fix stderr on Windows.Andrew Gerrand2013-11-011-1/+1
| | | | | | | | | | | | | | | ??? CL 15330043 / 69bf31787310 cmd/yacc: fix stderr on Windows. Fixes issue 6620. R=golang-dev, dave, r CC=golang-dev https://codereview.appspot.com/15330043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20550043
* [release-branch.go1.2] cmd/cgo: fix line number in an error messageAndrew Gerrand2013-11-011-1/+11
| | | | | | | | | | | | | | | | ??? CL 14870046 / b508daf6dae6 cmd/cgo: fix line number in an error message Fixes issue 6563. R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/14870046 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20150045
* [release-branch.go1.2] cmd/cgo: stop using compiler error message text to ↵Andrew Gerrand2013-11-012-145/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | analyze C names ??? CL 15070043 / 90a628ac54ed cmd/cgo: stop using compiler error message text to analyze C names The old approach to determining whether "name" was a type, constant, or expression was to compile the C program name; and scan the errors and warnings generated by the compiler. This requires looking for specific substrings in the errors and warnings, which ties the implementation to specific compiler versions. As compilers change their errors or drop warnings, cgo breaks. This happens slowly but it does happen. Clang in particular (now required on OS X) has a significant churn rate. The new approach compiles a slightly more complex program that is either valid C or not valid C depending on what kind of thing "name" is. It uses only the presence or absence of an error message on a particular line, not the error text itself. The program is: // error if and only if name is undeclared void f1(void) { typeof(name) *x; } // error if and only if name is not a type void f2(void) { name *x; } // error if and only if name is not an integer constant void f3(void) { enum { x = (name)*1 }; } I had not been planning to do this until Go 1.3, because it is a non-trivial change, but it fixes a real Xcode 5 problem in Go 1.2, and the new code is easier to understand than the old code. It should be significantly more robust. Fixes issue 6596. Fixes issue 6612. R=golang-dev, r, james, iant CC=golang-dev https://codereview.appspot.com/15070043 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20060044
* [release-branch.go1.2] cmd/gc: shorten name used for map bucket typeAndrew Gerrand2013-11-012-0/+8
| | | | | | | | | | | | | | | | | | | | | | ??? CL 15110044 / 95336afd420c cmd/gc: shorten name used for map bucket type Before: type.struct { buckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; oldbuckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable } } After: type.map.bucket[string]*"".RangeTable This makes debugging maps a little nicer, and it takes up less space in the binary. R=golang-dev, r CC=golang-dev, khr https://codereview.appspot.com/15110044 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20050044
* [release-branch.go1.2] net: make sure failed Dial returns nil ConnAndrew Gerrand2013-11-012-10/+62
| | | | | | | | | | | | | | | | ??? CL 14950045 / 1e60ffd5933d net: make sure failed Dial returns nil Conn Fixes issue 6614. R=golang-dev, bradfitz, mikioh.mikioh CC=golang-dev https://codereview.appspot.com/14950045 ??? R=golang-dev CC=golang-dev https://codereview.appspot.com/20170047
* [release-branch.go1.2] runtime: remove nomemprofAndrew Gerrand2013-11-013-13/+0
| | | | | | | | | | | | | | | | | ??? CL 14695044 / 35d5bae6aac8 runtime: remove nomemprof Nomemprof seems to be unneeded now, there is no recursion. If the recursion will be re-introduced, it will break loudly by deadlocking. Fixes issue 6566. R=golang-dev, minux.ma, rsc CC=golang-dev https://codereview.appspot.com/14695044 ??? R=golang-dev, dsymonds CC=golang-dev https://codereview.appspot.com/20540043
* go1.2rc2go1.2rc2Andrew Gerrand2013-10-183-964/+0
|
* api: add go1.2.txt, use in testsAndrew Gerrand2013-10-181-1/+1
| | | | | | R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/14860043
* net/url: fix regression when serializing relative URLsBrad Fitzpatrick2013-10-172-1/+9
| | | | | | | | | | | Only add a slash to path if it's a separator between a host and path. Fixes issue 6609 R=golang-dev, dsymonds, r CC=golang-dev https://codereview.appspot.com/14815043
* runtime: correct test for when to poll networkIan Lance Taylor2013-10-171-1/+1
| | | | | | | | Fixes issue 6610. R=golang-dev, khr CC=golang-dev https://codereview.appspot.com/14793043
* runtime: correct parameter name in MCentral_AllocList commentIan Lance Taylor2013-10-171-1/+1
| | | | | | R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/14792043
* encoding/xml: accept chains of interfaces and pointersRuss Cox2013-10-172-6/+43
| | | | | | | | Fixes issue 6556. R=golang-dev, iant, adg CC=golang-dev https://codereview.appspot.com/14747043
* database/sql: make tests repeatable with -cpu=n,nAlberto Garc?a Hierro2013-10-171-0/+2
| | | | | | | | | | | | | New test added in CL 14611045 causes a deadlock when running the tests with -cpu=n,n because the fakedb driver always waits when opening a new connection after running TestConnectionLeak. Reset its state after. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/14780043 Committer: Brad Fitzpatrick <bradfitz@golang.org>
* database/sql: fix some test fmt verbsBrad Fitzpatrick2013-10-162-4/+4
| | | | | | | | Found by vet. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/14762044
View Lorry Controller Status