| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
R=rsc, bradfitz
CC=golang-codereviews, golang-dev
https://codereview.appspot.com/95010046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 100110043 / 51dc50080c9f
doc: document go1.2.2
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/100110043
???
R=iant
CC=golang-codereviews, golang-dev
https://codereview.appspot.com/98960043
|
|
|
|
|
|
| |
R=minux.ma, r
CC=golang-codereviews, golang-dev
https://codereview.appspot.com/70650043
|
|
|
|
|
|
|
|
|
| |
Note the installation instructions change doesn't apply here,
so I had to patch this in manually instead of using release-apply.
R=minux.ma, r
CC=golang-codereviews, golang-dev
https://codereview.appspot.com/69860047
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is not exactly a copy of the original quoted below.
This CL omits the changes made to mgc0.c in the original.
Those changes do not apply cleanly to the Go 1.2 tree,
and they were cosmetic, simplifying code that was already
doing the right thing.
To double-check that omitting the mgc0.c change has not
invalidated the fix, I have verified by hand that the test program
in issue 6946 fails without this CL and passes with this CL.
??? CL 41640043 / e4c381446b48
runtime: fix crash in runtime.GoroutineProfile
This is a possible Go 1.2.1 candidate.
Fixes issue 6946.
R=iant, r
CC=golang-dev
https://codereview.appspot.com/41640043
???
LGTM=adg
R=adg
CC=golang-codereviews, golang-dev, iant, r
https://codereview.appspot.com/68820045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the PC
??? CL 49580044 / 38cd458b1dfe
runtime: if traceback sees a breakpoint, don't change the PC
Changing the PC confuses gdb, because execution does not
continue where gdb expects it. Not changing the PC has the
potential to confuse a stack dump, but when running under gdb
it seems better to confuse a stack dump than to confuse gdb.
Fixes issue 6776.
LGTM=rsc
R=golang-codereviews, dvyukov, rsc
CC=golang-codereviews
https://codereview.appspot.com/49580044
???
LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://codereview.appspot.com/69800043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 52090045 / 302bdb5b08b1
runtime: fix data race in GC
Fixes issue 5139.
Update issue 7065.
R=golang-codereviews, bradfitz, minux.ma
CC=golang-codereviews
https://codereview.appspot.com/52090045
???
LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://codereview.appspot.com/69790043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 49490043 / 7ecbc2b8ec97
net: ignore some errors in windows Accept
Fixes issue 6987
R=golang-codereviews, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/49490043
???
LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://codereview.appspot.com/69780044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 40410043 / 8a7ac002f840
database/sql: Use all connections in pool
The last connection in the pool was not being handed out correctly.
R=golang-codereviews, gobot, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/40410043
Committer: Brad Fitzpatrick <bradfitz@golang.org>
???
LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://codereview.appspot.com/68820044
|
|
|
|
|
|
| |
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/34820044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 30900044 / 65bf677ab8d8
doc/install.html: fix a tag.
R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/30900044
Committer: Andrew Gerrand <adg@golang.org>
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/34860044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 31770043 / 286f0ddb799b
misc/vim: describe how to get gofmt-on-save behaviour.
Fixes issue 6826.
R=golang-dev, bradfitz, adg
CC=golang-dev
https://codereview.appspot.com/31770043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/34960043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 28500043 / 1140207a3395
README: Fix installation instructions
They were out of date and should refer to the source installation instructions.
Fixes issue 6783.
R=golang-dev, rsc, adg, dave
CC=golang-dev
https://codereview.appspot.com/28500043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/34880045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 28700043 / 8b3699321603
doc: update installation instructions
Clarify that GOROOT should only be set when using a custom install path.
Remove NetBSD from binary install page (we don't provide binaries).
Remove "What's next" links from installation instructions.
Emphasize "How to Write Go Code" page.
Fixes issue 6613.
R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/28700043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/34950043
|
|
|
|
|
|
| |
R=dsymonds
CC=golang-dev
https://codereview.appspot.com/28140043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 27000043 / c8d3de543c1b
C: add Marko Mikulicic (Google CLA)
R=golang-dev, crawshaw
CC=golang-dev
https://codereview.appspot.com/27000043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/28130043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 26170043 / b1edf8faa5d6
doc/asm: more about SP, ARM R11
Also rename URL to /doc/asm.
R=golang-dev, minux.ma, r
CC=golang-dev
https://codereview.appspot.com/26170043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/28120043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 22770044 / 23fc3139589c
encoding/gob: do not use MarshalText, UnmarshalText
This seems to be the best of a long list of bad ways to fix this issue.
Fixes issue 6760.
R=r
CC=golang-dev
https://codereview.appspot.com/22770044
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/28110043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 26220045 / d76ade89413f
encoding/gob: expose encode/decode example
R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/26220045
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25380044
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/25420045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 18430044 / 1a86e8314ff5
src/cmd/?a: link to new assembler document
Blocked on 20930043, the CL the new text references.
R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/18430044
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25480046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
assembler
??? CL 20930043 / 5a585f237d28
doc/asm.html: new document, a brief guide to the assembler
Fixes issue 6060
R=golang-dev, iant, bradfitz, josharian, minux.ma, aram, rsc
CC=golang-dev
https://codereview.appspot.com/20930043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25820043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 14415043 / 4daa80747394
spec: clarify rules for blank identifiers
This documents the status quo more precisely.
Not a language change.
Fixes issue 6006.
R=r, rsc, iant, ken
CC=golang-dev
https://codereview.appspot.com/14415043
Committer: Russ Cox <rsc@golang.org>
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25790043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 25670043 / b7308814101a
doc: use the same wording for OS X as the other OSes
I used "and above" when I should have said "or later".
Sorry for the churn.
R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/25670043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25780043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 25370045 / d809ded6f335
doc: we support all recent versions of OS X
R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/25370045
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25580044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Richard Musiol
??? CL 25360043 / 37afbf6361e2
CONTRIBUTORS: add additional e-mail address for Richard Musiol
R=adonovan
CC=golang-dev
https://codereview.appspot.com/25360043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25770043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 25350043 / d3cc963320cd
A+C: Richard Musiol (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://codereview.appspot.com/25350043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25670044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 22940044 / 39c724dd7f25
misc/vim: add a gofmt_command flag for :Fmt
R=dsymonds, dominik.honnef, n13m3y3r, rsc, kamil.kisiel
CC=golang-dev
https://codereview.appspot.com/22940044
Committer: David Symonds <dsymonds@golang.org>
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25760043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 23940043 / 6ad0ec54cf2d
cmd/godoc: document package-level examples
Fixes issue 5807 .
R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/23940043
Committer: Andrew Gerrand <adg@golang.org>
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25500045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 20100043 / 9fe43a708b89
misc/emacs: various cleanups
- Use #' for function symbols
- Remove unused variables
- Use declare-function to shut up byte compiler
This is identical to CL 19010044 with one exception: Making sure
it doesn't break on Emacs 22.1
R=adonovan, bradfitz, shendaras
CC=golang-dev
https://codereview.appspot.com/20100043
Committer: Alan Donovan <adonovan@google.com>
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25750043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
particular, to use goimports instead.
??? CL 23680043 / 341a490e4736
emacs: allow users to customize the gofmt command, in particular, to use goimports instead.
R=adonovan
CC=golang-dev
https://codereview.appspot.com/23680043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25740043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang
??? CL 22840043 / e6794866ebeb
cmd/cgo: fix handling of array of pointers when using clang
Clang does not record the "size" field for pointer types,
so we must insert the size ourselves. We were already
doing this, but only for the case of pointer types.
For an array of pointer types, the setting of the size for
the nested pointer type was happening after the computation
of the size of the array type, meaning that the array type
was always computed as 0 bytes. Delay the size computation.
This bug happens on all Clang systems, not just FreeBSD.
Our test checked that cgo wrote something, not that it was correct.
FreeBSD's default clang rejects array[0] as a C struct field,
so it noticed the incorrect sizes. But the sizes were incorrect
everywhere.
Update testcdefs to check the output has the right semantics.
Fixes issue 6292.
R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/22840043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25460046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 22510043 / 77e77f508509
doc: update note about GCC 4.8.2 in gccgo instructions
R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/22510043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25730043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 21130043 / 0685a9549d5a
go/doc: add full stop of Japanese, Chinese and Korean.
This fix will show a good synopsis on package listings in that languages.
R=adg, r
CC=golang-dev
https://codereview.appspot.com/21130043
Committer: Andrew Gerrand <adg@golang.org>
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25720043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 21790043 / cbbdbdf908b9
A+C: Ato Araki (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://codereview.appspot.com/21790043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25640046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 21770043 / ae58065f7dff
doc/go1.2: link to cgo documentation
I know it's linked in the previous sentence, but this new link is where I want it to be while reading this sentence.
R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/21770043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25640045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 21450043 / e081962da65c
net/textproto: fix CanonicalMIMEHeaderKey panic
Fixes issue 6712
R=golang-dev, adg, rsc
CC=golang-dev
https://codereview.appspot.com/21450043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25640044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 21390044 / dc2762a9130d
C: add Robert Snedegar (Google CLA)
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/21390044
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25420044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 19990045 / 78cebfb89b21
C: add Brad Garcia (Google CLA)
R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/19990045
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25700044
|
|
|
|
|
|
| |
R=golang-dev, nigeltao
CC=golang-dev
https://codereview.appspot.com/19560047
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on ARM
??? CL 19910044 / 9eb64f5ef3a6
cmd/5l, runtime: fix divide for profiling tracebacks on ARM
Two bugs:
1. The first iteration of the traceback always uses LR when provided,
which it is (only) during a profiling signal, but in fact LR is correct
only if the stack frame has not been allocated yet. Otherwise an
intervening call may have changed LR, and the saved copy in the stack
frame should be used. Fix in traceback_arm.c.
2. The division runtime call adds 8 bytes to the stack. In order to
keep the traceback routines happy, it must copy the saved LR into
the new 0(SP). Change
SUB $8, SP
into
MOVW 0(SP), R11 // r11 is temporary, for use by linker
MOVW.W R11, -8(SP)
to update SP and 0(SP) atomically, so that the traceback always
sees a saved LR at 0(SP).
Fixes issue 6681.
R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/19910044
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20170048
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 19840043 / 938b64b0f608
doc/go1.2.html: delete repeated word
TBR=rsc
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/19840043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20240044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 19600043 / 746466b52725
doc/go1.2.html: stack sizes, thread limits
R=golang-dev, minux.ma, adg, rsc
CC=golang-dev
https://codereview.appspot.com/19600043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20110046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for all object formats
??? CL 19780043 / 8b49cdda6ff4
cmd/cgo: accept extra leading _ on __cgodebug_data for all object formats
The current Windows build breakage appears to be because
the Windows code should be looking for __cgodebug_data
not ___cgodebug_data. Dodge the question everywhere by
accepting both.
R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/19780043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20660043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 19280046 / 2ad8ac71220d
database/sql: document Result methods
Fixes issue 5110
R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/19280046
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20650043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 17590043 / fb5224487f1b
database/sql: Fix typos in doc
R=golang-dev
CC=bradfitz, golang-dev
https://codereview.appspot.com/17590043
Committer: Brad Fitzpatrick <bradfitz@golang.org>
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20150046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 19510043 / ae106f792e5d
A+C: Jakob Borg (individual CLA).
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/19510043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20570045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
??? CL 19280043 / 9d199c7582d6
time: correct path to time zone zip file on Unix
Most Unix systems have their own time zone data,
so we almost never get far enough in the list to
discover that we cannot fall back to the zip file.
Adjust testing to exercise the final fallback.
Plan 9 and Windows were already correct
(and are the main users of the zip file).
R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/19280043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/20640043
|