summaryrefslogtreecommitdiff
path: root/doc/articles
diff options
context:
space:
mode:
authorBrad Fitzpatrick <bradfitz@golang.org>2012-11-19 12:36:15 -0800
committerBrad Fitzpatrick <bradfitz@golang.org>2012-11-19 12:36:15 -0800
commit904ea3c3b7eb74ef61c3dc40b4c5be26a6ab59d9 (patch)
tree71fb7164b77390126115898103af1b69216f1d06 /doc/articles
parent67eac06690599010ce06f0f3bacb841da6354327 (diff)
downloadgo-904ea3c3b7eb74ef61c3dc40b4c5be26a6ab59d9.tar.gz
doc/articles/wiki: fix racy test
R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6853069
Diffstat (limited to 'doc/articles')
-rw-r--r--doc/articles/wiki/get.go19
-rwxr-xr-xdoc/articles/wiki/test.bash4
2 files changed, 15 insertions, 8 deletions
diff --git a/doc/articles/wiki/get.go b/doc/articles/wiki/get.go
index c6e9bf28b..b3e464b34 100644
--- a/doc/articles/wiki/get.go
+++ b/doc/articles/wiki/get.go
@@ -13,11 +13,13 @@ import (
"net/http"
"os"
"strings"
+ "time"
)
var (
post = flag.String("post", "", "urlencoded form data to POST")
addr = flag.Bool("addr", false, "find open address and print to stdout")
+ wait = flag.Duration("wait_for_port", 0, "if non-zero, the amount of time to wait for the address to become available")
)
func main() {
@@ -37,11 +39,18 @@ func main() {
}
var r *http.Response
var err error
- if *post != "" {
- b := strings.NewReader(*post)
- r, err = http.Post(url, "application/x-www-form-urlencoded", b)
- } else {
- r, err = http.Get(url)
+ loopUntil := time.Now().Add(*wait)
+ for {
+ if *post != "" {
+ b := strings.NewReader(*post)
+ r, err = http.Post(url, "application/x-www-form-urlencoded", b)
+ } else {
+ r, err = http.Get(url)
+ }
+ if err == nil || *wait == 0 || time.Now().After(loopUntil) {
+ break
+ }
+ time.Sleep(100 * time.Millisecond)
}
if err != nil {
log.Fatal(err)
diff --git a/doc/articles/wiki/test.bash b/doc/articles/wiki/test.bash
index 5c2cb60dc..8bd8580f0 100755
--- a/doc/articles/wiki/test.bash
+++ b/doc/articles/wiki/test.bash
@@ -18,9 +18,7 @@ go build -o final-test.bin final-test.go
(./final-test.bin) &
wiki_pid=$!
-sleep 1
-
-./get.bin http://$addr/edit/Test > test_edit.out
+./get.bin --wait_for_port=5s http://$addr/edit/Test > test_edit.out
diff -u test_edit.out test_edit.good
./get.bin -post=body=some%20content http://$addr/save/Test
diff -u Test.txt test_Test.txt.good