diff options
| author | Andrew Gerrand <adg@golang.org> | 2014-08-12 09:29:29 +1000 |
|---|---|---|
| committer | Andrew Gerrand <adg@golang.org> | 2014-08-12 09:29:29 +1000 |
| commit | 0d83ba0248bbc4de6acd2413ace45b8913aa9876 (patch) | |
| tree | c0215a273efba8b217302b71479c249075fd550a | |
| parent | d0554f2511efecc2b7531225c70da926798d7810 (diff) | |
| download | go-0d83ba0248bbc4de6acd2413ace45b8913aa9876.tar.gz | |
[release-branch.go1.3] runtime: fix nacl amd64p32 flakiness
??? CL 102710043 / 5640e19d768d
runtime: fix nacl amd64p32 flakiness
newproc takes two extra pointers, not two extra registers.
On amd64p32 (nacl) they are different.
We diagnosed this before the 1.3 cut but the tree was frozen.
I believe this is causing the random problems on the builder.
Fixes issue 8199.
TBR=r
CC=golang-codereviews
https://codereview.appspot.com/102710043
???
TBR=rsc
CC=golang-codereviews
https://codereview.appspot.com/124120044
| -rw-r--r-- | src/pkg/runtime/traceback_x86.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pkg/runtime/traceback_x86.c b/src/pkg/runtime/traceback_x86.c index 851504f52..7359cfcc9 100644 --- a/src/pkg/runtime/traceback_x86.c +++ b/src/pkg/runtime/traceback_x86.c @@ -214,7 +214,7 @@ runtime·gentraceback(uintptr pc0, uintptr sp0, uintptr lr0, G *gp, int32 skip, // the SP is two words lower than normal. sparg = frame.sp; if(wasnewproc) - sparg += 2*sizeof(uintreg); + sparg += 2*sizeof(uintptr); // Determine frame's 'continuation PC', where it can continue. // Normally this is the return address on the stack, but if sigpanic |