diff options
| author | Andrew Gerrand <adg@golang.org> | 2013-11-13 14:29:35 +1100 |
|---|---|---|
| committer | Andrew Gerrand <adg@golang.org> | 2013-11-13 14:29:35 +1100 |
| commit | a90838de47ded5f891a523ad020ff1d1a0c857d3 (patch) | |
| tree | ded2ebe9ad1994daa6c9a7e17afb2b6aa9cf07f2 | |
| parent | 5cd4e2c86c965a436b72e06132bcb3c15baea523 (diff) | |
| download | go-a90838de47ded5f891a523ad020ff1d1a0c857d3.tar.gz | |
[release-branch.go1.2] net/textproto: fix CanonicalMIMEHeaderKey panic
??? CL 21450043 / e081962da65c
net/textproto: fix CanonicalMIMEHeaderKey panic
Fixes issue 6712
R=golang-dev, adg, rsc
CC=golang-dev
https://codereview.appspot.com/21450043
???
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25640044
| -rw-r--r-- | src/pkg/net/textproto/reader.go | 9 | ||||
| -rw-r--r-- | src/pkg/net/textproto/reader_test.go | 4 |
2 files changed, 7 insertions, 6 deletions
diff --git a/src/pkg/net/textproto/reader.go b/src/pkg/net/textproto/reader.go index 56ece5b08..b0c07413c 100644 --- a/src/pkg/net/textproto/reader.go +++ b/src/pkg/net/textproto/reader.go @@ -574,13 +574,10 @@ func canonicalMIMEHeaderKey(a []byte) string { // and upper case after each dash. // (Host, User-Agent, If-Modified-Since). // MIME headers are ASCII only, so no Unicode issues. - if a[i] == ' ' { - a[i] = '-' - upper = true - continue - } c := a[i] - if upper && 'a' <= c && c <= 'z' { + if c == ' ' { + c = '-' + } else if upper && 'a' <= c && c <= 'z' { c -= toLower } else if !upper && 'A' <= c && c <= 'Z' { c += toLower diff --git a/src/pkg/net/textproto/reader_test.go b/src/pkg/net/textproto/reader_test.go index f27042d4e..cc12912b6 100644 --- a/src/pkg/net/textproto/reader_test.go +++ b/src/pkg/net/textproto/reader_test.go @@ -25,6 +25,10 @@ var canonicalHeaderKeyTests = []canonicalHeaderKeyTest{ {"user-agent", "User-Agent"}, {"USER-AGENT", "User-Agent"}, {"üser-agenT", "üser-Agent"}, // non-ASCII unchanged + + // This caused a panic due to mishandling of a space: + {"C Ontent-Transfer-Encoding", "C-Ontent-Transfer-Encoding"}, + {"foo bar", "Foo-Bar"}, } func TestCanonicalMIMEHeaderKey(t *testing.T) { |