summaryrefslogtreecommitdiff
path: root/src/net/rpc
Commit message (Collapse)AuthorAgeFilesLines
* all: don't call t.Fatal from a goroutineIan Lance Taylor2016-11-151-1/+2
| | | | | | | | | | Fixes #17900. Change-Id: I42cda6ac9cf48ed739d3a015a90b3cb15edf8ddf Reviewed-on: https://go-review.googlesource.com/33243 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* net/rpc: fix method requirement docsRuss Cox2016-10-271-1/+1
| | | | | | | | | | | | | | The receiver itself is not transmitted and does not need to be marshalable by encoding/gob. Fixes #16803. Change-Id: I42a3603fb7d3b36c97dcc2e51a398cd65ec3227d Reviewed-on: https://go-review.googlesource.com/32094 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Rob Pike <r@golang.org>
* net/rpc: enable TestGobError on Plan 9David du Colombier2016-10-261-4/+0
| | | | | | | | | | | | This issue has been fixed in CL 31271. Fixes #8908. Change-Id: I8015490e2d992e09c664560e42188315e0e0669e Reviewed-on: https://go-review.googlesource.com/32150 Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* all: freeze net/rpc and reword the 'frozen' message in other frozen packagesRob Pike2016-10-261-0/+2
| | | | | | | | | | Make the messages grammatically korrect and consistent. Fixes #16844 Change-Id: I7c137b4dc25c0c875ed07b0c64c67ae984c39cbc Reviewed-on: https://go-review.googlesource.com/32112 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* net/rpc: add missing import to rpc server documentationAlex Carol2016-10-161-0/+2
| | | | | | Change-Id: Idca6115181960eed7a955027ee77a02decb4e7f2 Reviewed-on: https://go-review.googlesource.com/31179 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* net/rpc: Add documentation for client.CloseSam Whited2016-09-251-0/+2
| | | | | | | | Fixes #16678 Change-Id: I48c2825d4fef55a75d2f99640a7079c56fce39db Reviewed-on: https://go-review.googlesource.com/28370 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* net/rpc: don't assume b.N > 0Marcel van Lohuizen2016-03-181-0/+3
| | | | | | Change-Id: I58c4a75168fd1f797a25735c4151f501f0475332 Reviewed-on: https://go-review.googlesource.com/20854 Reviewed-by: Russ Cox <rsc@golang.org>
* all: single space after period.Brad Fitzpatrick2016-03-023-15/+15
| | | | | | | | | | | | | | | | | | | | The tree's pretty inconsistent about single space vs double space after a period in documentation. Make it consistently a single space, per earlier decisions. This means contributors won't be confused by misleading precedence. This CL doesn't use go/doc to parse. It only addresses // comments. It was generated with: $ perl -i -npe 's,^(\s*// .+[a-z]\.) +([A-Z]),$1 $2,' $(git grep -l -E '^\s*//(.+\.) +([A-Z])') $ go test go/doc -update Change-Id: Iccdb99c37c797ef1f804a94b22ba5ee4b500c4f7 Reviewed-on: https://go-review.googlesource.com/20022 Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Dave Day <djd@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* all: make copyright headers consistent with one space after periodBrad Fitzpatrick2016-03-013-3/+3
| | | | | | | | | | | | | | | | | | | | | | This is a subset of https://golang.org/cl/20022 with only the copyright header lines, so the next CL will be smaller and more reviewable. Go policy has been single space after periods in comments for some time. The copyright header template at: https://golang.org/doc/contribute.html#copyright also uses a single space. Make them all consistent. Change-Id: Icc26c6b8495c3820da6b171ca96a74701b4a01b0 Reviewed-on: https://go-review.googlesource.com/20111 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
* all: replace strings.Index with strings.Contains where possibleNathan VanBenschoten2016-02-191-2/+2
| | | | | | | Change-Id: Ia613f1c37bfce800ece0533a5326fca91d99a66a Reviewed-on: https://go-review.googlesource.com/18120 Reviewed-by: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org>
* net/rpc: verify that embedding works with changed semanticsMarcel van Lohuizen2015-11-131-0/+24
| | | | | | | | | | Exported methods of unexported embedded structs get added correctly to the pool. Behavior is unchanged before and after https://golang.org/cl/14085. Change-Id: I2b4053bab02ff045f0a4577b8114808a60aae27e Reviewed-on: https://go-review.googlesource.com/16305 Reviewed-by: Russ Cox <rsc@golang.org>
* net/rpc: don't exit if Accept gets an errorRob Pike2015-09-032-3/+18
| | | | | | | | | | | | | | | | The default implementation of Accept, which spins up a new server for every new connection, calls log.Fatal if the listener is closed, stopping any outstanding work. Change that to a non-fatal log call so work can continue. There is no programmatic signaling of the problem, just the log, but that should be enough. Fixes #11221. Change-Id: I7c7f6164a0a0143236729eb778d7638c51c34ed1 Reviewed-on: https://go-review.googlesource.com/14185 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* all: link to https instead of httpBrad Fitzpatrick2015-07-111-1/+1
| | | | | | | | | | | | | The one in misc/makerelease/makerelease.go is particularly bad and probably warrants rotating our keys. I didn't update old weekly notes, and reverted some changes involving test code for now, since we're late in the Go 1.5 freeze. Otherwise, the rest are all auto-generated changes, and all manually reviewed. Change-Id: Ia2753576ab5d64826a167d259f48a2f50508792d Reviewed-on: https://go-review.googlesource.com/12048 Reviewed-by: Rob Pike <r@golang.org>
* net/rpc: document that the type must be exported, not just the methodsRob Pike2015-04-081-1/+2
| | | | | | | | Fixes #10379. Change-Id: Ia4cdda36ed57a06371f9ace7365ce9e215228487 Reviewed-on: https://go-review.googlesource.com/8654 Reviewed-by: Rob Pike <r@golang.org>
* net/rpc: fix mutex commentRob Pike2014-10-131-6/+6
| | | | | | | | | Fixes #8086. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/153420044
* net/rpc: fix buildDavid du Colombier2014-10-091-0/+1
| | | | | | | LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://golang.org/cl/151620043
* net/rpc: skip TestGobError on Plan 9David du Colombier2014-10-091-0/+3
| | | | | | | LGTM=bradfitz R=rsc, bradfitz CC=aram, golang-codereviews https://golang.org/cl/154140043
* net/rpc: listen on localhost, let kernel pick portRuss Cox2014-10-071-2/+2
| | | | | | | | | | This avoids a pop-up box on OS X and it avoids a test failure if something is using 5555. I apologize for not noticing this during the review. TBR=r CC=golang-codereviews https://golang.org/cl/152320044
* net/rpc: add test for issue 7689 (gob error should cause EOF)Rob Pike2014-10-071-0/+51
| | | | | | | | | Helpfully supplied by tommi.virtanen in issue 8173. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/151370043
* net/rpc: shut down connection if gob has errorRob Pike2014-10-011-1/+24
| | | | | | | | | | | | | The nicest solution would be to buffer the message and only write it if it encodes correctly, but that adds considerable memory and CPU overhead for a very rare condition. Instead, we just shut down the connection if this happens. Fixes #7689. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/146670043
* build: move package sources from src/pkg to srcRuss Cox2014-09-088-0/+2368
Preparation was in CL 134570043. This CL contains only the effect of 'hg mv src/pkg/* src'. For more about the move, see golang.org/s/go14nopkg.
View Lorry Controller Status