summaryrefslogtreecommitdiff
path: root/doc/contribute.html
Commit message (Collapse)AuthorAgeFilesLines
* doc: fix path to make.bashMichał Łowicki2020-03-291-1/+1
| | | | | | Change-Id: I78c7197b8b93590470a782b492bba177a14d80ec Reviewed-on: https://go-review.googlesource.com/c/go/+/226340 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: decrease prominence of GOROOT_BOOTSTRAPGiovanni Bajo2020-03-281-3/+1
| | | | | | | | | | | | | | | | | | | | | | | Go build scripts on UNIX (make.bash, all.bash) have not required GOROOT_BOOTSTRAP since August 2017 (CL 57753). Windows build scripts have followed suit since CL 96455. Most people building Go will have a Go toolchain in their PATH and will not need to specify a different toolchain. This CL removes the GOROOT_BOOTSTRAP mention from the contribution guide (it was there for Windows only, but it's not required anymore). The guide is meant to be light and clear for beginners and is not supposed to be a reference, so there's not need to keep mentioning GOROOT_BOOTSTRAP. Also update install-source.html to reflect the current status quo, where using the PATH is probably the first and most used default, and GOROOT_BOOTSTRAP is just an option. Change-Id: Iab453e61b0c749c256aaaf81ea9b2ae58822cb89 Reviewed-on: https://go-review.googlesource.com/c/go/+/224717 Run-TryBot: Giovanni Bajo <rasky@develer.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
* doc: 2020 is the Year of the GopherDmitri Shuralyov2020-01-021-2/+2
| | | | | | | | | | | | | | | | | Starting with 2014 (golang.org/cl/46660043), we have enjoyed 6 consecutive years of the gopher. Now, the slice¹ of gophers is ready to make its way into the next decade, as 2020 is the new Year of the Gopher. ¹ https://en.wikipedia.org/w/index.php?title=List_of_English_terms_of_venery,_by_animal&oldid=932675028#G Change-Id: I5f9598dbedb373bd13021964193fa9e44c67693e Reviewed-on: https://go-review.googlesource.com/c/go/+/213017 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: David Symonds <dsymonds@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: use <code> for a few file paths that didn'tDaniel Martí2019-07-271-3/+4
| | | | | | | | Spotted while seeing CL 187818 in master. Change-Id: Ic3f42558f6833fc35580b2b2a15f2c5aba5713c0 Reviewed-on: https://go-review.googlesource.com/c/go/+/187822 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: mention that GOPATH/bin should be in PATHGiovanni Bajo2019-07-271-1/+2
| | | | | | | | | | | As noticed while mentoring at Gophercon, a common mistake for beginners is that, after they install git-codereview, it's not found by git because they haven't put GOPATH/bin in their environment. Change-Id: I885cee0f532a4069d1a17ea27365d54965ecca22 Reviewed-on: https://go-review.googlesource.com/c/go/+/187818 Reviewed-by: Katie Hockman <katie@golang.org>
* doc: fix missing anchor links in contribute.htmlAgniva De Sarker2019-06-041-6/+6
| | | | | | | | | | | Some <h3>s were missing ids due to which the anchor links weren't getting generated. Fixes #32415 Change-Id: Ica21425c1a7c49735231c1de96b6c77dd594ce64 Reviewed-on: https://go-review.googlesource.com/c/go/+/180397 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: update wording in contribution guideBenny Siegert2019-04-231-1/+2
| | | | | | | | | The top right menu in Gerrit is now a gear icon, and the link has a slightly different title. Change-Id: I3f5d194f31ad09a99416a45db392aa4b5c7d98ff Reviewed-on: https://go-review.googlesource.com/c/go/+/173400 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: 2019 is the Year of the GopherJosh Bleecher Snyder2019-01-011-2/+2
| | | | | | | | | | | | whereas this is a longstanding tradition and insofaras it is worth continuing such traditions and notwithstanding an attempt at future-proofing thetruthofthematter is that I have been waiting for years to send this change so despiteallobjections I have updated the copyright year. Change-Id: I55961b15a7eda35d84fdd9250afdbe19f0bf8412 Reviewed-on: https://go-review.googlesource.com/c/155928 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
* doc: improve language in contributetkivisik2018-11-011-2/+2
| | | | | | | | | | Previous wording was incorrect. Change-Id: I91406c775161d9724ec60824c156e8e9a925bcd7 GitHub-Last-Rev: 2b6b4e136a78a431cc847a2717cbeae4341ed7bc GitHub-Pull-Request: golang/go#28248 Reviewed-on: https://go-review.googlesource.com/c/142879 Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
* doc: recommend benchstat for performance commitsRhys Hiltner2018-08-311-1/+1
| | | | | | | | | | | The benchstat tool computes statistics about benchmarks, including whether any differences are statistically significant. Recommend its use in commit messages of performance-related changes rather than the simpler benchcmp tool. Change-Id: I4b35c2d892b48e60c3064489b035774792c19c30 Reviewed-on: https://go-review.googlesource.com/132515 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: remove mentions of cloning from GitHubGiovanni Bajo2018-08-211-4/+3
| | | | | | | | | Complete CL117178 removing all references to GitHub, and leaving a small note to make sure we remember that it's not supported. Change-Id: Id4257515a864875808fa7a67f002ed52cfd635a3 Reviewed-on: https://go-review.googlesource.com/130395 Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
* doc/contribute: add examples for finding issues on the issue trackerLeigh McCulloch2018-08-081-0/+19
| | | | | | | | | | | | | | | | | | | For contributors looking for new issues to contribute to it can be difficult to find issues that need a fix and don't already have a fix being considered. There are several labels that help guide the way already, like `NeedsFix`, `HelpWanted`. But many issues with this label will already have a CL. For new contributors this can be especially difficult. Fixes #26494 Change-Id: Ifd38ea65e362b4c580207a06f959646e49ac594f GitHub-Last-Rev: 6d2b54447b2ee754a6d025f5de3ebd8326e035eb GitHub-Pull-Request: golang/go#26516 Reviewed-on: https://go-review.googlesource.com/125355 Reviewed-by: Andrew Bonventre <andybons@golang.org> Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* doc: fix link in contribute.htmlMohit kumar Bajoria2018-07-311-1/+1
| | | | | | | | | | Fixes #26611 Change-Id: I111152c7b1156a461c9ddeaf16d2fe7a2d5a00c1 GitHub-Last-Rev: 72090d539b5601b8c585628a11a99b03103d5a75 GitHub-Pull-Request: golang/go#26724 Reviewed-on: https://go-review.googlesource.com/126935 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc/contribute: fix typo and reword a few sentencesAlberto Donizetti2018-06-241-22/+25
| | | | | | | | | This change fixes a typo in doc/contribute.html (afects -> affects) and rewords a few slightly akward sentences. Change-Id: I6bfbacba0de29464fce134b0fdaf3898a97b8d57 Reviewed-on: https://go-review.googlesource.com/120105 Reviewed-by: Rob Pike <r@golang.org>
* doc: fix spelling of G SuiteStephen Lewis2018-06-201-2/+2
| | | | | | | | | 'G Suite' seems to be the preferred spelling according to https://gsuite.google.com/ Change-Id: Ica60938cf942594157bba84ef205e1cdcb8c1b08 Reviewed-on: https://go-review.googlesource.com/120132 Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
* doc: change git clone urlWayne Ashley Berry2018-06-201-2/+2
| | | | | | | | | | | | The git clone url should be a Gerrit host and not Github, otherwise the codereview command will fail. git-codereview: failed to load Gerrit origin: git origin must be a Gerrit host, not GitHub: https://github.com/golang/go Change-Id: I62f62c86ee6dce0720a844fc56340135dfae8405 Reviewed-on: https://go-review.googlesource.com/117178 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: use HTTPS for linksSuriyaa Sundararuban2018-06-131-1/+1
| | | | | | Change-Id: I9d2d25df067ca573589db5ff18296a5ec33866be Reviewed-on: https://go-review.googlesource.com/118595 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc/contribute.html: add whitespace after <code> blocks, where missingDave Russell2018-06-131-3/+3
| | | | | | | | Change-Id: Iea5c705dd58f9b83fbeb0500defcc08c34716169 GitHub-Last-Rev: 35702c784e2329fe3e44947430d246f8cdb04645 GitHub-Pull-Request: golang/go#25858 Reviewed-on: https://go-review.googlesource.com/118536 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc/contribute.html: remove superfluous articleTobias Klauser2018-05-161-1/+1
| | | | | | | | After CL 113016 the "a" article is no longer necessary. Change-Id: I5a80a210bd2b9eedd73d5f9f3f338d7f22c29ea6 Reviewed-on: https://go-review.googlesource.com/113355 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc/contribute.html: English cleanupsRob Pike2018-05-151-204/+233
| | | | | | | | Fixes #24487 Change-Id: Ic523e469f7f67f376edd2fca6e07d35bb11b2db9 Reviewed-on: https://go-review.googlesource.com/113016 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc/contribute.html: clean up HTML and formattingRob Pike2018-05-141-141/+241
| | | | | | | | | | | | | | | | | Mostly just formatting and minor cleanup: - regularize HTML (add </p> etc.) - remove all errors caught by tidy - start all sentences on new line for easy editing Some wording changes, but there will be more to come. It seemed there were already enough edits to send it out. Update #24487 Change-Id: I613ce206b1e8e3e522ecb0bbcd2acb11c4ff5bae Reviewed-on: https://go-review.googlesource.com/113015 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc/contribute.html: adjust wording from previous CLRob Pike2018-04-161-3/+3
| | | | | | | | | | | | | The previous CL, 107197, overclarified the need for short subject lines. Tweak the wording to be a guideline (keep it short) rather than a limit (76 characters), which is more the Go way. Also be strict about avoiding markup language. Change-Id: I0da1132db8d86052647d96f1caac60289f2209ce Reviewed-on: https://go-review.googlesource.com/107378 Reviewed-by: Mohit Bajoria <mohitbajo36@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: improve commit messagesmbj362018-04-161-6/+3
| | | | | | | | | Fixes #24852 Change-Id: I71d0d7f75108bf4ad606733a45bb71baa66a4e91 Reviewed-on: https://go-review.googlesource.com/107197 Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com> Reviewed-by: Giovanni Bajo <rasky@develer.com>
* doc: first version of new contribute guideGiovanni Bajo2018-03-221-487/+655
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've reorganized the guide and rewritten large sections. The structure is now more clear and logical, and can be understood and navigated using the summary displayed at the top of the page (before, the summary was confusing because the guide contained H1s that were being ignored by the summary). Both the initial onboarding process and the Gerrit change submission process have been reworked to include a concise checklist of steps that can be read and understood in a few seconds, for people that don't want or need to bother with details. More in-depth descriptions have been moved into separate sections, one per each checklist step. This is by far the biggest improvement, as the previous approach of having to read several pages just to understand the requires steps was very scaring for beginners, in addition of being harder to navigate. GitHub pull requests have been integrated as a different way to submit a change, suggested for first time contributors. The review process has been described in more details, documenting the workflow and the used conventions. Most miscellanea have been moved into an "advanced topics" chapter. Paragraphs describing how to use git have been removed to simplify reading. This guide should focus on Go contribution, and not help users getting familiar with git, for which many guides are available. Change-Id: I6f4b76583c9878b230ba1d0225745a1708fad2e8 Reviewed-on: https://go-review.googlesource.com/93495 Reviewed-by: Rob Pike <r@golang.org>
* doc: fix the closing tag in contribute.htmlMohit Agarwal2018-01-291-1/+1
| | | | | | Change-Id: I802bc11d90d414e7313dd11842a04fd6b591ea06 Reviewed-on: https://go-review.googlesource.com/90595 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: 2018 is the Year of the GopherBrad Fitzpatrick2018-01-011-1/+1
| | | | | | Change-Id: Ie167512e000f3a8be0ff8a6a9edd52bd74f45115 Reviewed-on: https://go-review.googlesource.com/85775 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
* doc: fix two spelling mistakes in contribute.htmlAlberto Donizetti2017-12-061-2/+2
| | | | | | Change-Id: Ife60468d508f90321733ebdbdb0e6cf443ba1659 Reviewed-on: https://go-review.googlesource.com/82156 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: move single change workflow note in contribution guideLeigh McCulloch2017-11-291-6/+6
| | | | | | | | | | | The note about the single change workflow is included in the git-codereview installation instructions, but it has nothing to do with installing git-codereview. This note is more relevant for when a change is actually being made. Change-Id: Iccb90f3b7da87fab863fa4808438cd69a21a2fce Reviewed-on: https://go-review.googlesource.com/76317 Reviewed-by: Steve Francia <spf@golang.org>
* doc: mention the scratch repoKevin Burke2017-11-131-0/+9
| | | | | | | | | | | | | | | | | If people are interested in contributing to Go, but not sure what change they'd like to make just yet, we can point them to the scratch repo, so they can go through the process of submitting and merging something now, and make more useful contributions later. My evidence that sending people to the scratch repo would encourage future contributions is that a number of people who went through the workshop at Gophercon have continued to send CL's after submitting to the scratch repo, even though I doubt they planned to before going through the workshop. Change-Id: Ieb48415773c0ee7dc400f8bf6f57f752eca8eeb5 Reviewed-on: https://go-review.googlesource.com/49970 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: update contribute.html to clarify replying to reviews via emailAndrew Bonventre2017-10-041-4/+4
| | | | | | | | | Update golang/go#22120 Change-Id: Ie7dbd0e7b01b116c960243a8cd3fa9fd121f317d Reviewed-on: https://go-review.googlesource.com/68021 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Dave Cheney <dave@cheney.net>
* doc/contribute: improve wording of Gerrit descriptionChristian Alexander2017-08-091-1/+1
| | | | | | | | The word "of" was removed in https://go-review.googlesource.com/c/36626 Change-Id: Iece69f425d06ab1cf02743b1033cfed2e96667ab Reviewed-on: https://go-review.googlesource.com/54290 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc/contribute.html: fix name of .gitcookies fileRaviTeja2017-08-091-1/+1
| | | | | | Change-Id: I41c22b9c6933b3f3469c0e815048a49e1d37927a Reviewed-on: https://go-review.googlesource.com/54190 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc/contribute: avoid using the word "change list".Han-Wen Nienhuys2017-07-141-3/+3
| | | | | | | | Neither the Gerrit UI nor its docs use the term CL or changelist. Change-Id: Ic19fddc660ec4f008f10fd207e4ac6349431ff5d Reviewed-on: https://go-review.googlesource.com/48595 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: add go-contrib-init mention to contributing docsBrad Fitzpatrick2017-06-141-0/+19
| | | | | | | | Fixes #17802 Change-Id: I245552534c3e21d95c569ac7118ba289244ba11d Reviewed-on: https://go-review.googlesource.com/45652 Reviewed-by: Steve Francia <spf@golang.org>
* doc: fix minor formatting issues in contribute.htmlAdam Bender2017-05-041-7/+8
| | | | | | | | | - remove <code> from <pre> - replace `` with <code></code> Change-Id: I46f0aec8b7645e2ac8cb53bca73aed55441acd65 Reviewed-on: https://go-review.googlesource.com/42612 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc/contribute: directly link to the Agreements pageAlberto Donizetti2017-05-021-4/+4
| | | | | | | | | | | | There's no Settings->Agreement path for PolyGerrit users, but if we link directly to the page in the instructions, Gerrit will inform them that they can access the page by switching to the old UI. Fixes #20207 Change-Id: I0887ee854e4ac5975b5f305adb6259b81b41618f Reviewed-on: https://go-review.googlesource.com/42412 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: reorganize the contribution guidelines into a guideSteve Francia2017-03-161-184/+343
| | | | | | | | | Updates #17802 Change-Id: I65ea0f4cde973604c04051e7eb25d12e4facecd3 Reviewed-on: https://go-review.googlesource.com/36626 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Chris Broadfoot <cbro@golang.org>
* doc: remove the confusing use of CLJaana Burcu Dogan2017-02-081-1/+1
| | | | | | | | | | | | CL (change list) pops out of nowhere and confuses the reader. Use "change" instead to be consistent with the rest of the document. Fixes #18989. Change-Id: I525a63a195dc6bb992c8ad0f10c2f2e1b2b952df Reviewed-on: https://go-review.googlesource.com/36564 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: 2017 is the Year of the GopherBrad Fitzpatrick2017-01-161-1/+1
| | | | | | | | Change-Id: Iac713ae1f322f893c92b3fc47fe9b5719052f9eb Reviewed-on: https://go-review.googlesource.com/35240 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: David Symonds <dsymonds@golang.org> Reviewed-by: Minux Ma <minux@golang.org>
* doc: add notes on good commit messagesJeff R. Allen2016-05-241-3/+6
| | | | | | | | | | | | Explain Brad's algorithm for generating commit headlines. Fixes #15700 Change-Id: Ic602f17629b3dd7675e2bb1ed119062c03353ee9 Reviewed-on: https://go-review.googlesource.com/23355 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* doc: mention security from contribution guidelinesFrancesc Campoy2016-04-231-0/+4
| | | | | | | | Fixes #15413 Change-Id: I837a391276eed565cf66d3715ec68b7b959ce143 Reviewed-on: https://go-review.googlesource.com/22390 Reviewed-by: Andrew Gerrand <adg@golang.org>
* doc: fix bogus HTML in contribute.htmlBrad Fitzpatrick2016-03-091-1/+1
| | | | | | | | Introduced in https://golang.org/cl/20462 Change-Id: I6c55f87228f0980058a10f204b57ead7594e3492 Reviewed-on: https://go-review.googlesource.com/20490 Reviewed-by: Andrew Gerrand <adg@golang.org>
* doc: use new Gerrit URL and mention our instance in CONTRIBUTING.mdAndrew Gerrand2016-03-091-1/+1
| | | | | | | | Fixes #14662 Change-Id: I8f7d5e8d2dd8dc763e940e061b424427359246e7 Reviewed-on: https://go-review.googlesource.com/20462 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: mention multi-change branches in contribute.htmlRuss Cox2016-02-171-2/+12
| | | | | | | | | Fixes #13651. Change-Id: I1d21b49e2b5bc6c507eb084d6d2553e5a9c607cf Reviewed-on: https://go-review.googlesource.com/19552 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Chris Broadfoot <cbro@golang.org>
* doc: discuss copyright changes in contribute.htmlRuss Cox2016-01-061-15/+22
| | | | | | | | Fixes #12542. Change-Id: Icd0fa84d891d6b1feab9b4d4dd319cdf1e6d6c48 Reviewed-on: https://go-review.googlesource.com/18336 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* doc: 2016 is the Year of the Gopher.David Symonds2015-12-311-1/+1
| | | | | | | | | Change-Id: I85caba8c743dcd82954de75df947053b3d206bdc Reviewed-on: https://go-review.googlesource.com/18117 Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
* doc: fix typo in contributing guideKatrina Owen2015-10-061-1/+1
| | | | | | Change-Id: I6d9a8886cccf1c396ea2dbc659c5bf7548179751 Reviewed-on: https://go-review.googlesource.com/15435 Reviewed-by: Ian Lance Taylor <iant@golang.org>
* doc: link to the release cycle from contribute.htmlCaleb Spare2015-08-041-0/+8
| | | | | | Change-Id: Ia5d41b66006682084fcbfac3da020946ea3dd116 Reviewed-on: https://go-review.googlesource.com/13093 Reviewed-by: Andrew Gerrand <adg@golang.org>
* doc: Mention contributor agreement immediately after GerritAndy Maloney2015-08-041-25/+36
| | | | | | | | | | | | | | | | I walked through the steps for a contribution but ended up with an error when doing "git mail" because I didn't have a signed agreement. Added a section to check for or create one through Gerrit right after the user has created the account and logged in. Moved some info from copyright section to the new section. Change-Id: I79bbd3e18fc3a742fa59a242085da14be9e19ba0 Reviewed-on: https://go-review.googlesource.com/13062 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Andrew Gerrand <adg@golang.org>
* doc: link to proposal process from contribution guidelinesAndrew Gerrand2015-08-031-11/+12
| | | | | | | Change-Id: I992cb1afeef498353d529238e508fa438d6c069c Reviewed-on: https://go-review.googlesource.com/12912 Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Rob Pike <r@golang.org>
View Lorry Controller Status