diff options
| author | Keith Randall <khr@golang.org> | 2014-12-10 17:02:58 -0800 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2014-12-22 22:41:01 +0000 |
| commit | cda0ea1c0e06d1309f66423a8fd72e272d089b6c (patch) | |
| tree | 5720fe98083a2945524142f33a9c6720eea19221 /src/runtime/unaligned1.go | |
| parent | fbc56cf05015899aba236d5a68096a770de3ad0a (diff) | |
| download | go-git-cda0ea1c0e06d1309f66423a8fd72e272d089b6c.tar.gz | |
runtime: a better fallback hash
For arm and powerpc, as well as x86 without aes instructions.
Contains a mixture of ideas from cityhash and xxhash.
Compared to our old fallback on ARM, it's ~no slower on
small objects and up to ~50% faster on large objects. More
importantly, it is a much better hash function and thus has
less chance of bad behavior.
Fixes #8737
benchmark old ns/op new ns/op delta
BenchmarkHash5 173 181 +4.62%
BenchmarkHash16 252 212 -15.87%
BenchmarkHash64 575 419 -27.13%
BenchmarkHash1024 7173 3995 -44.31%
BenchmarkHash65536 516940 313173 -39.42%
BenchmarkHashStringSpeed 300 279 -7.00%
BenchmarkHashBytesSpeed 478 424 -11.30%
BenchmarkHashInt32Speed 217 207 -4.61%
BenchmarkHashInt64Speed 262 231 -11.83%
BenchmarkHashStringArraySpeed 609 631 +3.61%
Change-Id: I0a9335028f32b10ad484966e3019987973afd3eb
Reviewed-on: https://go-review.googlesource.com/1360
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/runtime/unaligned1.go')
| -rw-r--r-- | src/runtime/unaligned1.go | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/src/runtime/unaligned1.go b/src/runtime/unaligned1.go new file mode 100644 index 0000000000..0a88ff2029 --- /dev/null +++ b/src/runtime/unaligned1.go @@ -0,0 +1,17 @@ +// Copyright 2014 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// +build 386 amd64 amd64p32 + +package runtime + +import "unsafe" + +func readUnaligned32(p unsafe.Pointer) uint32 { + return *(*uint32)(p) +} + +func readUnaligned64(p unsafe.Pointer) uint64 { + return *(*uint64)(p) +} |
