summaryrefslogtreecommitdiff
path: root/src/cmd/trace/trace_unix_test.go
diff options
context:
space:
mode:
authorPeter Weinberger <pjw@google.com>2018-10-29 10:18:05 -0400
committerPeter Weinberger <pjw@google.com>2018-10-30 16:43:38 +0000
commit08816cb8d7ed16b9c804587ff02c1ad1c3af6cd5 (patch)
tree1951b6cd86b05ed0faa4dfc99e17592997b661f9 /src/cmd/trace/trace_unix_test.go
parentf570b54cc02ffeb82e35e72fc818916e8b896c67 (diff)
downloadgo-git-08816cb8d7ed16b9c804587ff02c1ad1c3af6cd5.tar.gz
cmd/trace: use new traceparser to parse the raw trace files
Change-Id: I8b224ae48a2f8acd5a64c9ff283e97821479a9a8 Reviewed-on: https://go-review.googlesource.com/c/145457 Run-TryBot: Peter Weinberger <pjw@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Diffstat (limited to 'src/cmd/trace/trace_unix_test.go')
-rw-r--r--src/cmd/trace/trace_unix_test.go12
1 files changed, 5 insertions, 7 deletions
diff --git a/src/cmd/trace/trace_unix_test.go b/src/cmd/trace/trace_unix_test.go
index fec060e121..144642ad9e 100644
--- a/src/cmd/trace/trace_unix_test.go
+++ b/src/cmd/trace/trace_unix_test.go
@@ -8,7 +8,7 @@ package main
import (
"bytes"
- traceparser "internal/trace"
+ "internal/traceparser"
"io/ioutil"
"runtime"
"runtime/trace"
@@ -73,17 +73,15 @@ func TestGoroutineInSyscall(t *testing.T) {
}
trace.Stop()
- res, err := traceparser.Parse(buf, "")
- if err == traceparser.ErrTimeOrder {
- t.Skipf("skipping due to golang.org/issue/16755 (timestamps are unreliable): %v", err)
- } else if err != nil {
+ res, err := traceparser.ParseBuffer(buf)
+ if err != nil {
t.Fatalf("failed to parse trace: %v", err)
}
// Check only one thread for the pipe read goroutine is
// considered in-syscall.
c := viewerDataTraceConsumer(ioutil.Discard, 0, 1<<63-1)
- c.consumeViewerEvent = func(ev *ViewerEvent, _ bool) {
+ c.consumeViewerEvent = func(ev *viewerEvent, _ bool) {
if ev.Name == "Threads" {
arg := ev.Arg.(*threadCountersArg)
if arg.InSyscall > 1 {
@@ -96,7 +94,7 @@ func TestGoroutineInSyscall(t *testing.T) {
parsed: res,
endTime: int64(1<<63 - 1),
}
- if err := generateTrace(param, c); err != nil {
+ if err := generateTrace(res, param, c); err != nil {
t.Fatalf("failed to generate ViewerData: %v", err)
}
}