diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2021-01-05 06:43:38 -0800 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2021-01-05 15:42:33 +0000 |
| commit | 77365c5ed739f4882020ff76b2a4f5bfe4e8fc9d (patch) | |
| tree | 87e2eb4333d040e79d81241a6d6540b9e4a907aa /src/cmd/compile/internal/ir/expr.go | |
| parent | e09783cbc0a7142719c6210b4eda7b21daad91d5 (diff) | |
| download | go-git-77365c5ed739f4882020ff76b2a4f5bfe4e8fc9d.tar.gz | |
[dev.regabi] cmd/compile: add Name.Canonical and move Byval
There's a bunch of code that wants to map closure variables back to
their original name, so add a single Name.Canonical method that they
can all use.
Also, move the Byval flag from being stored on individual closure
variables to being stored on the canonical variable.
Passes toolstash -cmp.
Change-Id: Ia3ef81af5a15783d09f04b4e274ce33df94518e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/281541
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Diffstat (limited to 'src/cmd/compile/internal/ir/expr.go')
| -rw-r--r-- | src/cmd/compile/internal/ir/expr.go | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/cmd/compile/internal/ir/expr.go b/src/cmd/compile/internal/ir/expr.go index 77b6c8a103..e7aa9c6a8f 100644 --- a/src/cmd/compile/internal/ir/expr.go +++ b/src/cmd/compile/internal/ir/expr.go @@ -829,14 +829,9 @@ func reassigned(name *Name) bool { // reassignment detection for use by inlining and devirtualization. // isName reports whether n is a reference to name. - isName := func(n Node) bool { - if n, ok := n.(*Name); ok && n.Op() == ONAME { - if n.IsClosureVar() && n.Defn != nil { - n = n.Defn.(*Name) - } - return n == name - } - return false + isName := func(x Node) bool { + n, ok := x.(*Name) + return ok && n.Canonical() == name } var do func(n Node) bool |