diff options
author | Nikos Mavrogiannopoulos <nmav@redhat.com> | 2017-06-19 15:18:20 +0200 |
---|---|---|
committer | Nikos Mavrogiannopoulos <nmav@redhat.com> | 2017-07-13 14:48:08 +0200 |
commit | 871956ace6bcefb561ac00056118bb2ff4786d1d (patch) | |
tree | 6538d85a1381f19918f50f1a5631612eebfc597f /lib/str.c | |
parent | a37b69495ba411635f9691538a2bd6b02fc5439b (diff) | |
download | gnutls-871956ace6bcefb561ac00056118bb2ff4786d1d.tar.gz |
_gnutls_buffer_append_data_prefix: cleanup
This eliminates a misleading code that assumed that the called functions
will return the appended size. Always return zero on success which is
what the existing callers assume.
Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
Diffstat (limited to 'lib/str.c')
-rw-r--r-- | lib/str.c | 11 |
1 files changed, 5 insertions, 6 deletions
@@ -831,20 +831,19 @@ _gnutls_buffer_append_data_prefix(gnutls_buffer_st * buf, int pfx_size, const void *data, size_t data_size) { - int ret = 0, ret1; + int ret; - ret1 = _gnutls_buffer_append_prefix(buf, pfx_size, data_size); - if (ret1 < 0) - return gnutls_assert_val(ret1); + ret = _gnutls_buffer_append_prefix(buf, pfx_size, data_size); + if (ret < 0) + return gnutls_assert_val(ret); if (data_size > 0) { ret = _gnutls_buffer_append_data(buf, data, data_size); - if (ret < 0) return gnutls_assert_val(ret); } - return ret + ret1; + return 0; } int _gnutls_buffer_append_mpi(gnutls_buffer_st * buf, int pfx_size, |