gnutlsxx: dh_params, rsa_params: actually assign values in operator=

The previous implementation assigned the value to a temporary variable
and then return it without assigning it to 'this'.  That is not only
contradictory to user's expectation but also cppcheck treats it as a
logic error.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

1 files changed, 8 insertions, 2 deletions

diff --git a/lib/gnutlsxx.cpp b/lib/gnutlsxx.cpp
index ea1632174b..3613502aba 100644
--- a/lib/gnutlsxx.cpp
+++ b/lib/gnutlsxx.cpp
@@ -950,7 +950,10 @@ psk_server_credentials::psk_server_credentials ():credentials
         throw (exception (ret));
       }
 
-    return *dst;
+    std::swap (this->params, dst->params);
+    delete dst;
+
+    return *this;
   }
 
 // RSA
@@ -1003,7 +1006,10 @@ psk_server_credentials::psk_server_credentials ():credentials
         throw (exception (ret));
       }
 
-    return *dst;
+    std::swap (this->params, dst->params);
+    delete dst;
+
+    return *this;
   }
 
   void rsa_params::import_raw (const gnutls_datum_t & m,