summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaciej S. Szmigiero <mail@maciej.szmigiero.name>2019-03-28 23:04:13 +0100
committerNikos Mavrogiannopoulos <nmav@gnutls.org>2019-04-05 18:19:50 +0200
commit18c85a9aca99080403a4fc2583fbb4302c3979e6 (patch)
tree77ca5eb4159a81a3234c7b30db2a72331bdc0a58
parent29e66d5a4160ab309870df34e85c06df6fc867c6 (diff)
downloadgnutls-18c85a9aca99080403a4fc2583fbb4302c3979e6.tar.gz
gnutls_memset(): calling explicit_bzero() is enough to zero-fill a buffer
If we use explicit_bzero() to zero-fill a buffer in gnutls_memset() we don't need to zero it again via a volatile trick later in this function. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
-rw-r--r--lib/safe-memfuncs.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/safe-memfuncs.c b/lib/safe-memfuncs.c
index a9db39d2a7..b957b432cd 100644
--- a/lib/safe-memfuncs.c
+++ b/lib/safe-memfuncs.c
@@ -39,6 +39,7 @@ void gnutls_memset(void *data, int c, size_t size)
#ifdef HAVE_EXPLICIT_BZERO
if (c == 0) {
explicit_bzero(data, size);
+ return;
}
#endif
volatile_zero = 0;