summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniele Nicolodi <daniele@grinta.net>2021-05-02 12:29:51 +0200
committerDaniele Nicolodi <daniele@grinta.net>2021-05-08 18:30:39 +0200
commit66c9c400b2227d2926d8eb13de006001942b75d8 (patch)
treefdd25fb9a0863c2831194498f41b12adc5125d5b
parent475914cade9a1d3973fe5e7d8c9916092327f464 (diff)
downloadtracker-66c9c400b2227d2926d8eb13de006001942b75d8.tar.gz
tracker-sparql: Simplify and fix signed vs unsigned comparison
-rw-r--r--src/libtracker-sparql/tracker-endpoint-http.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/libtracker-sparql/tracker-endpoint-http.c b/src/libtracker-sparql/tracker-endpoint-http.c
index 5aa82b03d..bf28329f2 100644
--- a/src/libtracker-sparql/tracker-endpoint-http.c
+++ b/src/libtracker-sparql/tracker-endpoint-http.c
@@ -89,7 +89,6 @@ handle_request_in_thread (GTask *task,
{
Request *request = task_data;
gchar *buffer[1000];
- gboolean finished = FALSE;
SoupMessageBody *message_body;
GError *error = NULL;
gssize count;
@@ -100,20 +99,22 @@ handle_request_in_thread (GTask *task,
message_body = request->message->response_body;
#endif
- while (!finished) {
+ for (;;) {
count = g_input_stream_read (request->istream,
buffer, sizeof (buffer),
cancellable, &error);
- if (count == -1) {
+ if (count < 0) {
g_task_return_error (task, error);
break;
- } else if (count < sizeof (buffer)) {
- finished = TRUE;
}
soup_message_body_append (message_body,
SOUP_MEMORY_COPY,
buffer, count);
+
+ if ((gsize) count < sizeof (buffer)) {
+ break;
+ }
}
g_input_stream_close (request->istream, cancellable, NULL);