summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Hammond <chipx86@chipx86.com>2007-02-15 08:54:39 +0000
committerChristian Hammond <chipx86@chipx86.com>2007-02-15 08:54:39 +0000
commitc0c861e4732b3b0ce8606ab0cc73fc06880f99a1 (patch)
tree37f863fbbfe8e2afa157d9f84c4bbd14f5714935
parentbdf8640cabacb31aaacc8d004f4c49737c85106a (diff)
downloadlibnotify-c0c861e4732b3b0ce8606ab0cc73fc06880f99a1.tar.gz
Fix a bug in notify_notification_add_action where the function to free the user data was never called, causing memory leaks. This fixes bug #119.
-rw-r--r--ChangeLog7
-rw-r--r--docs/reference/tmpl/notification.sgml5
-rw-r--r--libnotify/notification.c1
3 files changed, 13 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index f20c3b7..fe60c54 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+Thu Feb 15 00:52:56 PST 2007 Christian Hammond <chipx86@chipx86.com>
+
+ * libnotify/notification.c:
+ - Fix a bug in notify_notification_add_action where the function
+ to free the user data was never called, causing memory leaks.
+ This fixes bug #119.
+
Mon Nov 13 23:42:07 PST 2006 Christian Hammond <chipx86@chipx86.com>
* tests/Makefile.am:
diff --git a/docs/reference/tmpl/notification.sgml b/docs/reference/tmpl/notification.sgml
index 8e94f86..2d3c3fb 100644
--- a/docs/reference/tmpl/notification.sgml
+++ b/docs/reference/tmpl/notification.sgml
@@ -66,6 +66,11 @@ not be used directly. Use the accessor functions below.
</para>
+<!-- ##### ARG NotifyNotification:status-icon ##### -->
+<para>
+
+</para>
+
<!-- ##### ARG NotifyNotification:summary ##### -->
<para>
diff --git a/libnotify/notification.c b/libnotify/notification.c
index c7c8b24..98773e5 100644
--- a/libnotify/notification.c
+++ b/libnotify/notification.c
@@ -1195,6 +1195,7 @@ notify_notification_add_action(NotifyNotification *notification,
pair = g_new0(CallbackPair, 1);
pair->cb = callback;
pair->user_data = user_data;
+ pair->free_func = free_func;
g_hash_table_insert(priv->action_map, g_strdup(action), pair);
if (notification->priv->has_nondefault_actions &&