| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
That would allow us to add more early exits when debugging, without
making the code more complicated. Also tidy up to not have a "source"
variable that's actually a GList element.
|
| |
|
|
|
|
|
|
|
|
| |
Since commit adc11e54537aff804c6dcd8d26ade0114632157b, it's
impossible to use grilo-test-ui in the Flatpak for another
application, as it tries to request a D-Bus name that it cannot own.
Instead of using our own app-id/D-Bus name, try to own a variant of the
real app's name.
|
|
|
|
|
|
|
|
| |
If the application couldn't own a name on the session bus, then it would
never setup its UI, and view would be a NULL pointer which we'd
dereference, and crash.
Exit early from cleanup function if the view was never setup.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Rawhide is breaking the introspecting build with a permission to read
error.
ldd: error: you do not have read permission for `/builds/victortoso/grilo/_build/tmp-introspectba6itfp6/Grl-0.3'
That is a temporary folder created by meson (0.55.0-2) but I think the
issue is in the new python 3.9. I could not reproduce locally but for
now, let's fix CI for grilo and grilo-plugins (due subprojects)
|
|
|
|
|
|
|
|
|
| |
grl_registry_get_plugins() is supposed to return a GList of GrlPlugin
but sent back a GList of strings when one asked for all the plugins,
as it returned the keys instead of the values from the plugins
hashtable.
Closes: #141
|
|
|
|
|
|
|
|
|
|
|
|
| |
Latest meson is creating a .so.p temporary folder to lua-factory plugin
and current code in grl-registry would try to load all .so* files. This
patch makes sure that it only tries to load files with .so suffix
(actually, G_MODULE_SUFFIX that could be different in other platforms)
Fixes:
Bail out! Grilo-FATAL-WARNING: [registry]
../subprojects/grilo/src/grl-registry.c:1210: Failed to open module:
/builds/victortoso/grilo-plugins/_build/src/lua-factory/libgrlluafactory.so.p: cannot read file data: Is a directory
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is the counterpart of grl_data_set_for_id() for GrlRelatedKeys (see
commit b30608abacd37a4e39d5c5465efc82c566756631).
grl_related_keys_set_for_id() allows keys that aren't registered,
to be registered and set it's value. It simply sets the value
for registered keys.
grl_registry_register_metadata_key_for_type() and
grl_registry_register_or_lookup_metadata_key() need to be updated to
add a new bind_key parameter. For related keys, bind_key parameters is
used to create a relation between the key and bind_key.
|
|
|
|
|
|
|
|
|
|
|
| |
grl_data_set_for_id() and grl_data_new_for_id() share some code to
register or lookup a key by its name.
This shared code is put in a new private function named
grl_registry_register_or_lookup_metadata_key().
grl_registry_register_or_lookup_metadata_key() will be used in the
commit by the new grl_related_keys_set_for_id() function.
|
|
|
|
|
|
|
| |
On 3.22.0, gtk_show_uri has been deprecated in favor of
gtk_show_uri_on_window.
Add a GTK_CHECK_VERSION to prevent depending on a GTK version too
recent. It can be removed after bumping GTK to >= 3.22.0
|
|
|
|
|
| |
It has been deprecated since GTK 3.16. Use gdk_cursor_new_for_display
instead.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This patch makes usage of g_date_time_new_from_iso8601() from GLib
2.56 that returns GDateTime* from ISO 8601 formatted string.
Note that this API supported a little bit more than GLib's as a helper
while developing new plugins thus it makes sense to keep it around.
|
|
|
|
|
|
|
|
| |
Removes the following warning:
> ../libs/pls/grl-pls.c:50:27: warning: extra tokens at end of #ifndef
> directive
> 50 | #ifndef TOTEM_PL_IS_PARSER(x)
> | ^
|
|
|
|
|
|
| |
On 2.62.0 we can use new API and avoid GTimeVal usage in grl-pls.c. As
2.62 is a bit new, wrap the old code to avoid warnings on new builds.
It can be removed after bumping glib to >= 2.62.0
|
|
|
|
|
| |
We can easily replace it with timestamp in seconds for the throttling
feature.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Bumping to make it easier in keeping compatibility with recent APIs
without breaking stable distro releases.
Fedora 31 (last stable): 2.62
Debian 10 (last stable): 2.58
Considering that we just released Grilo 0.3.12, next release can still
be kept under current last stable distros releases.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This fixes a reference counting bug in the bindings.
Closes: #107
|
| |
|
| |
|
| |
|
|
|
|
| |
Close #138
|
| |
|
| |
|
|
|
|
|
|
|
| |
This enables the library to be used when Grilo is embedded as a Meson
subproject.
See: https://gitlab.gnome.org/GNOME/grilo-plugins/merge_requests/68
|
|
|
|
|
|
|
|
| |
The value of meson.source_root() can't be trusted because if we are
embedded via subproject() into a larger project, the source root will
be that of the parent project.
Instead, use a variable to keep track of the toplevel source directory.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Recently, we started prefixing the values of all variables defined in pc files
with `prefix` meson variable. While this works even when `datadir` option is
absolute (supported by some meson forks), it leads to inflexible pc files even
when prefixing is not strictly necessary.
In this commit, we are constructing variables for pkg-config files separately
from paths used for installation, obtaining nice .pc files in the common case,
while still supporting unusual platforms like Nix.
|
| |
|
|
|
|
|
|
|
| |
The generated .pc have been kept essentially identical
to the original ones with the same variables.
To squash warnings the meson_version was also bumped
|
|
|
|
|
|
| |
On Nix, headers, introspection files and vapi files are installed to different
prefix than the library. This makes sure that the correct paths are used, thus
making the build more portable.
|
| |
|
| |
|
| |
|
|
|
|
| |
Small release to fix break of gobject-introspection.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following commit has break gobject-introspection of Grilo after a
comment with a line break was added to deprecate a constant:
608eba2 "core: deprecate mb-album-id metadata-key and related
API" in 2019-07-15 by Victor Toso <me@victortoso.com>
The issue is being tracked at [0] but a simple workaround is to remove
the line break.
[0] https://gitlab.gnome.org/GNOME/gobject-introspection/issues/294
Before this patch, grl-metadata-keys with value from 53 to 62 were
lost in introspection, that is, from GRL_METADATA_KEY_MB_TRACK_ID till
the recent GRL_METADATA_KEY_MB_RELEASE_GROUP_ID
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes incorrectly duplicated keys in grl-core-keys.h which affected
the output of metadata in grl-inspect by removing the C comments prior
to processing the file.
Before:
$ sort grl-core-keys.h | uniq --repeated
"GRL_METADATA_KEY_MB_RELEASE_GROUP_ID",
After:
$ sort grl-core-keys.h | uniq --repeated
$
|
| |
|
| |
|
|
|
|
|
|
| |
Follow up for previous commit, d6fad80 "grl-metadata-key: Add metadata
keys for MB Release ID and MB Release Group ID" in 2019-06-14 by
Sumaid Syed <sumaidsyed@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
A MusicBrainz release represents the unique release (i.e. issuing) of a product on
a specific date with specific release information such as the country, label, barcode
and packaging.
A release group is used to group several different releases into a single
logical entity.
Add Grilo Media support for MusicBrainz release and release group identifiers.
Deprecate use of album identifier since it could mean release or release group id.
https://gitlab.gnome.org/GNOME/grilo/issues/136
|