summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Müllner <fmuellner@gnome.org>2018-08-13 01:25:13 +0200
committerFlorian Müllner <fmuellner@gnome.org>2018-08-13 01:38:33 +0200
commit5b3c50188a670eb090e46927d939b42cd628e739 (patch)
treefa67594267ba03238c9d335c10f044256ebdd32e
parent804f23b1794dcba8d5660a1ae554dcd734d2e2d1 (diff)
downloadgnome-shell-wip/fmuellner/fix-fs-banners.tar.gz
messageTray: Disable unredirection while showing bannerswip/fmuellner/fix-fs-banners
We don't usually show notification banners while the monitor is in fullscreen, but when we do - the notification is urgent - we should actually show the banner, even if the top-most window is unredirected. To achieve that, disable unredirection while the banner is showing. https://gitlab.gnome.org/GNOME/gnome-shell/issues/430
-rw-r--r--js/ui/messageTray.js7
1 files changed, 5 insertions, 2 deletions
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 75740c6c0..20469afb3 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1309,8 +1309,10 @@ var MessageTray = new Lang.Class({
}
this._banner = this._notification.createBanner();
- this._bannerClickedId = this._banner.connect('done-displaying',
- this._escapeTray.bind(this));
+ this._bannerClickedId = this._banner.connect('done-displaying', () => {
+ Meta.enable_unredirect_for_display(global.display);
+ this._escapeTray();
+ });
this._bannerUnfocusedId = this._banner.connect('unfocused', () => {
this._updateState();
});
@@ -1322,6 +1324,7 @@ var MessageTray = new Lang.Class({
this._bannerBin.y = -this._banner.actor.height;
this.actor.show();
+ Meta.disable_unredirect_for_display(global.display);
this._updateShowingNotification();
let [x, y, mods] = global.get_pointer();