summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDebarshi Ray <debarshir@gnome.org>2017-01-05 18:25:33 +0100
committerDebarshi Ray <debarshir@gnome.org>2017-01-06 13:11:07 +0100
commit094d8b7f42cdacd307e43347cefae8299c676bb2 (patch)
tree0b90bfd068d841ee047a20eaf603168a6cffa9cb
parent1ba36012879083330871c301464daf7615f7d7d0 (diff)
downloadgnome-online-accounts-094d8b7f42cdacd307e43347cefae8299c676bb2.tar.gz
kerberos: Don't leak the return_key in sign_in_identity_sync
https://bugzilla.gnome.org/show_bug.cgi?id=765121
-rw-r--r--src/goabackend/goakerberosprovider.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index a451d98..3624164 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -1568,7 +1568,7 @@ sign_in_identity_sync (GoaKerberosProvider *self,
{
GcrSecretExchange *secret_exchange;
char *secret_key;
- char *return_key;
+ char *return_key = NULL;
char *concealed_secret;
char *identity_object_path = NULL;
gboolean keys_exchanged;
@@ -1622,6 +1622,7 @@ sign_in_identity_sync (GoaKerberosProvider *self,
g_mutex_unlock (&identity_manager_mutex);
out:
+ g_free (return_key);
g_object_unref (secret_exchange);
return identity_object_path;
}