general: Stop using gtk_widget_{show,hide}

These APIs are deprecated and can be replaced by
`gtk_widget_set_visible ()` in all cases.

5 files changed, 39 insertions, 44 deletions

diff --git a/src/gl-eventviewdetail.c b/src/gl-eventviewdetail.c
index 4eaf0b3..f3d5334 100644
--- a/src/gl-eventviewdetail.c
+++ b/src/gl-eventviewdetail.c
@@ -99,8 +99,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
     if (gl_journal_entry_get_command_line (entry))
     {
         gtk_label_set_text (GTK_LABEL (priv->comm_label), gl_journal_entry_get_command_line (entry));
-        gtk_widget_show (priv->comm_field_label);
-        gtk_widget_show (priv->comm_label);
+        gtk_widget_set_visible (priv->comm_field_label, TRUE);
+        gtk_widget_set_visible (priv->comm_label, TRUE);
     }
 
     now = g_date_time_new_now_local ();
@@ -115,15 +115,15 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
     if (gl_journal_entry_get_audit_session (entry))
     {
         gtk_label_set_text (GTK_LABEL (priv->audit_label), gl_journal_entry_get_audit_session (entry));
-        gtk_widget_show (priv->audit_field_label);
-        gtk_widget_show (priv->audit_label);
+        gtk_widget_set_visible (priv->audit_field_label, TRUE);
+        gtk_widget_set_visible (priv->audit_label, TRUE);
     }
 
     if (gl_journal_entry_get_kernel_device (entry))
     {
         gtk_label_set_text (GTK_LABEL (priv->device_label), gl_journal_entry_get_kernel_device (entry));
-        gtk_widget_show (priv->device_field_label);
-        gtk_widget_show (priv->device_label);
+        gtk_widget_set_visible (priv->device_field_label, TRUE);
+        gtk_widget_set_visible (priv->device_label, TRUE);
     }
 
     /* TODO: Give a user-friendly representation of the priority. */
@@ -166,8 +166,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
                     {
                         gtk_label_set_text (GTK_LABEL (priv->subject_label),
                                             str_message);
-                        gtk_widget_show (priv->subject_field_label);
-                        gtk_widget_show (priv->subject_label);
+                        gtk_widget_set_visible (priv->subject_field_label, TRUE);
+                        gtk_widget_set_visible (priv->subject_label, TRUE);
                     }
                 }
                 else
@@ -180,8 +180,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
                     {
                         gtk_label_set_text (GTK_LABEL (priv->subject_label),
                                             str);
-                        gtk_widget_show (priv->subject_field_label);
-                        gtk_widget_show (priv->subject_label);
+                        gtk_widget_set_visible (priv->subject_field_label, TRUE);
+                        gtk_widget_set_visible (priv->subject_label, TRUE);
                     }
 
                     g_free (str);
@@ -199,8 +199,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
                     {
                         gtk_label_set_text (GTK_LABEL (priv->definedby_label),
                                             str_message);
-                        gtk_widget_show (priv->definedby_field_label);
-                        gtk_widget_show (priv->definedby_label);
+                        gtk_widget_set_visible (priv->definedby_field_label, TRUE);
+                        gtk_widget_set_visible (priv->definedby_label, TRUE);
                     }
                 }
                 else
@@ -213,8 +213,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
                     {
                         gtk_label_set_text (GTK_LABEL (priv->definedby_label),
                                             str);
-                        gtk_widget_show (priv->definedby_field_label);
-                        gtk_widget_show (priv->definedby_label);
+                        gtk_widget_set_visible (priv->definedby_field_label, TRUE);
+                        gtk_widget_set_visible (priv->definedby_label, TRUE);
                     }
 
                     g_free (str);
@@ -238,8 +238,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
 
                         gtk_label_set_markup (GTK_LABEL (priv->support_label),
                                               str_link);
-                        gtk_widget_show (priv->support_field_label);
-                        gtk_widget_show (priv->support_label);
+                        gtk_widget_set_visible (priv->support_field_label, TRUE);
+                        gtk_widget_set_visible (priv->support_label, TRUE);
 
                         g_free (str_link);
                     }
@@ -260,8 +260,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
 
                         gtk_label_set_markup (GTK_LABEL (priv->support_label),
                                               str_link);
-                        gtk_widget_show (priv->support_field_label);
-                        gtk_widget_show (priv->support_label);
+                        gtk_widget_set_visible (priv->support_field_label, TRUE);
+                        gtk_widget_set_visible (priv->support_label, TRUE);
 
                         g_free (str_link);
                     }
@@ -281,8 +281,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
                     {
                         gtk_label_set_text (GTK_LABEL (priv->documentation_label),
                                             str_message);
-                        gtk_widget_show (priv->documentation_field_label);
-                        gtk_widget_show (priv->documentation_label);
+                        gtk_widget_set_visible (priv->documentation_field_label, TRUE);
+                        gtk_widget_set_visible (priv->documentation_label, TRUE);
                     }
                 }
                 else
@@ -295,8 +295,8 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
                     {
                         gtk_label_set_text (GTK_LABEL (priv->documentation_label),
                                             str);
-                        gtk_widget_show (priv->documentation_field_label);
-                        gtk_widget_show (priv->documentation_label);
+                        gtk_widget_set_visible (priv->documentation_field_label, TRUE);
+                        gtk_widget_set_visible (priv->documentation_label, TRUE);
                     }
 
                     g_free (str);
@@ -314,7 +314,7 @@ gl_event_view_detail_create_detail (GlEventViewDetail *detail)
         {
             gtk_label_set_text (GTK_LABEL (priv->detailed_message_label),
                                 str_field);
-            gtk_widget_show (priv->detailed_message_label);
+            gtk_widget_set_visible (priv->detailed_message_label, TRUE);
         }
 
         g_free (str_field);
diff --git a/src/gl-eventviewlist.c b/src/gl-eventviewlist.c
index 1d3efd9..6517408 100644
--- a/src/gl-eventviewlist.c
+++ b/src/gl-eventviewlist.c
@@ -233,6 +233,7 @@ on_listbox_row_activated (GtkListBox *listbox,
         for (index = header_row_index + 1; compressed_entries != 0; index++)
         {
             GtkListBoxRow *compressed_row;
+            gboolean row_visible;
 
             compressed_row = gtk_list_box_get_row_at_index (GTK_LIST_BOX (priv->entries_box),
                                                             index);
@@ -241,16 +242,9 @@ on_listbox_row_activated (GtkListBox *listbox,
             gtk_style_context_add_class (context, "compressed-row");
 
             /* Toggle the visibility */
-            if (gtk_widget_get_visible (GTK_WIDGET (compressed_row)))
-            {
-                gtk_widget_hide (GTK_WIDGET (compressed_row));
-                rows_expanded = FALSE;
-            }
-            else
-            {
-                gtk_widget_show (GTK_WIDGET (compressed_row));
-                rows_expanded = TRUE;
-            }
+            row_visible = gtk_widget_get_visible (GTK_WIDGET (compressed_row));
+            gtk_widget_set_visible (GTK_WIDGET (compressed_row), !row_visible);
+            rows_expanded = !row_visible;
 
             compressed_entries--;
         }
@@ -1089,3 +1083,4 @@ gl_event_view_list_new (void)
 {
     return g_object_new (GL_TYPE_EVENT_VIEW_LIST, NULL);
 }
+
diff --git a/src/gl-eventviewrow.c b/src/gl-eventviewrow.c
index 31d4b06..c46d847 100644
--- a/src/gl-eventviewrow.c
+++ b/src/gl-eventviewrow.c
@@ -405,7 +405,7 @@ on_parent_set (GtkWidget *widget)
     if (priv->old_parent == NULL &&
         gl_row_entry_get_row_type (priv->entry) == GL_ROW_ENTRY_TYPE_COMPRESSED)
     {
-        gtk_widget_hide (widget);
+        gtk_widget_set_visible (widget, FALSE);
     }
 
     if (gtk_widget_get_parent (GTK_WIDGET (row)))
diff --git a/src/gl-searchpopover.c b/src/gl-searchpopover.c
index 3a43060..194057a 100644
--- a/src/gl-searchpopover.c
+++ b/src/gl-searchpopover.c
@@ -1487,10 +1487,10 @@ gl_search_popover_init (GlSearchPopover *popover)
         GtkAdjustment *end_hour_adjustment;
 
         /* Hide the AM/PM time period spinbuttons */
-        gtk_widget_hide (priv->start_time_period_spin);
-        gtk_widget_hide (priv->start_time_period_label);
-        gtk_widget_hide (priv->end_time_period_spin);
-        gtk_widget_hide (priv->end_time_period_label);
+        gtk_widget_set_visible (priv->start_time_period_spin, FALSE);
+        gtk_widget_set_visible (priv->start_time_period_label, FALSE);
+        gtk_widget_set_visible (priv->end_time_period_spin, FALSE);
+        gtk_widget_set_visible (priv->end_time_period_label, FALSE);
 
         /* Set 0-23 as range for hour spinbutton */
         start_hour_adjustment = gtk_adjustment_new (23.0, 0.0, 23.0, 5.0, 0.0, 0.0);
diff --git a/src/gl-window.c b/src/gl-window.c
index 6dd4363..90db518 100644
--- a/src/gl-window.c
+++ b/src/gl-window.c
@@ -284,7 +284,7 @@ on_help_button_clicked (GlWindow *window,
     gtk_show_uri (parent, "help:gnome-logs/permissions",
                   GDK_CURRENT_TIME);
 
-    gtk_widget_hide (priv->info_bar);
+    gtk_widget_set_visible (priv->info_bar, FALSE);
 }
 
 static void
@@ -300,7 +300,7 @@ on_ignore_button_clicked (GlWindow *window,
     settings = g_settings_new (SETTINGS_SCHEMA);
     g_settings_set_boolean (settings, IGNORE_WARNING, TRUE);
 
-    gtk_widget_hide (priv->info_bar);
+    gtk_widget_set_visible (priv->info_bar, FALSE);
 
     g_object_unref (settings);
 }
@@ -472,14 +472,14 @@ gl_window_init (GlWindow *window)
             {
                 gtk_label_set_label (priv->message_label, _("Unable to read system logs"));
 
-                gtk_widget_show (priv->info_bar);
+                gtk_widget_set_visible (priv->info_bar, TRUE);
             }
 
             if (!gl_util_can_read_user_journal ())
             {
                 gtk_label_set_label (priv->message_label, _("Unable to read user logs"));
 
-                gtk_widget_show (priv->info_bar);
+                gtk_widget_set_visible (priv->info_bar, TRUE);
             }
             break;
         }
@@ -489,7 +489,7 @@ gl_window_init (GlWindow *window)
             {
                 gtk_label_set_label (priv->message_label, _("Unable to read system logs"));
 
-                gtk_widget_show (priv->info_bar);
+                gtk_widget_set_visible (priv->info_bar, TRUE);
             }
             break;
         }
@@ -497,7 +497,7 @@ gl_window_init (GlWindow *window)
         {
             gtk_label_set_label (priv->message_label, _("No logs available"));
 
-            gtk_widget_show (priv->info_bar);
+            gtk_widget_set_visible (priv->info_bar, TRUE);
             break;
         }
         default: