summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 3.26.03.26.0Matthias Clasen2017-09-112-2/+8
|
* Update French translationAlain Lojewski2017-09-071-30/+30
|
* Correct the version numberv3.25.92Matthias Clasen2017-09-061-1/+1
|
* 3.25.923.25.92Matthias Clasen2017-09-062-2/+10
|
* Update Romanian translationDaniel Șerbănescu2017-09-061-317/+249
|
* thumbnail: Fix gsf-office-thumbnailer not workingBastien Nocera2017-09-061-11/+11
| | | | | | | | | | | The gsf-office-thumbnailer expects a local file path to be passed, but instead of treating one of expand_thumbnailing_elem()'s arguments as a local path (which it is), we treated it as a URI and tried to convert it to a URI. That obviously failed, and the thumbnailer wasn't even launched. https://bugzilla.gnome.org/show_bug.cgi?id=787249
* thumbnail: Add debug when loading an image file failsBastien Nocera2017-09-061-1/+6
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=787249
* thumbnail: Fix nautilus trying to thumbnail foldersBastien Nocera2017-09-041-1/+6
| | | | | | | | | And loads of other non-thumbnailable files in a regression introduced in 3b298f60. To answer _can_thumbnail() correctly, we need to check whether a thumbnailer exists for the mime-type in question, not simply assume it to be available. https://bugzilla.gnome.org/show_bug.cgi?id=785404
* thumbnail: Remove extra debug lineBastien Nocera2017-09-041-1/+0
| | | | Was not supposed to be in the commit.
* Update Finnish translationJiri Grönroos2017-09-021-643/+469
|
* thumbnail: Make test program behave like stand-alone thumbnailersBastien Nocera2017-08-281-13/+19
| | | | | | Rather than display an image in a GTK+ window, behave like stand-alone thumbnailers and generate an output file. This makes it easier to compare stand-alone thumbnailers with ones wrapped in gnome-desktop.
* thumbnail: Remove useless initialisationBastien Nocera2017-08-281-2/+0
| | | | The variable is set to a function return 2 lines below.
* thumbnail: Add debug for thumbnailersBastien Nocera2017-08-281-0/+6
| | | | Pass G_MESSAGES_DEBUG=all to thumbnailers if the debug is enabled.
* thumbnail: Disable gvfs inside the sandboxBastien Nocera2017-08-281-0/+1
| | | | | No need to attempt connecting to gvfs inside the sandbox, it will not be accessible.
* thumbnailer: Add copyright notice to test applicationBastien Nocera2017-08-281-0/+23
|
* build: Modify NEWS file to match version numberBastien Nocera2017-08-281-3/+3
| | | | | The release was wrongly numbered with a "sub" number of 1. Modify the NEWS file to match the version number actually used.
* Updated Danish translationAsk Hjorth Larsen2017-08-261-57/+58
|
* build: Move gnome_sub next to the other version numbersBastien Nocera2017-08-231-1/+1
| | | | | So that it's not missed, repeatedly, by whoever updates the configure.ac.
* 3.25.913.25.91Bastien Nocera2017-08-232-2/+11
|
* thumbnail: Throw a warning if thumbnailer leaves dangling filesBastien Nocera2017-08-221-1/+9
| | | | | | | | | | | When running sandboxed, we could make use "--tmpfs /tmp" to make /tmp disappear along with the thumbnailer, but that would just paper over the fact that those same discarded temporary files would be left in /tmp (RAM if tmpfs) when not sandboxed. So warn about badly behaved thumbnailers. https://bugzilla.gnome.org/show_bug.cgi?id=785238
* thumbnailer: Fix left-over files in /tmpBastien Nocera2017-08-221-3/+12
| | | | | | | | The fd that bwrap copies from the --file argument needs to be cleaned up as well, otherwise the temporary file as well as the directory containing it will be left on disk. https://bugzilla.gnome.org/show_bug.cgi?id=786584
* thumbnail: Don't copy files to /tmp before using themBastien Nocera2017-08-221-17/+3
| | | | | | | | Instead of copying whole files to the sandbox, bind mount the _file_. This is especially important when dealing with huge files when only a tiny portion of the file will actually be read. https://bugzilla.gnome.org/show_bug.cgi?id=786586
* thumbnailer: Fix compile-time error on x32Laurent Bigonville2017-08-221-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=786355
* gnome-rr-config: Fix memory leakMohammed Sadiq2017-08-221-0/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=783849
* 3.25.90.13.25.90.1Matthias Clasen2017-08-092-1/+8
|
* thumbnail: And print those errors in the debugBastien Nocera2017-08-081-1/+8
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785963
* thumbnail: Report errors when script_exec_new() failsBastien Nocera2017-08-081-5/+14
| | | | | | Makes it easier to debug. https://bugzilla.gnome.org/show_bug.cgi?id=785963
* thumbnail: Don't crash if the thumbnailer could not be setupBastien Nocera2017-08-081-0/+5
| | | | | | | | script_exec_new() can fail in certain cases, and we should not crash when trying to expand the script command later if the initial setup failed. https://bugzilla.gnome.org/show_bug.cgi?id=785963
* 3.25.903.25.90Matthias Clasen2017-08-072-1/+9
|
* thumbnail: Don't try to setup seccomp when sandboxedBastien Nocera2017-07-301-11/+14
| | | | | | | Flatpak drops privileges very early in the sandbox setup phase which means that we don't have enough permissions to setup seccomp. It would be nice if we could still use seccomp to restrict even further, but that's not the case as of yet.
* Fix heap-use-after-free with duplicate xkb layoutsJason Crain2017-07-251-0/+6
| | | | | | | | | Debian's gnome-control-center can crash when show-all-sources is enabled. When parse_end_element in gnome-xkb-info.c encounters duplicate layouts, it will free the memory for the first layout while it is still in a hash table. https://bugzilla.gnome.org/show_bug.cgi?id=785320
* Update Nepali translationPawan Chitrakar2017-07-241-307/+346
|
* thumbnail: Restrict thumbnailer syscalls using seccompBastien Nocera2017-07-212-1/+381
| | | | | | | Use seccomp code from flatpak to limit the system calls thumbnailers can make, reducing the attach surface. https://bugzilla.gnome.org/show_bug.cgi?id=785197
* thumbnail: Sandbox thumbnailers on LinuxBastien Nocera2017-07-212-15/+194
| | | | | | | | | | | | | | | On Linux systems, bubblewrap is now required to launch thumbnailers in a restricted environment. - Only /usr and the compilation ${prefix} of the gnome-desktop library will be available to the thumbnailer as read-only - The network is disabled - The filename of the file to thumbnail is hidden - Bubblewrap is not used if the application is already sandboxed in Flatpak as all privileges to create a new namespace are dropped when the initial one is created. https://bugzilla.gnome.org/show_bug.cgi?id=774497
* thumbnail: Split off running the scriptBastien Nocera2017-07-214-150/+321
| | | | | | | | | | | | | | | | | | | Move most of the script command generation to a separate file, making the function return a GBytes from a successful thumbnailer run, so as to avoid having to clean up temporary files from the thumbnailer run. Note that it changes a few subtle things which shouldn't be a problem in practice, but, as a corner case, might have been used by applications: - Thumbnailers must output PNG images. pixbuf_new_from_bytes() could have been made more complicated to handle all images, and then we would restrict the thumbnailer output format separately, but it makes no sense to write complicated code to remove it in the next commit. - URIs which have no backing path are not supported. This will likely cause problems for thumbnailing remote shares on OSes which lack gvfsd-fuse. Support could be re-added in the future. https://bugzilla.gnome.org/show_bug.cgi?id=774497
* thumbnail: Remove TryExec element in thumbnailer definitionBastien Nocera2017-07-211-40/+1
| | | | | | It's really not that useful. If the thumbnailer definition is installed, then we expect the thumbnailer to be installed and functional.
* thumbnail: Use an array to store the thumbnailer's cmdlineBastien Nocera2017-07-211-30/+86
| | | | | Instead of a shell-quoted string, to make it easier to add new elements to this command-line.
* thumbnail: Use g_strcmp0() and remove a NULL checkBastien Nocera2017-07-211-6/+2
|
* thumbnail: Simplify system includesBastien Nocera2017-07-211-12/+4
|
* thumbnail: Fix typo in optionalBastien Nocera2017-07-211-1/+1
|
* thumbnail: Remove unused constant SECONDS_BETWEEN_STATSBastien Nocera2017-07-211-2/+0
|
* thumbnail: Remove unused #define GDK_PIXBUF_ENABLE_BACKENDBastien Nocera2017-07-211-1/+0
|
* thumbnail: Remove reference to GnomeIconFactoryBastien Nocera2017-07-211-1/+1
|
* thumbnail: Simplify init_thumbnailers_dirs()Bastien Nocera2017-07-211-9/+8
|
* thumbnail: Remove trailing spacesBastien Nocera2017-07-212-20/+20
|
* build: Fix syntax highlighting in configure.acBastien Nocera2017-07-211-1/+1
|
* Fix bug referenceMatthias Clasen2017-07-201-1/+1
|
* 3.25.43.25.4Matthias Clasen2017-07-202-1/+8
|
* thumbnail: Fix use of uninitialised valueBastien Nocera2017-07-181-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pixbuf to be written as a placeholder thumbnail was never initialised to be empty, so might contain random data from the stack. Use gdk_pixbuf_fill() to solve this problem. Use of uninitialised value of size 8 at 0x9A8ED44: crc32_little (crc32.c:287) by 0x9A8ED44: crc32_z (crc32.c:220) by 0x8A617FB: png_calculate_crc (png.c:153) by 0x8A7FACF: png_write_complete_chunk (pngwutil.c:187) by 0x8A801B1: png_compress_IDAT (pngwutil.c:1047) by 0x8A81F8E: png_write_filtered_row (pngwutil.c:2743) by 0x8A81F8E: png_write_find_filter (pngwutil.c:2713) by 0x8A7CF21: png_write_row (pngwrite.c:888) by 0x8A7D20E: png_write_rows (pngwrite.c:582) by 0x8263A08: real_save_png (io-png.c:1139) by 0x8263B0A: gdk_pixbuf__png_image_save (io-png.c:1166) by 0x8250FF8: gdk_pixbuf_real_save (gdk-pixbuf-io.c:2180) by 0x8251820: gdk_pixbuf_savev (gdk-pixbuf-io.c:2479) by 0x8251534: gdk_pixbuf_save (gdk-pixbuf-io.c:2418) by 0x5342324: save_thumbnail (gnome-desktop-thumbnail.c:1224) by 0x53424DD: gnome_desktop_thumbnail_factory_create_failed_thumbnail (gnome-desktop-thumbnail.c:1313) by 0x4E89B6A: eog_thumbnail_load (eog-thumbnail.c:518) by 0x4E6BA39: eog_job_thumbnail_run (eog-jobs.c:1270) by 0x4E69796: eog_job_run (eog-jobs.c:271) by 0x4E689A2: eog_job_process (eog-job-scheduler.c:153) by 0x4E688AA: eog_job_scheduler (eog-job-scheduler.c:128) by 0x97E4004: g_thread_proxy (gthread.c:784) by 0x9CAA36C: start_thread (in /usr/lib64/libpthread-2.25.so) by 0x9FD2E9E: clone (in /usr/lib64/libc-2.25.so) Uninitialised value was created by a stack allocation at 0x8262D5E: real_save_png (io-png.c:871) https://bugzilla.gnome.org/show_bug.cgi?id=784915
* Add default input source for fr_BE localeLaurent Bigonville2017-07-071-0/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=784653