summaryrefslogtreecommitdiff
path: root/panels/printers/pp-details-dialog.c
Commit message (Collapse)AuthorAgeFilesLines
* Change PpPPDSelectionDialog to GtkDialogBrandon Nielsen2021-01-081-2/+6
| | | | | | | | | | | The dialog is now displayed by calling gtk_dialog_run and gtk_window_set_transient_for in the window displaying the dialog. Cleanup is handled using gtk_widget_destroy. Destructors in the windows using the dialog no longer cleanup the dialog as it is assumed it will be either cleaned up after the response callback, or handled by the destroy_with_parent property set on the dialog itself.
* printers: Fix leak of printer name in callbacks.Robert Ancell2020-10-291-2/+2
| | | | | | printer_set_ppd_async and printer_set_ppd_file_async copy the printer name, but this isn't freed in any cases that use these callback (the string isn't even used at all).
* component: PpPPDSelectionDialogBrandon Nielsen2020-09-251-1/+1
| | | | | | | | | | | G_IS_OBJECT checks fail when calling g_signal_connect_object because PpPPDSelectionDialog is a struct, not a type descending from G_OBJECT. This makes the changes required for PpPPDSelectionDialog to be a GObject, and defines PpPPDSelectionDialog as a GObject. It also updates consumers of PpPPDSelectionDialog to destroy created PpPPDSelectionDialogs as GObjects. https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1126
* printers: Remove unused class membersRobert Ancell2020-07-021-3/+0
|
* printers: Sort variablesRobert Ancell2019-09-101-15/+15
|
* printers: Use gtk_stack_set_visible_child instead of namesRobert Ancell2019-09-101-2/+4
|
* printers: Connect signals in swapped formRobert Ancell2019-09-101-9/+4
|
* printers: use gtk_dialog_runRobert Ancell2019-09-101-60/+15
|
* printers: Drop unused class structureRobert Ancell2019-09-101-7/+0
|
* printers: Set transient window externally to dialog codeRobert Ancell2019-09-101-7/+5
|
* printers: Remove pp_details_dialog_free, use gtk_widget_destroyRobert Ancell2019-09-101-22/+24
|
* printers: Make .ui filename match the .c filenameRobert Ancell2019-09-101-1/+1
|
* printers: Use g_autoptr with stringsRobert Ancell2019-02-051-18/+7
|
* printers: Fix GCancellable leakRobert Ancell2019-01-301-5/+1
| | | | Use the dialog cancellable instead of leaking one each time the PPD is set.
* printers: Use dialog cancellable in async callRobert Ancell2019-01-301-1/+1
| | | | Otherwise this could crash if the dialog is destroyed before the PPD is set.
* printers: Use a single GCancellable for PpDetailsDialogRobert Ancell2019-01-301-15/+8
| | | | | The cancellable is only used to cancel when the dialog is destroyed, so you can share it for all calls.
* printers: Replace GObject boilerplace with G_DECLARE_TYPERobert Ancell2019-01-301-1/+1
|
* printers: Plug memory leaksRobert Ancell2018-06-251-0/+1
|
* Simplify use of GCancellableRobert Ancell2018-06-011-11/+4
| | | | | g_cancellable_cancell can be called without checking for a NULL value. Use g_clear_object instead of g_object_unref
* shell: Remove CcEditableEntry, it is not used anywhereBenjamin Berg2018-04-171-1/+0
|
* printers: Don't show duplicates while renaming printerFelipe Borges2018-02-051-0/+20
| | | | | | | | | | | | During the time it took to rename a printer asynchronously, we had cases where two entries were shown for the same printer: one with the old name and another with a new name. Now we signal from DetailsDialog to the given PrinterEntry which passes it along to the main panel object. The CcPrintersPanel object blacklists the renamed printer old name. https://bugzilla.gnome.org/show_bug.cgi?id=790361
* printers: Ellipsize the "Details Dialog" titleFelipe Borges2017-02-261-5/+4
| | | | | | | | | Printers with long names were causing the "Printer Details Dialog" to expande horizontally. This patch ellipsizes the custom title of the dialog. https://bugzilla.gnome.org/show_bug.cgi?id=779071
* printers: Use async rename methodFelipe Borges2017-02-221-2/+17
| | | | | | | | | | | pp_printer_rename_async is better than the old printer_rename utility. The PpDetailsDialog doesn't need to do anything in the callback since we are emiting the "printer-changed" signal when the dialog is closed. https://bugzilla.gnome.org/show_bug.cgi?id=769114
* printers: Do not apply rename/location changes in focus-out-eventFelipe Borges2017-02-221-27/+16
| | | | | | | | Since we are already applying the changing in the PpDetailsDialog when it gets closed, there's no need to apply these changes in the focus-out-event of its respective GtkEntries. https://bugzilla.gnome.org/show_bug.cgi?id=769114
* printers: Make the printer address always sensitiveFelipe Borges2017-02-151-1/+12
| | | | | | | | This patch individually updates the sensitivity of the PpDetailsDialog child widgets, so we can leave the printer address label always sensitive. https://bugzilla.gnome.org/show_bug.cgi?id=778682
* printers: Introduce PpDetailsDialogFelipe Borges2017-02-131-0/+447
This dialog handles the editing of printer properties such as name, location, automatic discovery of driver, manual selection of printer driver, and manual selection of ppd file. https://bugzilla.gnome.org/show_bug.cgi?id=767600
View Lorry Controller Status