shell: replace GMenu loading code with an hardcoded list of panels

Now that we don't allow or load external panels, using libgnome-menu is just
overengineering. We can get the same results with less code by keeping a static
list of function pointers.
This reduces the number of places one needs to patch to add a new panel.
Also, this way we avoid registering all types at startup, and if we want
we can switch to load panel desktop files in a separate thread.

https://bugzilla.gnome.org/show_bug.cgi?id=690165

1 files changed, 188 insertions, 0 deletions

diff --git a/shell/cc-panel-loader.c b/shell/cc-panel-loader.c
new file mode 100644
index 000000000..22ea2a2cc
--- /dev/null
+++ b/shell/cc-panel-loader.c
@@ -0,0 +1,188 @@
+/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
+/*
+ * Copyright (c) 2012 Giovanni Campagna <scampa.giovanni@gmail.com>
+ *
+ * The Control Center is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * The Control Center is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with the Control Center; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ * Author: Thomas Wood <thos@gnome.org>
+ */
+
+#include <config.h>
+
+#include <string.h>
+#include <gio/gdesktopappinfo.h>
+
+#include "cc-panel-loader.h"
+
+/* Extension points */
+extern GType cc_background_panel_get_type (void);
+#ifdef BUILD_BLUETOOTH
+extern GType cc_bluetooth_panel_get_type (void);
+#endif /* BUILD_BLUETOOTH */
+extern GType cc_color_panel_get_type (void);
+extern GType cc_date_time_panel_get_type (void);
+extern GType cc_display_panel_get_type (void);
+extern GType cc_info_panel_get_type (void);
+extern GType cc_keyboard_panel_get_type (void);
+extern GType cc_mouse_panel_get_type (void);
+#ifdef BUILD_NETWORK
+extern GType cc_network_panel_get_type (void);
+#endif /* BUILD_NETWORK */
+extern GType cc_goa_panel_get_type (void);
+extern GType cc_power_panel_get_type (void);
+#ifdef BUILD_PRINTERS
+extern GType cc_printers_panel_get_type (void);
+#endif /* BUILD_PRINTERS */
+extern GType cc_privacy_panel_get_type (void);
+extern GType cc_region_panel_get_type (void);
+extern GType cc_screen_panel_get_type (void);
+extern GType cc_search_panel_get_type (void);
+extern GType cc_sound_panel_get_type (void);
+extern GType cc_ua_panel_get_type (void);
+extern GType cc_user_panel_get_type (void);
+#ifdef BUILD_WACOM
+extern GType cc_wacom_panel_get_type (void);
+#endif /* BUILD_WACOM */
+
+static struct {
+  const char *name;
+  GType (*get_type)(void);
+} all_panels[] = {
+  { "background",       cc_background_panel_get_type },
+#ifdef BUILD_BLUETOOTH
+  { "bluetooth",        cc_bluetooth_panel_get_type  },
+#endif
+  { "color",            cc_color_panel_get_type      },
+  { "datetime",         cc_date_time_panel_get_type  },
+  { "display",          cc_display_panel_get_type    },
+  { "info",             cc_info_panel_get_type       },
+  { "keyboard",         cc_keyboard_panel_get_type   },
+  { "mouse",            cc_mouse_panel_get_type      },
+#ifdef BUILD_NETWORK
+  { "network",          cc_network_panel_get_type    },
+#endif
+  { "online-accounts",  cc_goa_panel_get_type        },
+  { "power",            cc_power_panel_get_type      },
+#ifdef BUILD_PRINTERS
+  { "printers",         cc_printers_panel_get_type   },
+#endif
+  { "privacy",          cc_privacy_panel_get_type    },
+  { "region",           cc_region_panel_get_type     },
+  { "screen",           cc_screen_panel_get_type     },
+  { "search",           cc_search_panel_get_type     },
+  { "sound",            cc_sound_panel_get_type      },
+  { "universal-access", cc_ua_panel_get_type         },
+  { "user-accounts",    cc_user_panel_get_type       },
+#ifdef BUILD_WACOM
+  { "wacom",            cc_wacom_panel_get_type      },
+#endif
+};
+
+static GHashTable *panel_types;
+
+static int
+parse_categories (GDesktopAppInfo *app)
+{
+  const char *categories;
+  char **split;
+  int retval;
+  int i;
+
+  categories = g_desktop_app_info_get_categories (app);
+  split = g_strsplit (categories, ";", -1);
+
+  retval = -1;
+
+  for (i = 0; split[i]; i++)
+    {
+      if (strcmp (split[i], "HardwareSettings") == 0)
+        retval = CC_CATEGORY_HARDWARE;
+      else if (strcmp (split[i], "X-GNOME-PersonalSettings") == 0)
+        retval = CC_CATEGORY_PERSONAL;
+      else if (strcmp (split[i], "X-GNOME-SystemSettings") == 0)
+        retval = CC_CATEGORY_SYSTEM;
+    }
+
+  if (retval < 0)
+    {
+      g_warning ("Invalid categories %s for panel %s",
+                 categories, g_app_info_get_id (G_APP_INFO (app)));
+    }
+
+  g_strfreev (split);
+  return retval;
+}
+
+void
+cc_panel_loader_fill_model (CcShellModel *model)
+{
+  int i;
+
+  for (i = 0; i < G_N_ELEMENTS (all_panels); i++)
+    {
+      GDesktopAppInfo *app;
+      char *desktop_name;
+      int category;
+
+      desktop_name = g_strconcat ("gnome-", all_panels[i].name,
+                                  "-panel.desktop", NULL);
+      app = g_desktop_app_info_new (desktop_name);
+
+      if (app == NULL)
+        {
+          g_warning ("Ignoring broken panel %s (missing desktop file)",
+                     all_panels[i].name);
+          continue;
+        }
+
+      category = parse_categories (app);
+      if (G_UNLIKELY (category < 0))
+        continue;
+
+      cc_shell_model_add_item (model, category, G_APP_INFO (app), all_panels[i].name);
+      g_object_unref (app);
+    }
+}
+
+static void
+ensure_panel_types (void)
+{
+  int i;
+
+  if (G_LIKELY (panel_types != NULL))
+    return;
+
+  panel_types = g_hash_table_new (g_str_hash, g_str_equal);
+  for (i = 0; i < G_N_ELEMENTS (all_panels); i++)
+    g_hash_table_insert (panel_types, (char*)all_panels[i].name, all_panels[i].get_type);
+}
+
+CcPanel *
+cc_panel_loader_load_by_name (CcShell     *shell,
+                              const char  *name,
+                              const char **argv)
+{
+  GType (*get_type) (void);
+
+  ensure_panel_types ();
+
+  get_type = g_hash_table_lookup (panel_types, name);
+  g_return_val_if_fail (get_type != NULL, NULL);
+
+  return g_object_new (get_type (),
+                       "shell", shell,
+                       "argv", argv,
+                       NULL);
+}