diff options
| author | Michael Catanzaro <mcatanzaro@gnome.org> | 2015-09-27 23:51:40 -0500 |
|---|---|---|
| committer | Felipe Borges <felipeborges@gnome.org> | 2017-05-29 19:25:51 +0200 |
| commit | 50160be2c67cec38591c725a198af5a36f532ec9 (patch) | |
| tree | ed05fed6033e205e39f2eee2bcf0a7e70f9e7c17 /panels/printers/pp-options-dialog.c | |
| parent | 6dcf057a53ceccc3e1fbb91fd62ad7bfab9426e9 (diff) | |
| download | gnome-control-center-50160be2c67cec38591c725a198af5a36f532ec9.tar.gz | |
printers: Move options dialog spinner out of the action area
For an infinitesimal amount of time after opening the options dialog, a
spinner is displayed at the start of the action area while the dialog
loads asynchronously. Display the spinner in the center of the dialog
instead, using a GtkStack to switch between spinner mode and normal
mode. Test by removing the calls to printer_get_ppd_async(),
get_named_dest_async(), and get_ipp_attributes_async() from the bottom
of populate_options().
Why? (1) It looks better this way. (2) Need to stop using the action
area in order to switch to a header bar.
https://bugzilla.gnome.org/show_bug.cgi?id=755713
https://bugzilla.gnome.org/show_bug.cgi?id=779708
Diffstat (limited to 'panels/printers/pp-options-dialog.c')
| -rw-r--r-- | panels/printers/pp-options-dialog.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/panels/printers/pp-options-dialog.c b/panels/printers/pp-options-dialog.c index 47ea2e34b..d2def2ec9 100644 --- a/panels/printers/pp-options-dialog.c +++ b/panels/printers/pp-options-dialog.c @@ -508,12 +508,11 @@ populate_options_real (PpOptionsDialog *dialog) widget = (GtkWidget*) gtk_builder_get_object (dialog->builder, "options-spinner"); - gtk_widget_hide (widget); gtk_spinner_stop (GTK_SPINNER (widget)); widget = (GtkWidget*) - gtk_builder_get_object (dialog->builder, "progress-label"); - gtk_widget_hide (widget); + gtk_builder_get_object (dialog->builder, "stack"); + gtk_stack_set_visible_child_name (GTK_STACK (widget), "main-box"); treeview = (GtkTreeView *) gtk_builder_get_object (dialog->builder, "options-categories-treeview"); @@ -777,6 +776,10 @@ populate_options (PpOptionsDialog *dialog) "orientation-requested-default", NULL}; + widget = (GtkWidget*) + gtk_builder_get_object (dialog->builder, "stack"); + gtk_stack_set_visible_child_name (GTK_STACK (widget), "progress-box"); + treeview = (GtkTreeView *) gtk_builder_get_object (dialog->builder, "options-categories-treeview"); @@ -789,13 +792,8 @@ populate_options (PpOptionsDialog *dialog) widget = (GtkWidget*) gtk_builder_get_object (dialog->builder, "options-spinner"); - gtk_widget_show (widget); gtk_spinner_start (GTK_SPINNER (widget)); - widget = (GtkWidget*) - gtk_builder_get_object (dialog->builder, "progress-label"); - gtk_widget_show (widget); - printer_get_ppd_async (dialog->printer_name, NULL, 0, |