summaryrefslogtreecommitdiff
path: root/panels/info-overview
diff options
context:
space:
mode:
authorRobert Ancell <robert.ancell@canonical.com>2019-09-25 22:32:07 +1200
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>2019-09-25 13:50:28 +0000
commit8e9e84853d876c46143491430936e2149e47b2c8 (patch)
treee191b03c074da63eaf7f02a21995ae12a97ea8e7 /panels/info-overview
parent8f8924b067d7b6672e57f5326b368991fea463f9 (diff)
downloadgnome-control-center-8e9e84853d876c46143491430936e2149e47b2c8.tar.gz
info-overview: Drop unnecessary grid reordering code
When the virtualization widgets are hidden, the following widets don't need to move up. This seems to be due to the orignal author thinking this was required or a bug in GTK rendering a double space between these rows.
Diffstat (limited to 'panels/info-overview')
-rw-r--r--panels/info-overview/cc-info-overview-panel.c22
-rw-r--r--panels/info-overview/cc-info-overview-panel.ui4
2 files changed, 2 insertions, 24 deletions
diff --git a/panels/info-overview/cc-info-overview-panel.c b/panels/info-overview/cc-info-overview-panel.c
index 3cbc53bff..fd8ceff2f 100644
--- a/panels/info-overview/cc-info-overview-panel.c
+++ b/panels/info-overview/cc-info-overview-panel.c
@@ -70,8 +70,6 @@ typedef struct
GtkWidget *updates_button;
/* Virtualisation labels */
- GtkWidget *label8;
- GtkWidget *grid1;
GtkWidget *label18;
char *gnome_version;
@@ -526,22 +524,6 @@ get_cpu_info (const glibtop_sysinfo *info)
return g_strdup (cpu->str);
}
-static void
-move_one_up (GtkWidget *grid,
- GtkWidget *child)
-{
- int top_attach;
-
- gtk_container_child_get (GTK_CONTAINER (grid),
- child,
- "top-attach", &top_attach,
- NULL);
- gtk_container_child_set (GTK_CONTAINER (grid),
- child,
- "top-attach", top_attach - 1,
- NULL);
-}
-
static struct {
const char *id;
const char *display;
@@ -572,8 +554,6 @@ set_virtualization_label (CcInfoOverviewPanel *self,
{
gtk_widget_hide (priv->virt_type_label);
gtk_widget_hide (priv->label18);
- move_one_up (priv->grid1, priv->label8);
- move_one_up (priv->grid1, priv->disk_label);
return;
}
@@ -760,8 +740,6 @@ cc_info_overview_panel_class_init (CcInfoOverviewPanelClass *klass)
gtk_widget_class_bind_template_child_private (widget_class, CcInfoOverviewPanel, graphics_label);
gtk_widget_class_bind_template_child_private (widget_class, CcInfoOverviewPanel, virt_type_label);
gtk_widget_class_bind_template_child_private (widget_class, CcInfoOverviewPanel, updates_button);
- gtk_widget_class_bind_template_child_private (widget_class, CcInfoOverviewPanel, label8);
- gtk_widget_class_bind_template_child_private (widget_class, CcInfoOverviewPanel, grid1);
gtk_widget_class_bind_template_child_private (widget_class, CcInfoOverviewPanel, label18);
g_type_ensure (CC_TYPE_HOSTNAME_ENTRY);
diff --git a/panels/info-overview/cc-info-overview-panel.ui b/panels/info-overview/cc-info-overview-panel.ui
index 56e47d036..9139d2ef5 100644
--- a/panels/info-overview/cc-info-overview-panel.ui
+++ b/panels/info-overview/cc-info-overview-panel.ui
@@ -55,7 +55,7 @@
</packing>
</child>
<child>
- <object class="GtkGrid" id="grid1">
+ <object class="GtkGrid">
<property name="visible">True</property>
<property name="halign">center</property>
<property name="valign">center</property>
@@ -174,7 +174,7 @@
</packing>
</child>
<child>
- <object class="GtkLabel" id="label8">
+ <object class="GtkLabel">
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="xalign">1</property>