summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>2020-07-06 04:33:30 +0200
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>2021-08-13 19:25:41 +0000
commit6e5169ad4dacce7558a9aed8e4663905e2413d89 (patch)
treee694caac10b4d035893a51f8ec645178cfdc2b6b
parent585fe8c94a1d60e1e575dbdc980a9a73d1d6447f (diff)
downloadgnome-control-center-6e5169ad4dacce7558a9aed8e4663905e2413d89.tar.gz
wwan: Fix signal strength display when extended signal retrieval is disabled
MMModemSignal interface is used to retrieve extended signal information that requires periodic polling. Therefore, it needs to be manually enabled in order to use. There if a fallback to use mm_modem_get_signal_quality when MMModemSignal interface is unavailable, but it didn't check whether it's actually enabled, leaving the UI with empty label.
-rw-r--r--panels/wwan/cc-wwan-device.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/panels/wwan/cc-wwan-device.c b/panels/wwan/cc-wwan-device.c
index 31baff95c..55a627a5a 100644
--- a/panels/wwan/cc-wwan-device.c
+++ b/panels/wwan/cc-wwan-device.c
@@ -1183,12 +1183,16 @@ cc_wwan_device_dup_signal_string (CcWwanDevice *self)
GString *str;
gdouble value;
gboolean recent;
+ guint refresh_rate;
g_return_val_if_fail (CC_IS_WWAN_DEVICE (self), NULL);
modem_signal = mm_object_peek_modem_signal (self->mm_object);
- if (!modem_signal)
+ if (modem_signal)
+ refresh_rate = mm_modem_signal_get_rate (modem_signal);
+
+ if (!modem_signal || !refresh_rate)
return g_strdup_printf ("%d%%", mm_modem_get_signal_quality (self->modem, &recent));
str = g_string_new ("");