diff options
| author | Robert Mader <robert.mader@posteo.de> | 2022-01-02 20:55:15 +0100 |
|---|---|---|
| committer | Georges Basile Stavracas Neto <georges.stavracas@gmail.com> | 2022-01-05 22:12:13 +0000 |
| commit | 6a4652bd35e23a4ae4ec3078be380ed09858e0ee (patch) | |
| tree | 1d880a3075b956d0b2727ac67e573f823cd1ddfe | |
| parent | 0af1937d4d6ef2fac4bc50c21a250e140836b738 (diff) | |
| download | gnome-control-center-6a4652bd35e23a4ae4ec3078be380ed09858e0ee.tar.gz | |
display-config: Do not invert order when constructing modes
Mutter sends modes in descending order of preference. By reverting
the order via `g_list_prepend`, we get unintended side effects
such as choosing the least preferred refresh rate by default (if
the selected mode is not marked as preferred).
Instead of adding complex logic in several places, make sure that
the assumption of descending preference is kept by simply not
inverting the order.
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1562
| -rw-r--r-- | panels/display/cc-display-config-dbus.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/panels/display/cc-display-config-dbus.c b/panels/display/cc-display-config-dbus.c index ae9eb01b1..bc20b6982 100644 --- a/panels/display/cc-display-config-dbus.c +++ b/panels/display/cc-display-config-dbus.c @@ -795,6 +795,8 @@ construct_modes (CcDisplayMonitorDBus *self, if (mode->flags & MODE_CURRENT) self->current_mode = CC_DISPLAY_MODE (mode); } + + self->modes = g_list_reverse (self->modes); } static CcDisplayMonitorDBus * |