summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOndrej Holy <oholy@redhat.com>2019-02-08 09:45:35 +0100
committerOndrej Holy <oholy@redhat.com>2019-02-08 09:45:35 +0100
commit587238867e37d9b614ffdc945a61264827f430dd (patch)
treeb2152608985e31c8680bf420bd4a6601b9cf12f9
parent54538d06a8d39bc5442061db78db74dbb0c1edc5 (diff)
downloadgnome-control-center-587238867e37d9b614ffdc945a61264827f430dd.tar.gz
user-accounts: Fix crashes when dialog is canceled
Changes from !373 causes crashes when "Add User" dialog is canceled. Check return value and generate user avatar only if valid user is returned to fix the crashes.
-rw-r--r--panels/user-accounts/cc-user-panel.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/panels/user-accounts/cc-user-panel.c b/panels/user-accounts/cc-user-panel.c
index f71e83b1a..8edb5a594 100644
--- a/panels/user-accounts/cc-user-panel.c
+++ b/panels/user-accounts/cc-user-panel.c
@@ -365,9 +365,10 @@ add_user (CcUserPanel *self)
gtk_dialog_run (GTK_DIALOG (dialog));
user = cc_add_user_dialog_get_user (dialog);
- generate_user_avatar (user);
- if (user != NULL)
+ if (user != NULL) {
+ generate_user_avatar (user);
reload_users (self, user);
+ }
gtk_widget_destroy (GTK_WIDGET (dialog));
}