summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOndrej Holy <oholy@redhat.com>2018-08-30 16:07:36 +0200
committerRobert Ancell <robert.ancell@gmail.com>2018-09-10 22:04:23 +0000
commit44c5c9e50b182246aed20f21fa18af4a2c061775 (patch)
treef193608ef5b9bca87e4d8a90c6588fa1b4955a7e
parent37d02369b77a57b750b74a8fa2c59ff401f31b98 (diff)
downloadgnome-control-center-44c5c9e50b182246aed20f21fa18af4a2c061775.tar.gz
user-accounts: Do not set user for password dialog redundantly
um_password_dialog_set_user() is called from on_permission_changed() respective show_user(), which more or less means on every change in the panel. It it pretty enough to call this before opening the password dialog, which is already done over change_password() callback. Let's remove the redundant call which may lead to unwanted failures among others. https://gitlab.gnome.org/GNOME/gnome-control-center/issues/171
-rw-r--r--panels/user-accounts/um-user-panel.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/panels/user-accounts/um-user-panel.c b/panels/user-accounts/um-user-panel.c
index eaa77bdb6..b9a675f81 100644
--- a/panels/user-accounts/um-user-panel.c
+++ b/panels/user-accounts/um-user-panel.c
@@ -1286,8 +1286,6 @@ on_permission_changed (GPermission *permission,
gtk_widget_set_sensitive (get_widget (self, "last-login-button"), FALSE);
add_unlock_tooltip (get_widget (self, "last-login-button"));
}
-
- um_password_dialog_set_user (self->password_dialog, user);
}
static void