diff options
| author | Rui Matos <tiagomatos@gmail.com> | 2017-03-17 15:08:05 +0100 |
|---|---|---|
| committer | Rui Matos <tiagomatos@gmail.com> | 2017-03-23 17:16:24 +0100 |
| commit | b8f7065031bc9cba0cb53e7d58d86e48beecb49c (patch) | |
| tree | 91677b70ad0cd654313a1e04e4399fb93da21580 | |
| parent | 7fdc1caaef3de48b65a221b31b01cf0eb76c07c0 (diff) | |
| download | gnome-control-center-b8f7065031bc9cba0cb53e7d58d86e48beecb49c.tar.gz | |
keyboard: Fix check for existing shortcut settings
From a Coverity scan:
panels/keyboard/cc-keyboard-manager.c:208: unreachable: Since the loop
increment "i++;" is unreachable, the loop body will never execute more
than once.
This seems like a logic thinko introduced in commit
3207fe97ec516c11f2f781269f9342f36fa8161b . In practice it was unlikely
to be a problem since we don't have repeated shortcut gsettings key
names in all our KeyListEntries files.
| -rw-r--r-- | panels/keyboard/cc-keyboard-manager.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/panels/keyboard/cc-keyboard-manager.c b/panels/keyboard/cc-keyboard-manager.c index 1f90ca7bf..84e1e15d5 100644 --- a/panels/keyboard/cc-keyboard-manager.c +++ b/panels/keyboard/cc-keyboard-manager.c @@ -214,8 +214,6 @@ have_key_for_group (CcKeyboardManager *self, { return TRUE; } - - return FALSE; } } |