| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
evolution-data-server provides a class `E.PhoneNumber` which -amongst
other things- allows us to parse freeform strings as phone numbers. If
successful, it also allows to generate a `tel:` URI which we can use to
start a call with the user's preferred application. Note however that
it's only really supported if E-D-S was compiled with support for
libphonenumber (which provides the underlying implementation).
|
|
|
|
| |
Depend on libadwaita 1.2.alpha
|
|
|
|
|
| |
Action bars are not supposed to be used like this, and it results in a
broken style.
|
|
|
|
| |
Regular libportal doesn't exist anymore.
|
| |
|
| |
|
|
|
|
|
|
|
| |
This allows to fit the application in narrower screens like phones,
where the app would already fit before GTK4 transition.
Fixes #237
|
| |
|
|
|
|
|
|
|
|
| |
Make sure that any operations which are still pending (due to having an
initial timeout, or whatever other reason), are executed immediately.
This fixes several recent bugs that were reported recently on
linking/deletion/... not working if you closed the app soon after.
|
|
|
|
|
| |
Whenever we're on the verge of linking several contacts or deleting a
contact, we should stop showing that contact.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code in `Contacts.MainWindow` that has dealt with operations is
problematic in several ways:
* It only kept track of the last operation, and didn't do that well
either as it could easily be overwritten
* Due to `Contacts.DeleteOperation` being irreversible, it needed
special (and buggy) workarounds
* It repeated code for dealing with operations several times, which lead
to copy-paste bugs.
This commit tries to fix that by introducing a `Contacts.OperationList`
object, which acts as a container and wrapper API for
`Contacts.Operation`s. The most prominent extra API it provides, is that
of postponing execution with a timeout, and being able to cancel ongoing
operations. Both of these APIs allow us to remove any special-casing we
had to do for delete operations.
It also adds a `flush` API, which we can later use to prevent the
application from completely quitting before all operations have
finished executing.
|
|
|
|
|
|
|
| |
It's not safe to try and add or edit a contact before the store
is quiescent, it causes crashes.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
|
|
|
|
| |
It's a little bit less code, and has the added benefit that it adds an
accessibility role as well.
|
|
|
|
|
|
|
| |
A very long time ago, we used `gtk_label_set_markup()` to nicely format
the name of a contact. We changed that quite some time ago however, and
we forgot to escape any possible markup characters. Fix it by using the
"label" property instead.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the util function `get_eds_address_books()` and the several copy
pastes that deal with `Folks.Backend`s coming up and dynamically
changing the list of address book.
Instead, `Contacts.Store` now exposes a `GLib.ListModel` that something
like the `Contacts.AccountsList` widget can use to generate a
`Gtk.ListBox`.
While we're at it, remove `AddressBookList`, as it's not used anywhere.
Fixes a problem in `Contacts.AccountsList` where it showed an address
book as selected, but it didn't seem to register it properly.
Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/238
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 8bec4eba results in the change of the keyfile group for window
actions from "window" to "win", which breaks the action names used for
the undo buttons in the toasts.
This updates the action names used in the source main window sourcefile,
the actions specified in the corresponding ui were updated correctly in
the referenced commit.
Fixes 243.
|
|
|
|
|
|
|
|
| |
gnome-contacts 42.0 fails to build with earlier versions of vala
with "error: `GLib.GenericArray<Contacts.VcardTypeMapping?>'
does not have an `iterator' method".
See https://bugs.gentoo.org/838727 for additional information.
|
|
|
|
| |
(cherry picked from commit 4551f5994153afa2d88e8c27a254efd646f4a2fe)
|
| |
|
|
|
|
| |
(cherry picked from commit c0dd1e6ff23e88968966bc3c77270428703bd5df)
|
|
|
|
|
| |
We're only using this method to scroll to the selected contact, so
remove the optional argument and rename for clarity.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK4 added some interesting concepts on top of / in conjunction with
list models, for example to map one list model on another by sorting
and/or filtering. Another example is to use this with selections.
This commit applies that concept to Contacts, which now uses the
`Contacts.Store` to build a base list model on top of the
`Folks.IndividualAggregator`, on top a sorted model (which can be
adjusted to sort on First/Last name, and finally a filter model, to
filter on the text in the search entry.
Another reason to do this, is that it allows us to use a `Gtk.ListView`
in the future. It's not possible to do so already due to the fact that
we need to differentiate between "Favorites" and "Other Contacts", which
needs extra API on Gtk.Listview side.
|
|
|
|
| |
(cherry picked from commit fe616749255deaa1d017a22586eaac3fe0e01783)
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit 5e5c1938923df706408e8d7831b5854571a9058d)
|
|
|
|
|
| |
We need https://github.com/flatpak/libportal/commit/f0a98e751441532f
for the camera portal to work
|
|
|
|
| |
Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/235
|
| |
|
| |
|
| |
|
|
|
|
| |
Fixes https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/233
|
| |
|
| |
|
|
|
|
|
| |
A bit late, but let's give some people still a chance to do some late
testing.
|
| |
|
| |
|
|
|
|
| |
Fixes https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/228
|