summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Catanzaro <mcatanzaro@igalia.com>2019-05-15 19:02:09 -0500
committerIgnacio Casal Quinteiro <nacho.resa@gmail.com>2019-05-20 07:12:56 +0000
commit2b6503c603cca3e37e70a58cd3d1b778a4e45468 (patch)
tree3546c63ae74f1d121c0e3f2dddca2e02243e0743
parentbb82f1ed29b1933c09f9979a8777cd40585887f8 (diff)
downloadglib-networking-2b6503c603cca3e37e70a58cd3d1b778a4e45468.tar.gz
base: Don't initially cancel waiting_for_op
This is mostly harmless, but it causes a spurious wakeup the first time a TLS source is created while an op is waiting. The cancellable source fires immediately instead of when the op is yielded. The cancellation here is not required for correctness because tls_source_sync() will use a timeout source instead if there is no op or IO waiting.
-rw-r--r--tls/base/gtlsconnection-base.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/tls/base/gtlsconnection-base.c b/tls/base/gtlsconnection-base.c
index 44ecbdd..b75e522 100644
--- a/tls/base/gtlsconnection-base.c
+++ b/tls/base/gtlsconnection-base.c
@@ -222,7 +222,6 @@ g_tls_connection_base_init (GTlsConnectionBase *tls)
g_mutex_init (&priv->op_mutex);
priv->waiting_for_op = g_cancellable_new ();
- g_cancellable_cancel (priv->waiting_for_op);
}
static void