| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Cherry-picking the commits from master were not possible.
So it's a backport.
For relevant commits on master:
commit 5adfe2c8b
commit 21ae0bab6
commit be6c7695d
commit 0476a1d44
See https://gitlab.gnome.org/GNOME/gedit/-/issues/42
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
This also revert the move of the metadata file ("gedit-metadata.xml")
from user_data_dir to user_cache_dir when not using GVFS to store the
metadata
This reverts commit f641a246fbaff482e216197d21e2e51397b1cb26.
Fixes: https://gitlab.gnome.org/GNOME/gedit/-/issues/467
(cherry picked from commit ba2662ff9ee99ef0d85023b06053792fd3eb9272)
|
| | |
|
| |
|
|
| |
Oops. I believe this will work better with Debian's packaging.
|
| | |
|
| |
|
|
| |
Fixes: #485
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when the virtual root that has any number of non-dummy
children is removed from under gedit, depending on the order of calls
to `on_directory_monitor_event()`, a segmentation fault could occur in GTK.
The reason for this is helpfully noted by GTK:
(gedit:71019): Gtk-CRITICAL **: 19:33:58.168: ../gtk/gtk/gtktreeview.c:6711
(validate_visible_area): assertion `has_next' failed.
There is a disparity between the internal view of the GtkTreeView,
and the GtkTreeModel. This generally means that the model has changed
without letting the view know. Any display from now on is likely to
be incorrect.
Due to this disparity `gedit_file_browser_store_get_value()` cannot
succeed at a later point, effectively returning an invalid GValue to
GTK, causing the crash in the end.
That disparity is caused by the fact that when a non-dummy node
is removed, then `model_check_dummy()` is called on its parent
(if there is one). Now, when `model_remove_node_children()` is
removing the children of the virtual root, its first child
will be a dummy node, and that is removed without a problem.
However, the removal of the second child (the first non-dummy one)
will result in a call to `model_check_dummy()`, which will create
a new dummy node because the "original" dummy node has *just*
been removed in the previous iteration. In the last iteration
the `model_check_dummy()` call will see that there are no other
children of the parent, and hence will insert the dummy node
into the GtkTreeModel. And this extra insertion causes the
disparity between GTK's and gedit's state.
Fix that by removing dummy child last. By not removing the dummy
child first, it is guaranteed that `model_check_dummy()` will
*not* create a new dummy node - although it will still insert it
into the GtkTreeModel when removing the last non-dummy, but that
is not an issue since the `model_remove_node()` takes care of
removing the dummy node from the model shortly. It also guarantees
that all children of a node will be removed after a call to
`model_remove_node_children()`, and this makes it possible
to simplify `model_clear()` as it no longer needs to concern
itself with the leftover dummy node.
(Hopefully) fixes #356
|
| |
|
|
|
| |
Closes: #452
Closes: !119
|
| |
|
|
|
|
|
|
|
|
|
| |
As described in #377, attempting to "Save as" with the "unable to save" infobar displayed
(typically caused by trying to save to a directory without the proper permissions) currently
fails silently - the file is not saved, but no error message is given.
This commit causes the Save As function to dismiss the unable to save infobar
(as well as the SAVING_ERROR state), allowing it to behave as expected.
Closes #377
|
| |
|
|
| |
The positional argument has been silently ignored for a time. And it causes failure
with "ERROR: Function does not take positional arguments" since meson 0.60.0
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit acf14cc04f1e66c4c726d9a0b193bf39a28ca8b0 moved FileItems
over to using GDateTime instead of GTimeVal.
This reduced code complexity pretty nicely, but it unfortunately
introduced a bug, where the sort_items_by_mru function was treating
the FileItems themselves as GDateTime objects. That bug causes a
crash when opening files.
This commit fixes the problem by using the ->accessed members
instead of the file items themselves.
Closes: https://gitlab.gnome.org/GNOME/gedit/-/issues/465
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
(cherry picked from commit 3fb5201802227a8cc78b1e7d9c2c5ba10d1ee70e)
|
| | |
|
| | |
|
