diff options
| author | Tomas Popela <tpopela@redhat.com> | 2016-02-12 10:38:27 +0100 |
|---|---|---|
| committer | Tomas Popela <tpopela@redhat.com> | 2016-02-12 11:00:34 +0100 |
| commit | 37551599b8fa53a6ee2a3e519b3d1c3d6f4c8d43 (patch) | |
| tree | 1caa30755ae5dc4d4db3b0d2cfb7e7744f171f3c | |
| parent | 34b9382598f06cf46d804d07cd0456f15911f360 (diff) | |
| download | evolution-37551599b8fa53a6ee2a3e519b3d1c3d6f4c8d43.tar.gz | |
EHTMLEditorUtils - prev_parent variable can be used uninitialized
| -rw-r--r-- | e-util/e-html-editor-utils.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/e-util/e-html-editor-utils.c b/e-util/e-html-editor-utils.c index e18ef7fb71..7a840d5553 100644 --- a/e-util/e-html-editor-utils.c +++ b/e-util/e-html-editor-utils.c @@ -321,7 +321,7 @@ split_node_into_two (WebKitDOMNode *item, gint current_level = 1; WebKitDOMDocument *document; WebKitDOMDocumentFragment *fragment; - WebKitDOMNode *parent, *prev_parent, *tmp; + WebKitDOMNode *parent, *prev_parent = NULL, *tmp = NULL; document = webkit_dom_node_get_owner_document (item); fragment = webkit_dom_document_create_document_fragment (document); @@ -366,12 +366,14 @@ split_node_into_two (WebKitDOMNode *item, current_level++; } - tmp = webkit_dom_node_insert_before ( - parent, - webkit_dom_node_get_first_child (WEBKIT_DOM_NODE (fragment)), - webkit_dom_node_get_next_sibling (prev_parent), - NULL); - remove_node_if_empty (prev_parent); + if (prev_parent) { + tmp = webkit_dom_node_insert_before ( + parent, + webkit_dom_node_get_first_child (WEBKIT_DOM_NODE (fragment)), + webkit_dom_node_get_next_sibling (prev_parent), + NULL); + remove_node_if_empty (prev_parent); + } return tmp; } |