summaryrefslogtreecommitdiff
path: root/src/search-provider
Commit message (Collapse)AuthorAgeFilesLines
* Only show default search engine in search providerJan-Michael Brummer2020-05-161-0/+1
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/-/issues/923
* Load URL when typed in the overviewJan-Michael Brummer2020-05-141-0/+29
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/-/issues/150
* search-provider: remove dead assignmentMichael Catanzaro2019-12-271-2/+0
|
* Mass update: Apply uncrustify style to everythingJan-Michael Brummer2019-07-152-44/+45
|
* search-provider: use g_autoptrMichael Catanzaro2019-04-061-14/+6
|
* search-provider: create skeleton in dbus_register()Michael Catanzaro2019-04-061-16/+14
| | | | It should parallel dbus_unregister(), which is where we destroy it.
* search-provider: don't assume there's always a matching suggestionMichael Catanzaro2019-04-061-0/+3
| | | | | | | | There actually should always be a suggestion, unless gnome-shell is bugged or malicious, but we should be well-behaved and not crash here if there isn't. It's external input, after all. https://bugzilla.redhat.com/show_bug.cgi?id=1696529
* Enable co-existing of Epiphany Tech Preview with stable versionJan-Michael Brummer2019-03-171-2/+4
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/20
* Rename ephy_dot_dir() to ephy_profile_dir()Patrick Griffis2019-01-311-1/+1
| | | | This just more accurately reflects what it actually is.
* search-provider: Improve the "search the web for" stringMichael Catanzaro2019-01-251-1/+1
| | | | | | | | It'd be ridiculous to say "Search the Firefox for pizza party," as pointed out by Florian, so we shouldn't capitalize W here. And we should add quotes to make it obvious what the search term is. Fixes #635
* Update libdazzle and make use of new DzlSuggestionEntry changesJan-Michael Brummer2018-09-161-0/+2
|
* URL entry: Replacing GtkEntry with DzlSuggestionEntryJan-Michael Brummer2018-09-161-75/+44
| | | | Make use of dazzles suggestion entry widget to make url entry more fancy.
* Stop using DzlSuggestionEntry for nowMichael Catanzaro2017-11-221-44/+77
| | | | | | | | | | | It's very promising, but not ready for the master branch yet... poor Carlos Garcia has been suffering this whole time, because I was not using it regularly and did not realize how many problems it had. It's a great widget and a great library, and we should definitely aim to bring it back ASAP. But let's not break master in the meantime. https://bugzilla.gnome.org/show_bug.cgi?id=790732
* Rename search provider service fileMichael Catanzaro2017-10-051-1/+1
| | | | Ensure it gets exported by flatpak
* suggestion: Add unescaped-uri property for the search providerMichael Catanzaro2017-09-091-5/+9
| | | | | | The titles produced by the search provider need to be not escaped. Also, take this opportunity to properly decode the URIs for display.
* suggestion: Add get_uri() method and use itMichael Catanzaro2017-09-091-2/+2
| | | | | | | | Let's be self-documenting... it's a lot more clear to have an explicit get_uri() method than to expect developers to know that the ID doubles as the URI. This requires moving EphySuggestion down to lib.
* search-provider: Port to EphySuggestionModelMichael Catanzaro2017-09-091-80/+41
|
* Add FIXME to be sure I don't forget to bring back the search providerMichael Catanzaro2017-09-091-0/+2
| | | | I might still forget.
* search-engine-manager: get_address() must return NULLMichael Catanzaro2017-09-091-1/+1
| | | | | | | | | | | | | | | The search-engine-dialog relies on get_address() returning NULL to detect new search engines. It doesn't function properly otherwise. All code using this function just needs to be prepared to handle a NULL address. In contrast, get_address_for_default_engine() really does need to always return a result. At least, it's more convenient this way, so that calling code doesn't have to handle that manually. Rename the function to make this more clear and reduce confusion, as it would be odd to have two parallel functions function differently in this respect. https://bugzilla.gnome.org/show_bug.cgi?id=787458
* search-provider: Simplify getting search engine addressMichael Catanzaro2017-09-091-4/+1
| | | | We have a convenience function to get the default search address.
* Port to meson build systemMichael Catanzaro2017-04-261-74/+0
|
* implement search engine managercedlemo2017-02-241-13/+16
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=776738
* embed-shell: Fix dumb return typesMichael Catanzaro2017-02-191-1/+1
|
* Fix search provider horribly breaking history serviceMichael Catanzaro2017-02-181-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the search provider is running, all database transactions will fail because the search provider will take a write lock on the database. Ouch! This is worth a good string of profanities.... Notably, this causes opening the database to fail if you searched for anything in the shell overview in the minute prior to starting Epiphany. (One minute is our search provider timeout.) Then no history will ever get saved, ever. I think. Something like that. So, although our history service has read-only mode, it's enforced at the history service level, not the SQLite connection level. SQLite actually has a read-only mode, which we are not using, and which we need to use in the search provider if we want to have any chance of reliably saving history. Accordingly, give EphySQLiteConnection a mode property, to indicate whether it is in writable mode or read-only mode. Teach all callers to set it properly. Use it, rather than a boolean, when creating the EphyHistoryService, since boolean parameters are hard to read at call sites. And actually put the underlying SQLite connection in read-only mode when set. Don't open transactions or ever attempt to rollback in read-only mode, because that doesn't make any sense. This should never have been happening due to the history service level read-only checks, but it should be enforced at the SQLite connection level now, too. Avoid initializing tables when opening the database in read-only mode. This is obviously writing to the database, and now that we really have a read-only SQLite connection it fails. As it should. SQLite connection creation will now fail in case the connection is read-only and the database does not yet exist; it will no longer be created anyway. So handle this case gracefully. It's fine for the history service to return nothing in this case. This has the small advantage that the history thread will quit immediately after it's created in this case, so it's not constantly running if there's no history in incognito mode anymore. To check for this condition, we expose the underlying SQLite error; previously, only the error message was exposed outside of EphySQLiteConnection. Exposing the error isn't really necessary or sufficient, though, since it's super generic and we have to check if the file actually exists on disk anyway. Test it. Ensure that a read/write history service functions properly if it's running at the same time as a read-only history service. Using two read/write services here fails very badly, but when one of the services is read-only it works fine. Also, remove the original read-only service test. It only ever tested that creating a read-only history service with an empty history database would succeed. And, as I just explained, that fails now. Lastly, stop running a second history service for the search provider. It needed its own once upon a time when the search provider did not run an EphyShell instance. That changed when we stopped using the default web context, because nothing works without EphyEmbedShell now, as all sorts of places need it to get the embed's web context. And since EphyEmbedShell runs its own history service, the search provider can just use that now instead of running its own separate one. https://bugzilla.gnome.org/show_bug.cgi?id=778649
* Revert "Implement search engine manager"Michael Catanzaro2017-01-261-16/+10
| | | | | | This reverts commit 2829c4330285ddc50243aaabb3ab89971c540af9. Didn't mean to commit this, it's not quite ready yet.
* Implement search engine managercedlemo2017-01-251-10/+16
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=776738
* Fix file endingsGabriel Ivascu2016-11-302-2/+0
|
* bookmarks: Add ephy_bookmarks_manager_new()Carlos Garcia Campos2016-11-211-1/+1
| | | | And use it instead of g_object_new().
* Fix linking with WebKit trunkMichael Catanzaro2016-11-041-0/+4
| | | | | | | We forgot to link to nettle and hogweed. It only worked because WebKit was pulling them in via GnuTLS, but WebKit has now switched to gcrypt. Also, use the pkg-config variables in the proper place in tests.
* Remove private headersMichael Catanzaro2016-10-311-2/+1
| | | | | There's no public API anymore and no extensions. Having private headers years later serves no purpose and is just confusing.
* Tweak search provider stamp file dependencyMichael Catanzaro2016-10-241-1/+1
| | | | Should probably be rebuild if the generated Makefile is changed, right?
* Move sync files to subdirectoryMichael Catanzaro2016-10-081-0/+1
|
* Relicense to GPLv3+Michael Catanzaro2016-10-073-33/+39
| | | | | | | | To use GMP. Because a few GPLv3+ files had already snuck in by mistake. And because http://www.gnu.org/licenses/rms-why-gplv3.html
* ephy-sync: Implement the sign in logicGabriel Ivascu2016-10-071-0/+2
|
* Port EphyCompletionModel and EphySearchProvider to the new bookmarks managerIulian Radu2016-09-281-4/+6
|
* Use new icon consistentlyMichael Catanzaro2016-09-221-1/+1
| | | | I missed a few spots
* Style fixupMichael Catanzaro2016-09-181-3/+3
|
* Fix handling of the new stamp fileMichael Catanzaro2016-09-181-7/+8
| | | | Doesn't work if the generated files don't depend on the stamp file
* Run gdbus-codegen only once during buildMichael Catanzaro2016-09-181-7/+10
| | | | | | | | Currently we run gdbus-codegen twice in a row, the second time stomping on the output generated the first time. This is harmless, but it's dumb. Fix it. https://www.gnu.org/software/automake/manual/automake.html#Multiple-Outputs
* Forgot git.mk!Michael Catanzaro2016-09-181-0/+2
|
* Remove inadventantly-committed Makefile.inMichael Catanzaro2016-09-181-871/+0
|
* Move the search provider to its own subdirectoryMichael Catanzaro2016-09-186-0/+1565
View Lorry Controller Status