summaryrefslogtreecommitdiff
path: root/src/bookmarks
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Move bookmark star to bottom bar in mobile mode"Michael Catanzaro2020-09-292-53/+37
| | | | | | | This reverts commit f79108840b9ff2434032a6412634c966680ea42f. This introduced a lot of weird bugs. Like a lot. Some of these are pretty wild. Let's try again later....
* Move bookmark star to bottom bar in mobile modeJan-Michael Brummer2020-09-272-37/+53
| | | | | | URL entry width is very limited in mobile mode, so let's make more space available: move bookmark star to action bar at the bottom as requested in https://gitlab.gnome.org/GNOME/epiphany/-/issues/1172
* bookmarks-popover: Ellipsize long tagsAlexander Mikhaylenko2020-09-231-0/+2
| | | | Make sure long tags don't stretch the popover either.
* Make bookmark preferences dialog resizableAlexander Mikhaylenko2020-09-231-1/+0
| | | | Make sure it properly maximizes on mobile.
* bookmarks-import: Fix importing duplicate bookmarks from HTMLignapk2020-05-021-2/+6
| | | | | | Currently when importing bookmarks with the same url, but in different folders, there is a bug that causes every subsequent bookmark in the HTML file to be added with mismatching name and url. Try to fix this by adding the latter duplicate bookmark's tag to the former duplicate, and skipping adding the bookmark's url, date and title to respective pointer arrays.
* Drop duplicate bookmarks during importJan-Michael Brummer2020-04-281-5/+5
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/-/issues/485
* Add Chrome/Chromium bookmark importerJan-Michael Brummer2020-04-242-0/+124
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/-/issues/352
* Allow importing bookmarks from HTML filesignapk2020-03-072-0/+216
| | | | | | | | | | | Currently there is no way to import bookmarks from HTML files using Netscape Bookmark Format. To fix this issue, add option to import from HTML in the bookmark import dialog and parse the chosen file usign GMarkupParser for bookmark url, add date and title. https://gitlab.gnome.org/GNOME/epiphany/issues/483
* Fix bookmark-editing lockdown optionJan-Michael Brummer2020-03-071-0/+7
| | | | | | | Hide bookmark star in location entry and preferences button in bookmark popover. Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/339
* Fix blank space in bookmark row and add tooltipJan-Michael Brummer2020-03-071-2/+5
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/1119
* bookmarks-popover: fix several leaksMichael Catanzaro2020-02-173-7/+17
| | | | | | | The result of ephy_bookmarks_manager_get_bookmarks_with_tag() must be freed. Fixes #1102
* bookmark: free everything in finalizeMichael Catanzaro2020-02-171-1/+5
| | | | | | Lots of data leaked here. :( Fixes #1099
* add-bookmark-popover: Fix bookmark ids collisionsYetizone2020-01-281-1/+1
|
* ephy-bookmark: Add ephy_bookmark_generate_random_id()Yetizone2020-01-282-0/+22
|
* bookmark-manager: Fix unlocalized "Mobile" tagJonathan Kang2020-01-151-1/+1
| | | | | | | | Bookmarks in the folder named "Mobile Bookmarks" will be sync to epiphany with "Mobile" tag. Though the string is marked for translation, it didn’t end up in the UI. Fix that here. https://gitlab.gnome.org/GNOME/epiphany/issues/1015
* Update bookmark dialogsJan-Michael Brummer2020-01-101-2/+4
| | | | | | Fit bookmark dialogs for smaller screen sizes Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/371
* bookmark-manager: Store and use localized "Favorites" tagJonathan Kang2020-01-083-8/+4
| | | | | | | | | | | Previously, the unlocalized string "Favorites" is stored and used to compare with localized strings, which leads that no bookmark is tagged as "Favorites" even if you do so. Fix that by storing localized "Favorites" string directly and use that for populating the bookmark grid. https://gitlab.gnome.org/GNOME/epiphany/issues/1015
* bookmarks-manager: add assertionMichael Catanzaro2019-12-271-1/+3
| | | | | If this function fails, error had better be set. scan-build gets tripped up here otherwise.
* ephy-bookmark: Do not crash if time is negativeJan-Michael Brummer2019-12-241-2/+1
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/454
* Fix crash in ephy_bookmarks_manager_init()Michael Catanzaro2019-12-161-1/+1
| | | | | | | | This is a regression from 3.34, we have 1341 reports of this in Fedora from 513 unique users. Problem is the error returned is uninitialized memory. Oops. https://bugzilla.redhat.com/show_bug.cgi?id=1768089
* Use an in memory history database for incognito modeJan-Michael Brummer2019-11-271-1/+1
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/891
* Remove various unused member variablesMichael Catanzaro2019-11-172-4/+0
|
* Open bookmark in new tab when clicking with middle buttonJan-Michael Brummer2019-11-131-14/+40
| | | | Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/86
* bookmarks-import: Fix error handlingMichael Catanzaro2019-10-161-11/+12
| | | | | | | | | | | | | We need to, at minimum, use g_clear_error() to ensure it is NULL before passing it to g_set_error(). But it's simpler to use a separate GError for internal errors instead. Now instead of crashing, we'll show a nice error message "Firefox bookmarks could not be retrieved!" This isn't ideal, however, because clearly the code expects to trigger the earlier error message ("Close Firefox and try again") but is failing to do so. Fixes #965
* Ensure tag scrolled window has correct sizeAlexander Mikhaylenko2019-10-062-0/+21
| | | | | | | | | | Specify min-children-per-line so that its natural height always matches content, and make bookmarks dialog unresizable so that it follows the flowbox height. Since scrollbar minimum height is larger than one row of tags, explicitly hide scrollbar when there are less than 3 tags, i.e. when there is only one row.
* add-bookmark-popover: Ensure popdown animationAlexander Mikhaylenko2019-10-061-5/+9
| | | | | Animate popover after removing the bookmark, and wait until the animation is done before destroying contents.
* Mass update: Apply uncrustify style to everythingJan-Michael Brummer2019-07-158-137/+143
|
* Fix ephy_bookmarks_manager_save_sync()Michael Catanzaro2019-06-271-2/+3
| | | | | | This is causing crashes on startup when running with -p, because we do a sync save of the bookmarks file if it doesn't already exist when creating the bookmarks manager.
* Make ephy_bookmarks_manager_save_to_file_async() actually asyncMichael Catanzaro2019-06-227-116/+237
| | | | | | | | | | | | | | | | | | | | | Currently it looks like an asynchronous function, but it actually does sync I/O, which is bad. This also requires also making ephy_bookmarks_export() async, which required adding gvdb_table_write_contents_async(), which I upstreamed to GVDB. (It was added to Epiphany in the previous commit.) It also requires adding GCancellable parameters where required, to avoid introducing new crashes. This means we need a way for external code to access the EphyBookmarkManager's cancellable or we would need to get rid of the warn_on_error convenience callback. Also, remove ephy_bookmarks_manager_load_from_file(), since it's only one line long and only used in one place. Finally, rename the functions according to Carlos's feedback. Fixes #336
* Update GVDBMichael Catanzaro2019-06-221-4/+4
| | | | | | | In particular, this adds gvdb_table_write_contents_async() from gvdb!4. It also requires changing some integer types due to an API break in gvdb_table_get_names().
* Rename ephy_dot_dir() to ephy_profile_dir()Patrick Griffis2019-01-311-1/+1
| | | | This just more accurately reflects what it actually is.
* bookmark: ensure tags sequence is always createdMichael Catanzaro2019-01-071-4/+6
| | | | | | | | | | | | Somehow we are getting EphyBookmarks objects deserialized without initializing the tags property. I'm not sure how this happens. It even happens for JSON corresponding to bookmarks that definitely have tags set. Anyway, ephy_bookmark_get_tags() is used as if the result is not nullable, so let's guarantee this and return an empty list instead in this case. This is a speculative fix for #612. It should fix the reported crash, but it's possible it will only uncover a subsequent crash.
* add-bookmark-popover: Use g_auto*Yi-Soo An2018-12-031-8/+11
| | | | Use g_auto* instead of manually freeing resources.
* bookmark-properties-grid: Use g_auto*Yi-Soo An2018-12-031-5/+3
| | | | Use g_auto* instead of manually freeing resources.
* bookmark-row: Use g_autoptrYi-Soo An2018-12-031-5/+2
| | | | Use g_autoptr instead of manually freeing resources.
* Tags with empty labels are no longer allowed in bookmarksAral Balkan2018-11-291-1/+1
|
* bookmarks-popover: Drop window construct paramAdrien Plazas2018-06-212-42/+9
| | | | | | Drop the EphyWindow parameter from the constructor to instead get the window by getting the ancestor. This implies that all EphyBookmarksPopover must be put into an EphyWindow for them to work.
* Add unified url barJan-Michael Brummer2018-06-191-1/+3
| | | | | | Unified URL bar moves reader mode button into the url bar. Fixes: https://gitlab.gnome.org/GNOME/epiphany/issues/39
* Use g_value_dup_string where possibleMichael Catanzaro2018-06-151-3/+3
|
* bookmark-row: Display URL for bookmarks without titleMichael Catanzaro2017-12-291-3/+31
| | | | | | | | | | Bookmarks don't have to have a title. In that case, we should fall back to displaying the URL. Bookmarks don't have to have a URL either, but in that case, blank is probably the best we can do. https://bugzilla.gnome.org/show_bug.cgi?id=792048
* sync: Migrate timestamps to gint64Gabriel Ivascu2017-12-124-13/+12
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=790819
* sync-service: Do batched uploadsGabriel Ivascu2017-12-031-13/+13
| | | | | Speed up sync by minimizing the number of requests sent to the storage server.
* bookmarks-popover: Do not add bookmarks to unrelated tag view popoversMal2017-11-041-14/+31
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=788584
* sync-records: Convert NULL to empty string for serializable string propertiesGabriel Ivascu2017-11-011-18/+22
| | | | | | Firefox may afford to work with NULL values since JavaScript is more permissive than C, but we cannot afford to crash because of a random misplaced NULL value. Better be safe than sorry.
* sqlite-connection: Add function to delete database filewip/google-safe-browsingGabriel Ivascu2017-10-031-2/+2
| | | | | | | EphySQLiteConnection now stores the path to the database file. This removes the duplicate code in EphyHistoryService and EphyGSBStorage and also removes the need of ensure_empty_database() in ephy-sqlite-test.c
* Purge g_return from src/Michael Catanzaro2017-09-135-44/+44
|
* Fix leaks of GtkContainer children listGabriel Ivascu2017-08-241-4/+7
|
* bookmarks-popover: Don't snapshot URLs when creating new bookmark rowsGabriel Ivașcu2017-08-243-72/+49
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=780549
* bookmarks-manager: Don't force the creation of Mobile tag when syncingGabriel Ivascu2017-08-231-3/+0
| | | | | | | | | Currently the Mobile tag is created in case it doesn't exist before merging bookmarks at sync time. This is both undesirable considering the user may not have any mobile bookmarks and unnecessary since any missing tags are created during the merge operation. https://bugzilla.gnome.org/show_bug.cgi?id=786590
* bookmarks-import: Import Firefox mobile bookmarks under Mobile tagGabriel Ivascu2017-08-163-8/+16
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=780353
View Lorry Controller Status